Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4713552iob; Sun, 8 May 2022 22:59:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjOYJc4OPxPkltyj8wDTU+JQp0lB5nLrq0y6vK8UlyDQE3/cDmQznWFkJlK0Jtm+YyBozw X-Received: by 2002:a17:902:bb83:b0:15f:715:7375 with SMTP id m3-20020a170902bb8300b0015f07157375mr6426516pls.89.1652075950527; Sun, 08 May 2022 22:59:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652075950; cv=none; d=google.com; s=arc-20160816; b=wdkxJ3z8E2ajghPoMFcG8+zeNN1ZsKy7zy6aFydCZPyYs9JwvmYRH1e/RPYSqW/OxU z6szZzohdFEQXyJ44Ygb9wawCX6D4lJHmiHPrpG9DLaN6lV6aXgu4qXqGhkmWRANtvbh QqAW7MmprxN39kznb7+mRdR3jUi9FG0W+6jgOT5xa96q/qcz4uP/HXbU5x4rdip+nU0g rzqfX8CmK8e+01N2FXfOPr2pmuOOS99Co6dq2jxQGFEN17dCN6px23XwH6T4Up3LJyhF j1wb4Oe26h2Hmo8xgVqrzyz7dTOVkgtSxGCUCiuak1OJ48PCKib0At7NPvzJaw4T83IG M/HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=luo9ZqWXGqpZmqKH3VuoQb2SudPsKfeaszvjpuhSbhc=; b=kHnCUkneCZd0cdg6DpZ5Nlj/PKhhr5Q/t7digOFuVeH1CtY9YXBPZRxO4wX4XFqIrO q/mqiA14ucd6U9o8g0LnZFYDmDymXx//JnXeeIzgh9ub+4PBoDEBqG4whDSKHin5Teco qBGrVaxqeV9fR7TWclPpzl2lChggUg3n44Rw7wsFwZHWlLGHy3YTyM+tykbQLIU6wPcb /1nSLeyf+SSK16XBJYCS7PYBiwnLXMFVV4QVi+TvlLB5Te1Ir1JP9jdoG/0JX2NYzDsj RW5sm7H8feZHaSaMA891ldUw2a52jKhpwGAFrge8703Xxe6Xsx0yETjLpn4hsSpwyAEQ PueA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id x12-20020aa793ac000000b0050a73a14910si12004799pff.218.2022.05.08.22.59.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 22:59:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 29760166080; Sun, 8 May 2022 22:57:20 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353555AbiEDQpp (ORCPT + 99 others); Wed, 4 May 2022 12:45:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352390AbiEDQpn (ORCPT ); Wed, 4 May 2022 12:45:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAA332E9E3 for ; Wed, 4 May 2022 09:42:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6D09C6173B for ; Wed, 4 May 2022 16:42:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43F5CC385A4; Wed, 4 May 2022 16:42:04 +0000 (UTC) Date: Wed, 4 May 2022 17:42:00 +0100 From: Catalin Marinas To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, alex.popov@linux.com, keescook@chromium.org, linux-kernel@vger.kernel.org, luto@kernel.org, will@kernel.org Subject: Re: [PATCH v2 13/13] arm64: entry: use stackleak_erase_on_task_stack() Message-ID: References: <20220427173128.2603085-1-mark.rutland@arm.com> <20220427173128.2603085-14-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427173128.2603085-14-mark.rutland@arm.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 27, 2022 at 06:31:28PM +0100, Mark Rutland wrote: > On arm64 we always call stackleak_erase() on a task stack, and never > call it on another stack. We can avoid some redundant work by using > stackleak_erase_on_task_stack(), telling the stackleak code that it's > being called on a task stack. > > Signed-off-by: Mark Rutland > Cc: Alexander Popov > Cc: Andrew Morton > Cc: Andy Lutomirski > Cc: Catalin Marinas > Cc: Kees Cook > Cc: Will Deacon Acked-by: Catalin Marinas