Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4714138iob; Sun, 8 May 2022 23:00:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBmuxWqIUSiwFACKYi3fpaOfcCifL8QdWJ9DMvDuQQWHruzJ1GuvyjyRYgRGkabGvOtFJo X-Received: by 2002:a17:90a:8b91:b0:1be:db25:eecd with SMTP id z17-20020a17090a8b9100b001bedb25eecdmr16519623pjn.10.1652076022990; Sun, 08 May 2022 23:00:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652076022; cv=none; d=google.com; s=arc-20160816; b=igOVxI/4/9YeEMVuXLpyP29LfEEsdp19qQKXwzRdWKDv+3oaMK5LLWMOi5fdFOfZ+o n8Rq7C/CSfSc62iV3HYT2o93YTBDVz9xW/IKTP+pvEQ176YBf9yqK2T2YbxL5l/zy1na G+3xBg7wAdoA2ZqJlJ2/Ee4CR0/3/OQxB2enA6aS1fM1cADO0kVU72nYQFhTHaxFVGLz E3FHDvjz3RrYQz4UXb/aE40KWBayXlPuk4ETaSP/8Uf+bKOsGsBx2O5nHGSk8RsxNKDF bFn+b4966VO4utmKaAw0MU/lKQcuGk6lCCqOLRSE6FA5W2kBbXtFQo6Me4/56ZjQUhpY E9Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=DkUwtrsYptov9Gj+PCdtDq4UUg6zIEJEVmvjrjfLUlA=; b=lT007OpXBiXeBOefBa8uFiAonmdQpItWvey0CYB8N2CVY3dmdJm4rH4DG8379sjED5 bK104o3mGsUcT4FUHpJV2QAe80PrmAtQscYhjm4/GaVb4YwZ5rpEyLf/rEM1WmXDtwGv xesVnEYlVDfmxOIzt8fSfu8T2TUErX4i5svWcjxw26jRsaT2M9SOF8mUboD3VkxjnzVd NofhbfzGZRhqKghExcMNupU9P5tRclVwIhWM1nu8CJ3NVVJ8x20AZWJkWNc0uWw85FIc XsoqB3ASPcGv/yC4x0n/oXdxMS2pVEiLxlnVoYgDwR1AFhE8ZFB5bRpbITw9+uM0gAA4 MbPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VQTrdVLN; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id l21-20020a17090a409500b001d95e1f2beesi12100861pjg.64.2022.05.08.23.00.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 23:00:22 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VQTrdVLN; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1A2FF11920E; Sun, 8 May 2022 23:00:13 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1386371AbiEEWiR (ORCPT + 99 others); Thu, 5 May 2022 18:38:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243371AbiEEWiK (ORCPT ); Thu, 5 May 2022 18:38:10 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12CDC53A47; Thu, 5 May 2022 15:34:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B84CEB830E8; Thu, 5 May 2022 22:34:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 662E0C385AE; Thu, 5 May 2022 22:34:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651790067; bh=pRdKLJeOO/4QGSwZjRZR4WU9c4pmiE3H+nSf9u6bRa8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VQTrdVLN1qI1+X21HFeSDvt/B0QMqHImVVY2UZ+Zjrvasw3vg6VpKRuzFW69PFdsJ S4n8O8WYPLVQBIubmGisxCOb0zqECRFPjET28CbNSxd8d2uduPEmtKc/u1KzakOLWK sESKQx6Ww/VBMHVVpJbFbKRIj1zaFV0DoQWfB0GY= Date: Thu, 5 May 2022 22:50:03 +0200 From: Greg KH To: Shubhrajyoti Datta Cc: linux-serial@vger.kernel.org, michal.simek@xilinx.com, jirislaby@kernel.org, git@xilinx.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] tty: xilinx_uartps: Check the clk_enable return value Message-ID: References: <20220429081422.3630070-1-shubhrajyoti.datta@xilinx.com> <20220429081422.3630070-3-shubhrajyoti.datta@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220429081422.3630070-3-shubhrajyoti.datta@xilinx.com> X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 29, 2022 at 01:44:17PM +0530, Shubhrajyoti Datta wrote: > Check the clk_enable return value. That says what, but not why. > > Addresses-Coverity: Event check_return. Shouldn't this be a covertity id? thanks, greg k-h