Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Yihao Han <hanyihao@vivo.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com, Yihao Han <hanyihao@vivo.com>
Subject: [PATCH v2] i2c: s3c2410: change return type of 'i2c_s3c_irq_nextbyte' from 'int' to 'void'
Date:   Fri,  6 May 2022 05:26:39 -0700
Message-Id: <20220506122639.2544-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YWfvuiADDYz/Z4mFO6IVuKkyIoLSlK4oCoONmNjKIvv9EmN2UiO1dJE8GQf7?=
 =?us-ascii?Q?9g50G689tstDuZTkmik+KMJ78gnvKIknZmCF39jm3cK3hbaSWsGwhXA//K3o?=
 =?us-ascii?Q?gTkPbRgXPr5ZARhGw80AtITANrv/PZUsFtNNLwz+fUHJpmC9DYkLzWIqfzEg?=
 =?us-ascii?Q?dfwquev2kN7HvbrS/WerxrpVlbffVapn/1/g1viZDZb+SjbTsVQUq6T/K8tV?=
 =?us-ascii?Q?d4YE9f2dDDGbrZ9R3gV7wzU08+pis9PQWnyo03mMvLshlC96eOAatT+nhpCU?=
 =?us-ascii?Q?n9SmivPUHgGHtlu8EGwqlAK5xUyZ5tJ97+j6H2NMwrVpK/8qaTLWGoemZMN5?=
 =?us-ascii?Q?ak7PDyJidtMKy4pxrmrzRZljsNA3EjgxkG+UdkUU07uE0uqYX1xUlmTDDjwQ?=
 =?us-ascii?Q?T/4+hWnJkRiAQl8pq8o44+lJxef+EVPL1iyr4H4mV6OuH0zgg5CeOBs36T+0?=
 =?us-ascii?Q?I5tPCuS8Fg8MMQptzKSGK6f0jB9l/gSzBIOEq20g12M1CV5wqRL+bhHUHk6S?=
 =?us-ascii?Q?LhqW+Qg0B91JwkCnV3nwNms56BvhwFuW2J/P+B0KnXr/gXlswG/34PDiznfn?=
 =?us-ascii?Q?ZeNaQ8Okl1V9b8F/qv28+NquzLUlZAmWle7fjuETnRle3JlN1cHMjlB9yYJg?=
 =?us-ascii?Q?MGhyuNF59RUCsn1m0G2gyBVJHawOs2fMfy+0V1I2bXGI2dHBWS94jUtpm4fS?=
 =?us-ascii?Q?zqa0wvab6RcjNd8FzqppOlT4gXez7UjU8YyU0HgJeWNw8CbDMbCNevd4qsJM?=
 =?us-ascii?Q?mKbvOcw7etbJq08SVm/PpP/ai6gJOw1VKKyKzZl7MubJLFZ1X2fcsNoPBwEQ?=
 =?us-ascii?Q?W+Z2voYzVtXBaCt73ONNPDDyfSfzkYQ7PC7DymkdHJsuiU6f2ghd4JoEUhTn?=
 =?us-ascii?Q?D4WLrpqHVFED1LpwBimbqAk/4OvppBqvGtdjrz8ngml8juSI4+EjfcBnwSVu?=
 =?us-ascii?Q?y5lGTtqWkZL1M5tPYSGmeCUpblDSQyyVIYcV7Tm5rlS6xoWwSc7C64ErtvnG?=
 =?us-ascii?Q?Awb+jb//unXmohlWQ8TH3kl92apN74S89BlKl56AxIfIaRVt8iTW2s2auMQd?=
 =?us-ascii?Q?Gy02/oyseBTZO4h2hImi7eOI7yLmGtt/k2HdHWV7b1zJymxfOBii1jAckdXk?=
 =?us-ascii?Q?vLH5isc7pAKSvF6S2eePcHnXqGojB9RNKGZNKYkgfb/qJyf3f/9RfYc2lQmV?=
 =?us-ascii?Q?QtCHt2ZtRJ07lMSAeq62ueBy13du26YMdwIbWtZj+Zb3xBQ0NUlfM+OCEg+O?=
 =?us-ascii?Q?jfYXNstOrT5L73g/OT6FyFYpzzcaRRb3HL3QOKQzllUM/Jims4ttyHSpUer4?=
 =?us-ascii?Q?H/gBNjeGrpKEyoEKtU0vxuGz+ivgJnNCykd7K6DT1LeCC62rXGfj2jyNEM6c?=
 =?us-ascii?Q?3aWSL6IPWgnHaMVCkIPsIB76WexR21h0/1cqbTW+jRZo+1IwX0AzImldYgln?=
 =?us-ascii?Q?QGow63guHvBVJvLE5ywO5YaVGooyWGGCXFIMV5hes8t0NY+1IbDdqjPvF6bc?=
 =?us-ascii?Q?je6ciAVtOJwofl8LRgqZvwXpflpknZhWcbM+Y06ngLg8cao2objnMLOYOM+i?=
 =?us-ascii?Q?Q2rjxuHaXg1PiWi7on68Bcuvmp7hayng3tqhotFedleZVGd3rlkQ7idk+d29?=
 =?us-ascii?Q?0KOQKncb8biR0k20g71o1zO3Y+uN1+APj8vHjvTG5ZVNkgLYUk5HwYzL5QJS?=
 =?us-ascii?Q?Prgh0+MUy37Nio673byte4bFQN9GPIm+y/QYxaTbXccceFH2J8cxKIY6FCdT?=
 =?us-ascii?Q?+AAtJ0HBcQ=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa97e45b-8ca2-4c5f-bb04-08da2f5bb71c
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 12:26:58.8395
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dMXsO48mZ9VbFbljG7CCZ556DGStBwutcNkWPD7FDkWznrCKoEBfj8LzdzbU463+nPCWFwLCeukZSdIIQC01BQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR06MB2669
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since ret is a redundant variable, and none of the callers check
for return, so remove ret variable and change return type of
'i2c_s3c_irq_nextbyte' from 'int' to 'void'

Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
v2: add return in STATE_IDLE case
---
 drivers/i2c/busses/i2c-s3c2410.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index b49a1b170bb2..d2a1fd2aa7a0 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -381,17 +381,16 @@ static inline int is_msgend(struct s3c24xx_i2c *i2c)
 /*
  * process an interrupt and work out what to do
  */
-static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
+static void i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
 {
 	unsigned long tmp;
 	unsigned char byte;
-	int ret = 0;
 
 	switch (i2c->state) {
 
 	case STATE_IDLE:
 		dev_err(i2c->dev, "%s: called in STATE_IDLE\n", __func__);
-		goto out;
+		return;
 
 	case STATE_STOP:
 		dev_err(i2c->dev, "%s: called in STATE_STOP\n", __func__);
@@ -547,8 +546,6 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
 	tmp = readl(i2c->regs + S3C2410_IICCON);
 	tmp &= ~S3C2410_IICCON_IRQPEND;
 	writel(tmp, i2c->regs + S3C2410_IICCON);
- out:
-	return ret;
 }
 
 /*
-- 
2.17.1