Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Sender: Minchan Kim <minchan.kim@gmail.com>
Date:   Thu, 5 May 2022 09:57:01 -0700
From:   Minchan Kim <minchan@kernel.org>
To:     Alexey Romanov <avromanov@sberdevices.ru>
Cc:     akpm@linux-foundation.org, ngupta@vflare.org,
        senozhatsky@chromium.org, linux-block@vger.kernel.org,
        axboe@chromium.org, kernel@sberdevices.ru,
        linux-kernel@vger.kernel.org, mnitenko@gmail.com,
        Dmitry Rokosov <ddrokosov@sberdevices.ru>
Subject: Re: [PATCH v5] zram: remove double compression logic
Message-ID: <YnQB3X2wy7lEku+y@google.com>
References: <20220505094443.11728-1-avromanov@sberdevices.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220505094443.11728-1-avromanov@sberdevices.ru>
Precedence: bulk

On Thu, May 05, 2022 at 12:44:43PM +0300, Alexey Romanov wrote:
> The 2nd trial allocation under per-cpu presumption has been used to
> prevent regression of allocation failure. However, it makes trouble
> for maintenance without significant benefit. The slowpath branch is
> executed extremely rarely: getting there is problematic. Therefore,
> we delete this branch.
> 
> Since b09ab054b69b, zram has used QUEUE_FLAG_STABLE_WRITES to prevent
> buffer change between 1st and 2nd memory allocations. Since we remove
> second trial memory allocation logic, we could remove the STABLE_WRITES
> flag because there is no change buffer to be modified under us.
> 
> Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
> Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>

Acked-by: Minchan Kim <minchan@kernel.org>