Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4734662iob; Sun, 8 May 2022 23:41:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxONbuKbDy0hgQ3wbG+jPuiy6Wa8uOEAw8Rldh1lDUDr5tzH196qOnsE352Hyeh5oTq8aEN X-Received: by 2002:a63:b44:0:b0:3c6:9490:1b7a with SMTP id a4-20020a630b44000000b003c694901b7amr5980115pgl.478.1652078468432; Sun, 08 May 2022 23:41:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652078468; cv=none; d=google.com; s=arc-20160816; b=KGbDZTEHDE8uC9m552w3aI3Xu11O+2vzfepBWpelBe1IjaZKYJKvef0iqG43kJ55ss afjl4kOa5fU/NTc3Xhs3vPzTwKZPaXUn0uRj+4U97Uwu8rDyQjcdqAABMwmWJdwG+oVA M8Gi6m2O7nnMHmHDOdfRa0cb05i+ZYs3XnjVTzbpDaImVEAHqIU2eyfRPNtCUzIZHCW3 KrqBMDI16RbculDDNuDs5N4BctubKJ9OS8JaR8qBleK453Lg2h9MAH4eHg+20R5GU7Hh Ut64K5vmHXbUJfUHACalzLF5OMDvfpH3NtqtZYXHAjQzDIvMYmLIZBtGIj4mlnUrxtPQ fz0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=2utLszVOX1va5kwC4Bhl/oahyyYjhEmmhysyvWRmi08=; b=e+bvgC0EUP4OtgMbK1PiJZVoci5fUSrm+QbaZ9/xGV8zoV3daZLjZAvqOYer0tBKAZ YWjEBIU9pmDVZVlmjDxceUEvOA67/rTH/TNSHa6/IslfXbrvEnt0rpEGC7dLG5P3B+4a hcHgfqDMtA+TrgYf+SgI+bBwyPG6AvsM9jE/qhAFohSfjaR8GdAzPYsYm/Pc3oXAd4Mm ztF2zoXXv8wORVsPO4X62/WDBxPNz+/kvsJqE9lVTkY6npS25ZpVG9AT6QG7PkFikZUf 46Jh3moWKetcebS0mip5OZskvV16qXJU8ig25ocP+d6vccbD0P4461e3ATUOipDDo3Gr 0E7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="kkT7CCy/"; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id o18-20020a63e352000000b003c6c145ef3esi3190874pgj.84.2022.05.08.23.41.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 23:41:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="kkT7CCy/"; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1A5A418DAE1; Sun, 8 May 2022 23:38:29 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231793AbiEHJPF (ORCPT + 99 others); Sun, 8 May 2022 05:15:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231431AbiEHJPE (ORCPT ); Sun, 8 May 2022 05:15:04 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 930D2213 for ; Sun, 8 May 2022 02:11:14 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 504361F94E; Sun, 8 May 2022 09:11:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1652001073; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2utLszVOX1va5kwC4Bhl/oahyyYjhEmmhysyvWRmi08=; b=kkT7CCy/jg/Zfk+LWkO9m8oycjdgnuDsT+UfJU9Yp0PtuXlMfb5aoJbbQch733UTG+qi0f lYSVc77uv6gflvMXUNnJE5cYTjFsS6fsbzIOftASbPW4VGldQ9Tqfmrhe6q2FAkru07ZIt GXHlmi+WajS4CD7yDUIZ4RNWta++q4k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1652001073; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2utLszVOX1va5kwC4Bhl/oahyyYjhEmmhysyvWRmi08=; b=CCmfS9bk3y21RXSbTTZIbzVf7sIoDEaREDL3/wR+CrNhvnMO3hOEV8FYhQ8/mdD+Ip9N0C PGMGjdg6zvjzqvDQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 3D15C2C141; Sun, 8 May 2022 09:11:13 +0000 (UTC) Date: Sun, 08 May 2022 11:11:13 +0200 Message-ID: From: Takashi Iwai To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, kernel test robot , Jaroslav Kysela , alsa-devel@alsa-project.org Subject: Re: [PATCH] ALSA: hda - fix unused Realtek function when PM is not enabled In-Reply-To: <20220430193318.29024-1-rdunlap@infradead.org> References: <20220430193318.29024-1-rdunlap@infradead.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 30 Apr 2022 21:33:18 +0200, Randy Dunlap wrote: > > When CONFIG_PM is not enabled, alc_shutup() is not needed, > so move it inside the #ifdef CONFIG_PM guard. > Also drop some contiguous #endif / #ifdef CONFIG_PM for simplicity. > > Fixes this build warning: > sound/pci/hda/patch_realtek.c:886:20: warning: unused function 'alc_shutup' > > Fixes: 08c189f2c552 ("ALSA: hda - Use generic parser codes for Realtek driver") > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Cc: Takashi Iwai > Cc: Jaroslav Kysela > Cc: alsa-devel@alsa-project.org Thanks, applied now. Takashi