Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4739003iob; Sun, 8 May 2022 23:50:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJHjcwXCGhkL2F9x4nofWKMp2ixJ6KN11LI0BmWBkoTkA4BMEU3OSHcVfqpVcOFEV3FWHx X-Received: by 2002:a17:902:da85:b0:15e:8e05:6963 with SMTP id j5-20020a170902da8500b0015e8e056963mr15017622plx.94.1652079020993; Sun, 08 May 2022 23:50:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652079020; cv=none; d=google.com; s=arc-20160816; b=hE90EuP/v0xb4mTyKPbQ9oZeQZkRamq48VN3vP4/UU/HkR7cge0OfVVso+zNlNgUDY FYXVfh7mAS+6C2OK3CdQY9HIymX5vo1CaZHeZj4ArejLYltjajayhESVpeoVUSOEkpMn AcZAuAy07oosLKSQIf9QrfEXxUD43qz10wYsVWFHLVM7gBXat2ynPwnsdiKv3y2Czomd R2lPWtWOWn8rCNnV0icCbXGR+v95bptDqbWEb7ybpZJx1VrHSiTAbJTF1LNJAPytGD5m 9Z9jeziMF+LzqrIPKwHm2TGu8gojJIyTMT8WUzN56lD2mYgXXfscKhpo3bbPfE7e1X/s TbkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :to:from:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=sZhIyFRjz2B2FBhmxI4CKd0vqDu29YnVx/Q0rHmcXR0=; b=ed2zAPcv+WRt/yfdmOykv1jja6IStQMfFgfrcw8RCyRA3nBFiKbs/Ww0uXapFNyvMI eeoKkr5ilWLjH7ikRRlLPbWNC4Cs0ON8qIVYohQRQeIlc3bRIsXE88euTx+4I7EMCrfo I/h4uDQM0bv+PnhozM5mrwvYqpgH8XwteEsYrmHIV8oPMRd2W9hAcfsMy8OlQboWQAqo Wd2oQROB25b94dALbp/PGoNp545j5YfCEPNAYJDvq1rORQTB3dyYSnzPZWKAtrEgrQF7 seFaQkeJM4coYDmOlPHsfWHqGel4pTmWkCnXuBFfhQF6UGaBrTKRGMDTaKRBBS/QnOo7 DhaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="k/jjN0Ep"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id j19-20020a632313000000b003aad793d0cdsi12907477pgj.659.2022.05.08.23.50.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 23:50:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="k/jjN0Ep"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5FB09132765; Sun, 8 May 2022 23:46:08 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234658AbiEHP0Q (ORCPT + 99 others); Sun, 8 May 2022 11:26:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234601AbiEHP0O (ORCPT ); Sun, 8 May 2022 11:26:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE167BC9F for ; Sun, 8 May 2022 08:22:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2624E611F2 for ; Sun, 8 May 2022 15:22:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C5BBC385A4; Sun, 8 May 2022 15:22:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652023343; bh=QLvcNqSRrOP4peiOakXtQ+o1e+ref41gMxFR4ScwGME=; h=Date:Subject:From:To:References:In-Reply-To:From; b=k/jjN0Ep6X5SWSgt3qGSljRVJelyTo4gci2F73GH92VnDVgrbzROx1hljGM35hKPx FEiqkd0Y3cVVaklppEsDjxSRW/VhQaIAYdrDIMcibv8Ba3U3adDIXTiz6gbLXa8v3y jhsyYVCK+me6n0V8tHWT2+sFWc/HcL8i25JI1GVz2oTlsVWyBM74N6KkACY7cc9Bqd FZT4mWaJ6dypcFH+UEA69lMhk7kyDItxL4F2yiDMx3Y/4fxxhdnEOX6k55/VY/rmV/ YqsPfW/ES2GhtRj9h4V2Z3A+hVZpAhrVUMKuGq1+KNGxUCTT8qH39PY6eGe+kgFGMz GRbG12I0wIMIA== Message-ID: <44d184dd-ad4c-eac9-c631-98fabcc14294@kernel.org> Date: Sun, 8 May 2022 23:22:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [f2fs-dev] [PATCH 3/5] f2fs: keep wait_ms if EAGAIN happens Content-Language: en-US From: Chao Yu To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20220506232032.1264078-1-jaegeuk@kernel.org> <20220506232032.1264078-3-jaegeuk@kernel.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/5/8 22:41, Chao Yu wrote: > On 2022/5/7 7:20, Jaegeuk Kim wrote: >> In f2fs_gc thread, let's keep wait_ms when sec_freed was zero. > > sec_freed won't increase for background GC due to below statement: > > if (gc_type == FG_GC && > get_valid_blocks(sbi, segno, false) == 0) > seg_freed++; > > It may cause gc thread migrates lots of segments in each round? Please ignore this comment, I misunderstood it. :-P > > Thanks, > >> >> Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks,