Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4741027iob; Sun, 8 May 2022 23:55:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxeEguGT90XrZNvVXuqcQngPedZvZtkWIIPQG5rG0F4aYNxJmN+29YdHXCcsWD9OodRzxQb X-Received: by 2002:a17:903:32c6:b0:15e:c1cc:2405 with SMTP id i6-20020a17090332c600b0015ec1cc2405mr15281188plr.117.1652079310804; Sun, 08 May 2022 23:55:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652079310; cv=none; d=google.com; s=arc-20160816; b=x3xssSvuGPmJnIV+1Tke89dL1cZ+YsY+OxNbCSU1wTkTPV8FpuPPQtblLPlCNR878N pgqrHJAU/ziSO5JCUoWQsT/ChxZInR7Rg1D8bpVW+zl3L6cLSWSts+lkpfeL1p+njcPu ZFGENYGTx/gh1rWOa+tBO4Fxz4oLy0oR+ooPzzBPBWfPda7lgmkPQn/3Bsu3iW62wm/a AXU9jWKDLSImU/HAI47J0h6Q0aetYWZvbmFU12kPp1uszsQT6VyYSmjLTc71mr7Myd0p Ms6MrhcEIMJ946Gaf1JQZD9EVpQQJL65XmaqUrhuSz9SoOJAX5GYOSwdyXp+jm/tVFe3 NW+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6k9bKJA41frCR0pmOk9SA+9AKNxBSbRS1tpgQTa/e4I=; b=EkZ4QfJ95/uOz0ZP0Fyz3o/QdKTfPRG+rzlw0rbwLxHe0I/HWXFpan4y54R9XMysMD gODA/EWJdcDD6nlYO0GFnwev5Fw85LGltt0lxZGUhchOSDsTGDetufHfA0aSx9eHc5Ta tnOT9fD+Th1gfC9vfORyCAvFkds6yXQ9CPO0NjyZK+EvdIGubtmJH9vTsfdJuvs//4Gl OvP3RA5LtAB9ytlMPF7WIJv2AwNM7qb784CytjnLEUIGgao2PuLl+tbx38cQrpQZIIUM 1evK67315Biur8f65jYbXho3ce1Tsy90oKIR8bHFVh0g0kRL4WEtFH5Eba2LmVSmDGsT MK4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=7WVkQD9l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id iq11-20020a17090afb4b00b001d59d8d5696si11369139pjb.153.2022.05.08.23.55.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 23:55:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=7WVkQD9l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1A6D018385; Sun, 8 May 2022 23:50:39 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232282AbiEHTJf (ORCPT + 99 others); Sun, 8 May 2022 15:09:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236061AbiEHTD6 (ORCPT ); Sun, 8 May 2022 15:03:58 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C1E7BE10 for ; Sun, 8 May 2022 12:00:06 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id c190-20020a1c35c7000000b0038e37907b5bso9671489wma.0 for ; Sun, 08 May 2022 12:00:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6k9bKJA41frCR0pmOk9SA+9AKNxBSbRS1tpgQTa/e4I=; b=7WVkQD9lHCDxKB1tD6Un3hFpvX4/cOE8DPsLwSHDOQ7kt6Z2YTDF0rFp5+4bJAtC7w DaON87xrGfLz4D/4CKcyMsiq3DL8xisQUHwdd09W40h4D5DFOHh0rizcHFtmOgZsV9c5 cfnnG8lF+9r5eCrmwylUG43+huwETysAbw8WbNcl9x47hFGjbYfxAH1lyAvKSXHW3nSz BtI+lB1SU7EoSr+Uq8LSpCA6qZJ0RBGa2p2T5UufQsicJVKF7cfYMwInywjhKRxm4hiD +S2H5vkgIqpdY2JT4C3gsmXhX0XQLWVK2x3qDFWOhQ10NUuVJwxQ/sQifbz8Qly+MDjy AvhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6k9bKJA41frCR0pmOk9SA+9AKNxBSbRS1tpgQTa/e4I=; b=61YyIQg0RoJHfiwzi9loAm886Ea/ZUks9QCXm7LuwM3m+jHBfWHtSx99uRQPijecCy vMDvtyeHhSAVul4FqVFhkjNifa56F7rk9GGc5jyH7esdN5ItdTZnGqKDEaTfyqrKfHZ/ 0SO9haBJIF7Lo3LJIg2PM8wAJQANquom6mOMtV3W/OcQNJYT9+6hE+8Myy2oKm3o2d9n SiVp2l7EsXqF2bf9jrLqFCCEJSedG0H7Gjrd8crpLTlVqWRqt/E2LIGh6ZvSdOQZjrf6 mGItAwi4cL6whpMskWI9YgZ+z1wfwjqOYbPjYpd9yKzKrL/0l+3G0nFJ3Q0tDhhOyGyH NepA== X-Gm-Message-State: AOAM531MfwiyqdRLInq022HCwQ6EfJU8bAjgRjGIy77ZP/SlbkLNJy7A xHbcycJYOlAI4hwW3waBRtotHw== X-Received: by 2002:a1c:f30b:0:b0:380:e444:86b9 with SMTP id q11-20020a1cf30b000000b00380e44486b9mr12915348wmq.81.1652036404843; Sun, 08 May 2022 12:00:04 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id n16-20020a05600c3b9000b00394699f803dsm10552348wms.46.2022.05.08.12.00.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 May 2022 12:00:04 -0700 (PDT) From: Corentin Labbe To: heiko@sntech.de, ardb@kernel.org, herbert@gondor.apana.org.au, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Corentin Labbe Subject: [PATCH v7 01/33] crypto: rockchip: use dev_err for error message about interrupt Date: Sun, 8 May 2022 18:59:25 +0000 Message-Id: <20220508185957.3629088-2-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220508185957.3629088-1-clabbe@baylibre.com> References: <20220508185957.3629088-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Interrupt is mandatory so the message should be printed as error. Signed-off-by: Corentin Labbe --- drivers/crypto/rockchip/rk3288_crypto.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockchip/rk3288_crypto.c index 35d73061d156..45cc5f766788 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -371,8 +371,7 @@ static int rk_crypto_probe(struct platform_device *pdev) crypto_info->irq = platform_get_irq(pdev, 0); if (crypto_info->irq < 0) { - dev_warn(crypto_info->dev, - "control Interrupt is not available.\n"); + dev_err(&pdev->dev, "control Interrupt is not available.\n"); err = crypto_info->irq; goto err_crypto; } -- 2.35.1