Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <c13621d1-8c33-2979-b455-2e1f4e4bc5c8@somainline.org>
Date:   Sat, 7 May 2022 19:35:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] arm64: dts: qcom: msm8998: Make regulator voltages
 multiple of step-size
Content-Language: en-US
To:     Marijn Suijten <marijn.suijten@somainline.org>,
        phone-devel@vger.kernel.org
Cc:     ~postmarketos/upstreaming@lists.sr.ht,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@somainline.org>,
        Martin Botka <martin.botka@somainline.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Markuss Broks <markuss.broks@gmail.com>
References: <20220507153627.1478268-1-marijn.suijten@somainline.org>
From:   Konrad Dybcio <konrad.dybcio@somainline.org>
In-Reply-To: <20220507153627.1478268-1-marijn.suijten@somainline.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7.05.2022 17:36, Marijn Suijten wrote:
> These voltages are not a multiple of the given step-size 8000 (with base
> voltage 1664000) in pm8998_pldo, resulting in PLDO regulators l18 and
> l22 failing to validate and in turn not probing the rpm-pm8998-regulator
> driver:
> 
>     l18: unsupportable voltage constraints 2856000-2848000uV
>     qcom_rpm_smd_regulator rpm-glink:rpm-requests:pm8998-regulators: l18: devm_regulator_register() failed, ret=-22
> 
> Round the voltages down for the sake of erring on the safe side, leaving
> a comment in place to document this discrepancy wrt downstream sources.
> 
> Fixes: 390883af89d2 ("arm64: dts: qcom: msm8998: Introduce support for Sony Yoshino platform")
> Reported-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
Also:
Reported-by: Markuss Broks <markuss.broks@gmail.com>

Konrad


>  .../dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts    | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts b/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts
> index 4a1f98a21031..c21333aa73c2 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino-poplar.dts
> @@ -26,11 +26,13 @@ &lab {
>  };
>  
>  &vreg_l18a_2p85 {
> -	regulator-min-microvolt = <2850000>;
> -	regulator-max-microvolt = <2850000>;
> +	/* Note: Round-down from 2850000 to be a multiple of PLDO step-size 8000 */
> +	regulator-min-microvolt = <2848000>;
> +	regulator-max-microvolt = <2848000>;
>  };
>  
>  &vreg_l22a_2p85 {
> -	regulator-min-microvolt = <2700000>;
> -	regulator-max-microvolt = <2700000>;
> +	/* Note: Round-down from 2700000 to be a multiple of PLDO step-size 8000 */
> +	regulator-min-microvolt = <2696000>;
> +	regulator-max-microvolt = <2696000>;
>  };