Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4757196iob; Mon, 9 May 2022 00:26:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJypALkg+7dzxzoGwXbWMHdcX5teiJbF7r0kJPv+Qbh/1fQjEGX17xru4U6sJlHC0e1cHhht X-Received: by 2002:a63:7151:0:b0:3c6:25af:2391 with SMTP id b17-20020a637151000000b003c625af2391mr11966577pgn.382.1652081166087; Mon, 09 May 2022 00:26:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652081166; cv=none; d=google.com; s=arc-20160816; b=ZUt1gTc3HaKQ+WqvBwwbr3J9PUKRCwYIW0KDhpRr+dAlMfaz7GZHHajyIG2GU1UEO1 D9q5Y6AeHiCS3glAgVrUJYMm7E+nXDwQ/No8rL0m/P3NxtqJXHa7WAcYQJQI4ZAlumXh V2daTry7o79mr50HlLNgRdR68UsRKZ4LmAmEf+IcZ6gZTY1ExDaC+tqQC8kpOfCwwQyN Nhc50cXcMAcUlJ3DB8wfmyTegei9t/HWSetCxGnGlVDmABy6rGJeK/U8yzmqQhL7WHWz AsW8nntCT/3JGxeFY1DQj7dT98Xr2uQpMBXgGpXi1fH8xPLeAd0qh0qf5/wTxnNybwa/ /ibw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7WUXEgU/84WHccrGnOwEi4/FdcnCIAXFZ+ZFBtK+98M=; b=bcslX8fBkv5DU69ccLdVvJwfw0sILYGdKxZJCkwAPQy2iYDvhcQTkoFEipbdoaJ7Tp E1n//ccNET8iPjt/CnWbvel5nHpGeVjHt+PXDb9vlkJVxptIDplWyxo20tEqVd/hGip1 AxwPEP5O7A39aYOrVhwotQYXKXKKb6p/DNATHRjeLkQH2H4FReV8IG5/bGGHCFQQYuSd kO8gQ1NS2ryBMu72TtJkr2PKUdo1ZufwwS5u03pz+Uz+GmWbONyLOqbfqb4f9pXT/Ppk DsIUC8l8HykZXOLJP6jndE644/fCqdIHgAojlFI0ZZ/aKGNgKg0Zc5QwRYaxBwh+DVjY 0yxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TfI2kci8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id l9-20020a170902f68900b00153b2d165cesi11866034plg.470.2022.05.09.00.26.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 00:26:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TfI2kci8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 624E91AD5AC; Mon, 9 May 2022 00:23:47 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357781AbiEDRdM (ORCPT + 99 others); Wed, 4 May 2022 13:33:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356954AbiEDRJv (ORCPT ); Wed, 4 May 2022 13:09:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32317473AE; Wed, 4 May 2022 09:56:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 12E39617A6; Wed, 4 May 2022 16:56:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 605A4C385AA; Wed, 4 May 2022 16:56:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1651683401; bh=hdoWo2RhsqsWgZIRmPbb7DxC3aFuG2ViZhr8JO9X6t8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TfI2kci8w3n/CelDbJEuhjXDVi7WZVLr2gWrl6ZzJ6twWj7zbmMuASsQytOzgBk6o StMfh58fCKuyH3A1O0a6S/jUCwnOX+o93IW92k13sVTY38iKubzqIcsXJbMh/J4UVD fuSBuf4FvA2qrjMcDtSs5xT5dWvP5FJn0FDR5mrk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , =?UTF-8?q?Nuno=20S=C3=A1?= , Jonathan Cameron , Sasha Levin Subject: [PATCH 5.17 072/225] iio:dac:ad3552r: Fix an IS_ERR() vs NULL check Date: Wed, 4 May 2022 18:45:10 +0200 Message-Id: <20220504153117.893992445@linuxfoundation.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220504153110.096069935@linuxfoundation.org> References: <20220504153110.096069935@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit de3b9fe9609a05d3c354c6718ca657962d11d9fe ] The fwnode_get_named_child_node() function does not return error pointers. It returns NULL. Update the check accordingly. Fixes: 8f2b54824b28 ("drivers:iio:dac: Add AD3552R driver support") Signed-off-by: Dan Carpenter Reviewed-by: Nuno Sá Link: https://lore.kernel.org/r/20220404114244.GA19201@kili Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/dac/ad3552r.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/dac/ad3552r.c b/drivers/iio/dac/ad3552r.c index e0a93b27e0e8..d5ea1a1be122 100644 --- a/drivers/iio/dac/ad3552r.c +++ b/drivers/iio/dac/ad3552r.c @@ -809,10 +809,10 @@ static int ad3552r_configure_custom_gain(struct ad3552r_desc *dac, gain_child = fwnode_get_named_child_node(child, "custom-output-range-config"); - if (IS_ERR(gain_child)) { + if (!gain_child) { dev_err(dev, "mandatory custom-output-range-config property missing\n"); - return PTR_ERR(gain_child); + return -EINVAL; } dac->ch_data[ch].range_override = 1; -- 2.35.1