Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Yihao Han <hanyihao@vivo.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com, Yihao Han <hanyihao@vivo.com>
Subject: [PATCH] i2c: s3c2410: change return type of 'i2c_s3c_irq_nextbyte' from 'int' to 'void'
Date:   Fri,  6 May 2022 04:34:15 -0700
Message-Id: <20220506113415.10462-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fjIq6Fbx18ciJxjtdo9Pofq16AFSGJmuHiKYHKOLWhPbxZPsSFUEgX8bEfiu?=
 =?us-ascii?Q?Oe/v7j7x5VGU3dBVCmitDPTFyjRLK0MMfiTlmbMeHI2ihIDKrpW9vQLMVzqv?=
 =?us-ascii?Q?5wDug1Y8/zEcts1F2JQHr/QJq3qb9iu5rbyV5t8T4r+EYIvQMpaIi89A72U8?=
 =?us-ascii?Q?3EqSR7lCSP+Kj4+7o0MX3Mo3or6JK+S4TfOjIrcgKrT5RkC+FEZItIrYxz6r?=
 =?us-ascii?Q?8v1+sjhq+Ht9ciLN2G8Jj7Sep2HGa1fVmiriqf+ZLd5ET/7YEqKMGIjSgOOx?=
 =?us-ascii?Q?vYlf8RmyAg+09oYZ13KIrjP08+cZx1NlALfd3Hkr4BRvedebBjQLeiymNFmQ?=
 =?us-ascii?Q?KgjgcujpI5EO9BM7D2w/NOpyBDrszVKQr+rQNcR0MKl4RZZEogEh7ERe+BhT?=
 =?us-ascii?Q?KylSNNKabqOH2QPclHmx3nWyXewRqnTNy7U+yYKki8kibIC/s49Mm6kBON2I?=
 =?us-ascii?Q?FXV0Z96p9oJaVHzRNRbTukYBJDP1r6wAORp5Kd/UXqyTDDTHr9s9aZbQ9YpO?=
 =?us-ascii?Q?+YMiXr5/1mmB9dQxvXgyfyBLTSvAA8cQyKo02G7530hbZ77unqX0m0DNicLZ?=
 =?us-ascii?Q?i9hqIOcL8ecsiv4mDJoRR3R9c+zUx6JGY9RDDNp+CSP9TGBGfV4z6DuVJVkW?=
 =?us-ascii?Q?T2wFNYMytXVTXoa7f9bwft6FZOB/q2B4KivzlWqKsvqzv5rYCJBRotHtj2BX?=
 =?us-ascii?Q?oh79rG7tk3ggMdPSMubPnWJWgMFptXJ/14bjY+SfqmvGdFpX2pVDFTZMwNdL?=
 =?us-ascii?Q?GdIEYW6EqJibikrm0Yg6gmbN+HkMGWnS1R1lC3pVpILRA3K5pBQHRZvkR4Gz?=
 =?us-ascii?Q?cOVO/4xCubtGOvJ3kS1U/RqLMKp0TMqyPbg2/Nl4CAT1fatquN4eXNQjt5g1?=
 =?us-ascii?Q?0JBzhNGwA02ZkUBX4q6hFTjDj/4+SZHRd6kiZQOaQz8MLzBrgMgc/Y5HNKld?=
 =?us-ascii?Q?fy8/6WVLIhH7/pL48vDmcHdyDXjd1JQxXqOXG1oN8RoADawfLgRssNjP+sby?=
 =?us-ascii?Q?M946PRQhAbpSHK1MiAi99scCWHXqAAQO5/HplmyYFayqPj1bG3diueTjtBqX?=
 =?us-ascii?Q?AlWQu7y49PBJkkgKI3AusAjZ1gtqAzXgGqpjw3+asWtvqmiuMZMbPEZTtWB9?=
 =?us-ascii?Q?TWegIrJhhOwiuukuNO1tWV3Gz/NTX9LQ4AIpVKvupuCplFfZNbhwicIbrqwh?=
 =?us-ascii?Q?hw+zVhFUwZOEo5wnw6esq1+Ayeq4Uja63sNT2mOkc0Sf1cuy0e0C87PHnouY?=
 =?us-ascii?Q?Bk2mDFRhILscWbYsv7J+iwaySC8zJYmBeDXmmrd6wPs+ltVzyjox61pXGVx3?=
 =?us-ascii?Q?NoTht1Nq3yaRqI7AXOcKXCFJxuOYWIFffjRKs85es2spHOAPpJszkUfHA0GK?=
 =?us-ascii?Q?SRewg0htmCBRWqmzEX5HpvOs03o1TyUunmJlFmBPeI8Kx1DdMy2BTrFKOYJ7?=
 =?us-ascii?Q?fQE8pw84b6TkJlJ4vhxizdHFEJmObSGZL1Gg4XC9jHuikq42dyCe2qmAVd7/?=
 =?us-ascii?Q?wx1ReWGpU2K/ijY/PdoRRR6xBhbuJ0lr/H832oSyD2rHaMAMkbo00S4y13rQ?=
 =?us-ascii?Q?Y+3Aaw3p68eVNFUsrM4cSzWBLaA2l+lyNwgk/zaWZl8T5gK80ciN6wKFXnp/?=
 =?us-ascii?Q?rHBOFXrc+J6w4fdXNaeZhNvkNiWc7wpxuhu0V+dCqh4rsUUkF6HzHYKAZYeu?=
 =?us-ascii?Q?boUg93nOQLbLeIaJJiJkd59dThuRbQ96JFXbFPdHMSLl6voZvG+EQJ89k/mv?=
 =?us-ascii?Q?K9wQ+TqM3g=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a8d6e50-4536-413e-bda4-08da2f5461a8
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 11:34:29.1677
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MiuPGafa6Ik5pIuJFp88WF7Xg/jEKA4q6/p+KKfmqgA6IQ+tagl8JE9sZznb8woUEWzNGhp/NiOSNH1eP8FBag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR06MB2336
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since ret is a redundant variable, and none of the callers check
for return, so remove ret variable and change return type of 
'i2c_s3c_irq_nextbyte' from 'int' to 'void'

Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/i2c/busses/i2c-s3c2410.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index b49a1b170bb2..75ddf7ffb028 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -381,17 +381,15 @@ static inline int is_msgend(struct s3c24xx_i2c *i2c)
 /*
  * process an interrupt and work out what to do
  */
-static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
+static void i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
 {
 	unsigned long tmp;
 	unsigned char byte;
-	int ret = 0;
 
 	switch (i2c->state) {
 
 	case STATE_IDLE:
 		dev_err(i2c->dev, "%s: called in STATE_IDLE\n", __func__);
-		goto out;
 
 	case STATE_STOP:
 		dev_err(i2c->dev, "%s: called in STATE_STOP\n", __func__);
@@ -547,8 +545,6 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
 	tmp = readl(i2c->regs + S3C2410_IICCON);
 	tmp &= ~S3C2410_IICCON_IRQPEND;
 	writel(tmp, i2c->regs + S3C2410_IICCON);
- out:
-	return ret;
 }
 
 /*
-- 
2.17.1