Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 4 May 2022 19:25:07 +0200
From:   Pavel Machek <pavel@ucw.cz>
To:     Aparna M <a-m1@ti.com>, nm@ti.com, vigneshr@ti.com,
        kristo@kernel.org, robh+dt@kernel.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, praneeth@ti.com,
        grygorii.strashko@ti.com, nikhil.nd@ti.com,
        linux-leds@vger.kernel.org
Subject: Re: [PATCH RESEND] arm64: dts: ti: k3-am642-sk: Add DT entry for
 onboard LEDs
Message-ID: <20220504172507.GH1623@bug>
References: <20220420072952.3509-1-a-m1@ti.com>
 <YmYuV3lhncn6RWGQ@ada-deb-carambola.ifak-system.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YmYuV3lhncn6RWGQ@ada-deb-carambola.ifak-system.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk

Hi!

> > +		led-7 {
> > +			color = <LED_COLOR_ID_AMBER>;
> > +			function = LED_FUNCTION_INDICATOR;
> > +			function-enumerator = <8>;
> > +			linux,default-trigger = "heartbeat";
> > +			gpios = <&exp2 7 GPIO_ACTIVE_HIGH>;
> > +		};
> 
> This might also be LED_FUNCTION_HEARTBEAT, but it's probably up to
> author's personal preferences?

You are right that having 8 leds marked as indicator is not too useful.

> I added the linux-leds list to Cc.

Thank you!
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html