Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Rolf Eike Beer <eike-kernel@sf-tec.de>
To:     linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
        netdev@vger.kernel.org, Yang Yingliang <yangyingliang@huawei.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org
Subject: Re: [PATCH] ethernet: tulip: fix missing pci_disable_device() on error in tulip_init_one()
Date:   Fri, 06 May 2022 12:11:56 +0200
Message-ID: <5564948.DvuYhMxLoT@eto.sf-tec.de>
In-Reply-To: <20220506094250.3630615-1-yangyingliang@huawei.com>
References: <20220506094250.3630615-1-yangyingliang@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart5819534.lOV4Wx5bFT"; micalg="pgp-sha1"; protocol="application/pgp-signature"
Precedence: bulk

--nextPart5819534.lOV4Wx5bFT
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

Am Freitag, 6. Mai 2022, 11:42:50 CEST schrieb Yang Yingliang:
> Fix the missing pci_disable_device() before return
> from tulip_init_one() in the error handling case.

I would suggest removing the pci_disable_device() from tulip_remove_one() 
instead and using pcim_enable_device(), i.e. devres, and let the driver core 
handle all these things. Of course more of the used functions could be 
converted them, e.g. using devm_alloc_etherdev() and so on.

Eike
--nextPart5819534.lOV4Wx5bFT
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQSaYVDeqwKa3fTXNeNcpIk+abn8TgUCYnT0bAAKCRBcpIk+abn8
TpRJAKCSFE72ZhtgBsEs3gZhAmNmCY5v1ACgkwsyEadMyOecFRXMtHurVSrfEz0=
=LQcA
-----END PGP SIGNATURE-----

--nextPart5819534.lOV4Wx5bFT--