Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4780916iob; Mon, 9 May 2022 01:10:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/woD4UvCUeQ89z3FiClx3eDApxjyLaOor4usTRtRCItg+O9ZoRr19Q05nQaBbk/lcCtZ3 X-Received: by 2002:a05:6a00:174a:b0:50d:44ca:4b with SMTP id j10-20020a056a00174a00b0050d44ca004bmr15060422pfc.0.1652083850747; Mon, 09 May 2022 01:10:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652083850; cv=none; d=google.com; s=arc-20160816; b=iuRNx+ohoILxhXIVHar4sy/3EOL3F+Nx/JQeNb+WALJRx6LC6PZ/V+yqpEvS/uN3Kn 8PPce8G3DneI1jAWCk/tBh62NTOS2ZUhsgv8frHTrdQkzKENMOGDmbbdzSCjMrdmrkSs R9F3TaTy+vqYBunRapY30SCA2TPIBlizS/JFeTky/3bznmBk058DsfNqUGdVLK7oAN2J ahltj0dHd66sYrebZIVOH56AjXshauonlL1NQxh8Z6ghG6C2ZSE8PSLyz7xO1s62Exi1 EGzb4FNDnLrDTNbGtroNTwomA7+BjgeVx47RAFSDwIdVUH09i5dwPCjliQhhiSgE+6RS SHTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Jh0E5X0iydVvkz7XqNrDyD+rBDluF5khygQc2zdVasw=; b=RFzLc0yEiCCbpNbVg+KD+/g0yGrUfcEGXmh89fvaYyi3ahrs9KyrnffZX28nrNkzVx k0hf0C1+X82aQ+oqnAD24Hzo7R/yDzX0Nc7MUS5LOjzfuo8v5VN9PQzWHFLrr/incT5L UcZ/CQqcgjjkD3d6/Xxh7KWVLPFLXhWmV09RrZtNo4Dg0kZMT2HqFMgm5CagCZfJU9D8 6Kc8w8DtgiWzi6pjT5GEwasuNe4YdhaBTpV1dwY4BY3tTDOPAVUAHLTct6OhD1xs1f+Z gLoTnrjojyFiYmf1K5rG3lyVmt5FTnhd9MNQVK6HSuWFOZTw/WGQ2FnBP7MFWcGbCY4r V3Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=EvCZKuuh; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id b127-20020a636785000000b003aa6731b2c4si13784883pgc.581.2022.05.09.01.10.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 01:10:50 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=EvCZKuuh; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 06BC26473F; Mon, 9 May 2022 01:00:58 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382154AbiEDXrc (ORCPT + 99 others); Wed, 4 May 2022 19:47:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380372AbiEDX3U (ORCPT ); Wed, 4 May 2022 19:29:20 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46E774F9F8; Wed, 4 May 2022 16:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Jh0E5X0iydVvkz7XqNrDyD+rBDluF5khygQc2zdVasw=; b=EvCZKuuhsTlJaKl2Vmdl8pM0xU Xm6OH+num05/am++VP2ysYeco2LkZanxFlNdXyN9Sqp2W4gkHhZrozisTu/ECfE6teJ30HRZCZVJL ILLlqmAIwrUEr0nudRKMSvuxUB3ZC65hJe6C4CGuBWnQqQgpqmpb6aYL63cx/AnLB024=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nmON9-001HHB-RH; Thu, 05 May 2022 01:25:31 +0200 Date: Thu, 5 May 2022 01:25:31 +0200 From: Andrew Lunn To: Ansuel Smith Cc: Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Pavel Machek , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [RFC PATCH v6 03/11] leds: trigger: netdev: drop NETDEV_LED_MODE_LINKUP from mode Message-ID: References: <20220503151633.18760-1-ansuelsmth@gmail.com> <20220503151633.18760-4-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220503151633.18760-4-ansuelsmth@gmail.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 03, 2022 at 05:16:25PM +0200, Ansuel Smith wrote: > Drop NETDEV_LED_MODE_LINKUP from mode list and convert to a simple bool > that will be true or false based on the carrier link. No functional > change intended. What is missing from the commit message is an explanation why? Andrew