Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 5 May 2022 09:52:15 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Alistair Francis <alistair@alistair23.me>
Cc:     linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
        s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org,
        alistair23@gmail.com
Subject: Re: [PATCH] ARM: imx_v6_v7_defconfig: Enable RDNIS by default
Message-ID: <20220505015215.GG14615@dragon>
References: <20220420122728.510802-1-alistair@alistair23.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220420122728.510802-1-alistair@alistair23.me>
Precedence: bulk

On Wed, Apr 20, 2022 at 10:27:28PM +1000, Alistair Francis wrote:
> Supporting Ethernet over USB is very useful for debugging. This allows
> debugging systems where the other networking (WiFi or Ethernet) doesn't come
> up, while still allowing SSH access.
> 
> This is extreamly useful on the reMarkable 2 as it doesn't have UART RX
> or a physical ethernet port. If WiFi doesn't work this is the next best
> method to access the device.

This should be probably left to users to configure per their needs.  And
configfs might be the best default option.

Shawn

> 
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> ---
>  arch/arm/configs/imx_v6_v7_defconfig | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> index f7498df08dfe..f9ddaba1aad2 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -349,12 +349,16 @@ CONFIG_USB_CONFIGFS_F_UVC=y
>  CONFIG_USB_CONFIGFS_F_PRINTER=y
>  CONFIG_USB_ZERO=m
>  CONFIG_USB_AUDIO=m
> -CONFIG_USB_ETH=m
> +CONFIG_USB_ETH=y
>  CONFIG_USB_G_NCM=m
> -CONFIG_USB_GADGETFS=m
> -CONFIG_USB_FUNCTIONFS=m
> +CONFIG_USB_GADGETFS=y
> +CONFIG_USB_FUNCTIONFS=y
> +CONFIG_USB_FUNCTIONFS_ETH=y
> +CONFIG_USB_FUNCTIONFS_RNDIS=y
> +CONFIG_USB_FUNCTIONFS_GENERIC=y
>  CONFIG_USB_MASS_STORAGE=m
>  CONFIG_USB_G_SERIAL=m
> +CONFIG_USB_CDC_COMPOSITE=y
>  CONFIG_MMC=y
>  CONFIG_MMC_SDHCI=y
>  CONFIG_MMC_SDHCI_PLTFM=y
> -- 
> 2.35.1
>