Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <6e5ae4c2-abe2-048a-21b5-783f1c77bb08@nvidia.com>
Date:   Fri, 6 May 2022 11:25:29 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 1/2] hte: fix off by one in hte_push_ts_ns()
Content-Language: en-US
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Thierry Reding <treding@nvidia.com>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
References: <YnU2gHe+QZOAuNyV@kili>
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <YnU2gHe+QZOAuNyV@kili>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDRYVXEwUWVvQ1BUZE9iZVdCaXhYYXJOdUlMTStGRWtoMW91TkZuclZUVGZr?=
 =?utf-8?B?eUxsU0xWOTl1MEV1cWE1VS94WGNVYmlKbFdUZGhuZkl2WDdPM3ZSak40bkFO?=
 =?utf-8?B?UUwycDh2cTFrdFZOWE91anBGT2o0bjVnY1BGM0N1cjFPeEhYOUdBdVV3aTY5?=
 =?utf-8?B?d0trNVFsN3NDazVXLy82M29XMzQ1Z3hybUhneTJiRXdPSGVCLzlSV2NXSFMv?=
 =?utf-8?B?RmY1Yk0wbDhuUFE4YzVHN3l5eTBrdWFHcXpHTnByalh6QnRZSEJFV0JkbTVL?=
 =?utf-8?B?ODl6SkM0S2xVdnFoQXpVNExHQjMzNDNreHVqVzRSWDRSTkVoeFZ2bU8zS0NH?=
 =?utf-8?B?Y1c2dHhMVEU3MloxbVlvY0l0aFpVdkNZMmREOGpuOTR6bW1XMHUxRlVja1hG?=
 =?utf-8?B?WFZpR3Y0d2ZBeHU0TExKRmk2Y0ZQTHJiNW9laUtqNWlLUjgzYWs3K210TXZF?=
 =?utf-8?B?OGI5N2xhZW5aeVV1M2wvMWhEcDhCb3lPTERDbms3YXZCT0FWNk05di9ITUJO?=
 =?utf-8?B?VDMrdEs0RFpQTkJOaUtybGpBUUxXVEl1b2diUmlabTRrVFNHVStoQnVXbHhi?=
 =?utf-8?B?M282eEtEaVhjWVlrRnlKN2kzUU5xRU1JZTdScVA0UXZvTmRBcUNLRTIwMy9t?=
 =?utf-8?B?Y0FldVhWY0hodmR0dWx1OVdudEFhK2d5TUJyNjYwWkFiOExBeWpiVUVDTTdE?=
 =?utf-8?B?bGpjRjNoREtlNzR6NFFNa3hMUElSeWJocWVyclJUNW1PcGpBVEwwYTlQSWda?=
 =?utf-8?B?UWd5azBVeGRDYW03T0x3bHlnN0ZoVnFuUUFVLzBQcjlKZTBMdWRQajBpWGRm?=
 =?utf-8?B?MG1VVGMxbTc4K3kzNWFMdXlUcEs3Z250OTF1VmZXMmgrM0xLdjFvRDVwV2xZ?=
 =?utf-8?B?K2V4cDJXLy8xS1RYdzBDMXdDeUNmcWVTdFhDeGRzQWxyRFJ3VmdUalRFN2Np?=
 =?utf-8?B?OTg5ZU5PRjE2eENudUorbjl4ajQzRDVKc3h5SThzNUpLaUw0MVN6UVErVVB3?=
 =?utf-8?B?dVdmZjZKSE5uRGNHbTlsK0dFSGk1aWR3NDQrS1Zzb0o2ZE1aNVNhTjVEQk1m?=
 =?utf-8?B?Q3Fra0lYSnNxTFA2dWl2Q0thei9jaVpxZnAxbUdmTDJEL2h4ZVFNM1liYk5r?=
 =?utf-8?B?UjBBay9YaGF3Y3BvZG9ZbWlkYk9RaWxyVkhvSTR5Q3NHNnM3a2kzc1k0OXpH?=
 =?utf-8?B?K2FNdTJvL0NVN3h3cE1rdEZnMHI5OVhRdjZwRUhqSTFpMmJGbStSaGxDTWQv?=
 =?utf-8?B?K2dDdWJ3anF0SWNzdUpzVmdSbUg3bEJxTzdNalNiZnFld3RNakxKSWVhQW52?=
 =?utf-8?B?YnFWUFBRVFdUeTdrUm5Ta2V1NUhBd0VIMmJuR3o4U25PZk1SblhzUFFmWG1u?=
 =?utf-8?B?V21ZanRYRXBaN0RqRW9tZ1RCZWFWdytHTUdLM3NGQUNRZTI3RFkwQ3QvM2Rk?=
 =?utf-8?B?RzZRbUhZd2REUHhPM2pXdXhzQjFIRkl1ZTR2aEQ3RldiVThVTi81a1lkQjFQ?=
 =?utf-8?B?SS9xU3hzb0dnYlB1aEkySFlUd3BhVEpqK3kyMC95YjZXUjFKSjhLNU8yTWhV?=
 =?utf-8?B?WnpOMnBka2oybTVmaW9Uck9Hc0ZaSTRaK2FZVTNxRG96N2xLQXBkYlVaUnFp?=
 =?utf-8?B?a3ZBSW04dGVoVVlzSW0rcTdWZEFheEJqWnZXcWVRb2tlVVhCTHEvWVpWam1q?=
 =?utf-8?B?dUV1SVF1eTN5bzAzM2ZROS9XS2FDemVSd2g5UjBURXlHQU5QV3J5ZmVxK2hM?=
 =?utf-8?B?MGRKRXZ4MlhsRFhPZzJ0Zk43NHVqWGhxOXpQV3U3U1dKVGV4am9TYzZXQmkx?=
 =?utf-8?B?OGNLU0ppcC93ZUlZbzBFR3h0R1E1dXRNUEl2cEQyQm91MWpRTnJpaDdvZ3ZQ?=
 =?utf-8?B?ZCtTdjdHY0V3MEthT2c2QjFubGZTTkFlRDB5b3JGQnNtMWZpMm9VTVZIZWph?=
 =?utf-8?B?OGp2bCtQNnppbkdoTnd6OStLY0tRRDlsM0dNUkxzUUMyK0FsQS9FWC9XWlFU?=
 =?utf-8?B?TVlPNGNaaWVmY2pQT29ndWFmZ1M2aUVlVWNFcm9uOTJURDZhSG9iQVo1VGc4?=
 =?utf-8?B?Ni85a1ZmL1JwSkF1ejU5dWN1Nm9FYWw2YUpPSEpKV2RaTlJXVmt2L3BwQ3Bj?=
 =?utf-8?B?S1pGZmtXTXE0UHh1d0NTTTRiN3dVT2lxWi9NY1dzZXBHL1ZIdXNPUUJPT3dW?=
 =?utf-8?B?L2Nna1dVYmhuVG1NTlBRNXR0S0hxWkhRVEptRWpNcWd3RERCblJMYno3R3RP?=
 =?utf-8?B?QkJXU1dKTUcxSE9xcjYwcjJQYllNNWszc1JLazlpN1RicWQyM0dESFB3T0Qw?=
 =?utf-8?B?UGo5MjRiMStVMnZneVl5MEtEVHVrS0FmOU9LTy9sajNrbllCRXlvZz09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6bbad61-b4ff-4318-386d-08da2f8dcc16
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4116.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 18:25:28.8811
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mrRQoljztsT6pG8Zduc7i76nfsZLXYADQHbkwjyl/1nUBIGGtVbLZHCno1c9KYXv0vT7dT/KpaJa2TppshQ2yg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4053
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

good catch. Thanks.

Reviewed-by: Dipen Patel

Acked-by: Dipen Patel

On 5/6/22 7:53 AM, Dan Carpenter wrote:
> The &chip->gdev->ei[] array has chip->nlines elements so this >
> comparison needs to be >= to prevent an out of bounds access. The
> gdev->ei[] array is allocated in hte_register_chip().
>
> Fixes: 31ab09b42188 ("drivers: Add hardware timestamp engine (HTE) subsystem")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/hte/hte.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hte/hte.c b/drivers/hte/hte.c
> index 891b98ad609e..a14c5bf290ff 100644
> --- a/drivers/hte/hte.c
> +++ b/drivers/hte/hte.c
> @@ -811,7 +811,7 @@ int hte_push_ts_ns(const struct hte_chip *chip, u32 xlated_id,
>  	if (!chip || !data || !chip->gdev)
>  		return -EINVAL;
>  
> -	if (xlated_id > chip->nlines)
> +	if (xlated_id >= chip->nlines)
>  		return -EINVAL;
>  
>  	ei = &chip->gdev->ei[xlated_id];