Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Thu, 5 May 2022 10:29:56 +0200
From:   Pavel Machek <pavel@ucw.cz>
To:     Manuel =?iso-8859-1?Q?Sch=F6nlaub?= <manuel.schoenlaub@gmail.com>
Cc:     Bastien Nocera <hadess@hadess.net>,
        Filipe =?iso-8859-1?Q?La=EDns?= <lains@riseup.net>,
        jikos@kernel.org, benjamin.tissoires@redhat.com,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: logitech-hidpp: support Color LED feature (8071).
Message-ID: <20220505082956.GB14065@duo.ucw.cz>
References: <Yifr4etBFPu1a2Ct@hermes>
 <275245e8048fa124055d9ff3d10ce6562294483a.camel@riseup.net>
 <ce3adf7013ba01aad54fb65bf9c657dd9d0b7d23.camel@hadess.net>
 <YjvlQrvRS+ZKNbZ5@hermes>
 <5b842bd4f8d17e5ecb8e7972637dbe7ad50060ac.camel@hadess.net>
 <YjyX2q1IXeJQ2LGG@hermes>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="ZoaI/ZTpAVc4A5k6"
Content-Disposition: inline
In-Reply-To: <YjyX2q1IXeJQ2LGG@hermes>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--ZoaI/ZTpAVc4A5k6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> Yeah the SetBrightness in systemd / logind should work out of box.
>=20
> Though I just noticed something: For this to be useful, the default
> multi_intensity for each component of the multicolor LED in the kernel sh=
ould be set to
> max_brightness, effectively producing white (on RGB LEDs at least).

Agreed we should have multi_intensity set to something nonzero. Note
that max on all channels may not result in white.

> Now there are three solutions:
>=20
> 1) Naming the Logitech LEDs <device>:rgb:kbd_backlight-N even on mice
> and at some point send a patch to systemd adapting the udev rules to
> care for devices with nuemrical suffixes.
>=20
> 2) Naming the LEDs <device>:rgb:backlight-N and send a patch to systemd
> adding a new udev rule to cater for backlight LEDs in general.

If it is known to be mouse, use mouse_backlight or something like
that. Just document it so that others use same string.

Best regards,
								Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--ZoaI/ZTpAVc4A5k6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYnOLBAAKCRAw5/Bqldv6
8il+AJ9edp4VRLJO5Wk6Es98eUiFbkB1uQCfd9nOb4SI6MQNXEH6mcwK2y4zygM=
=kRHT
-----END PGP SIGNATURE-----

--ZoaI/ZTpAVc4A5k6--