Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Eric DeVolder <eric.devolder@oracle.com>
To:     linux-kernel@vger.kernel.org, x86@kernel.org,
        kexec@lists.infradead.org, ebiederm@xmission.com,
        dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com
Cc:     tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com,
        nramas@linux.microsoft.com, thomas.lendacky@amd.com,
        robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com,
        konrad.wilk@oracle.com, boris.ostrovsky@oracle.com,
        eric.devolder@oracle.com
Subject: [PATCH v8 0/7] crash: Kernel handling of CPU and memory hot un/plug
Date:   Thu,  5 May 2022 14:45:56 -0400
Message-Id: <20220505184603.1548-1-eric.devolder@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DMDGUsEwQ4bXIlSubZWTa2gCMl7QbBwgJ+Zotu2BWUmEK9O2xxaw+6JiAOsD?=
 =?us-ascii?Q?I6YLNmpqAvDCis8800IQcHjs7c3wuuPYSnTkFQ/cGqnBYzBccfw96Qyv0MoL?=
 =?us-ascii?Q?HVolgceEuhChOSJOuwEOzmZvFuBttu7B4nQsuL7D8Tlj0kJq60fbnGHGN+qG?=
 =?us-ascii?Q?bjRT8qiWc7oskqYwSLFkN2BYkUi5M0SLCcO4WY5RXaF/0NYxFiA2Mrt8WlC+?=
 =?us-ascii?Q?0N5+uxpQIXTOBKJ9wsZVsEWJ0DBUjkj7KIs1dIFEdYX+SJ1/7Gx8Igl8uBiX?=
 =?us-ascii?Q?0mfAY8iJrs7gOD4em892BNvGVD67xIQq3okvAKDd/qBezl1zNSlsit9A+ga2?=
 =?us-ascii?Q?7uMKVSU3ucUSDkbzwnfj8l57y01fnEZENsi6MrsDDHmv1EApzwCX9g2yc5jG?=
 =?us-ascii?Q?OXNPECmeYxoF+nij5eyjf9lNSDqk46zFHYyEJgdu4CnonC0yc+wYVvyrDy5H?=
 =?us-ascii?Q?0j80etD6QaUYKTRu1AW1gt/jhwxBDZzXKMdZoMebkzsZraWFO6cTfbp0TMuZ?=
 =?us-ascii?Q?lT3L6IF9GrAUnyKnkTWGZR/QeHIKhh48KItyqltLqYN/EJ43wSIFDb5lC5y8?=
 =?us-ascii?Q?h3QxcLRcbsy1W33Fc2IZwRPBzXahvE1MjFHGnYfoZn7Sn1hm47FB6x5bS67Q?=
 =?us-ascii?Q?FEy0DdE7Q4jTY651e71ZNI4G5oMVMhfP91ZpPJimVTU3IGt/IaCrK1FQRhFE?=
 =?us-ascii?Q?qi9dMinPvsN8m9LxUtZRMFUYUT7w3MXBwz/rHCQXGQP2lXcAqGuk80+KmUOp?=
 =?us-ascii?Q?MR7Zt3IXxKyWsbqWaQw/KK0nv2TnVDDMo6dB7odA5wDlbEPqDEleDa8CPdnC?=
 =?us-ascii?Q?sph6e7AkSLy2ShAsGVWSygX/4L4eNo4QG5EU/PAAgfmGFh+/V4qbFSfNaP/A?=
 =?us-ascii?Q?qkn/S3DbFS53Qy16VZqehNYn1uQZjBIojGzcJHK7OK0AB5RNwGATC6DTOZyC?=
 =?us-ascii?Q?oK/RLsAZ5O5l43j315HZJlTzEEli1nkZ4GF9HvAOuEQNY+tvvrwsYWr7xxVG?=
 =?us-ascii?Q?pQa1WC7n0LedPHEsMO0I7twHepLdkVrpRd8X/f9uScprz+DM5VYKTktHigyY?=
 =?us-ascii?Q?7+c2IY/WrAtseX3CauWO6q0SNy2Iw5UnEWRApaJKmTB/FTDTMYakxjM6Td4K?=
 =?us-ascii?Q?3Jla+MRtfvIFrA95qtw52JeWebmatmr6yQDyE6LxOKP44DUrmXuYx/IiqJgV?=
 =?us-ascii?Q?wpyOof6AQxtVefunpiCSHhN3t2/3G/QiX0xlRWUK6KndyMZXFnwRxGTXENL/?=
 =?us-ascii?Q?zPxARYYHVLgj9LOeIyl0Fucx2zaZxnTwMnPnX/UtZOwAhOxxRB65kIW2KpQT?=
 =?us-ascii?Q?EPst7xvIawUbrEfYqYKqCdpM2KLXP9OqtxNSel/ef0VueofSEK7b38XTxcvZ?=
 =?us-ascii?Q?X6Hicop9L0JOWElnPLeZ9PqIvx/37NtMNl8ahSRTIDsgWoFZN1eSaxQWzsb8?=
 =?us-ascii?Q?ENJAWtUo9o35XHiiWwyy4KEXPG2+y3lpxb1wnwhU/J6C0TFIReKCUpM6VMH/?=
 =?us-ascii?Q?a64GfqUcEHwzMIuA86rcyl3RB/3GUMSVefLzXgezW/z5lJJ2Z4A5VqyhV9Xp?=
 =?us-ascii?Q?LVLBicaiIJWs8+M61JcIYECscYRCUoVyNyW62jH2CdngEGD5Wetfz522ohtt?=
 =?us-ascii?Q?CBpDfelyyOd2rwce29BuJQ9puq8hFlCKydmGjhSMGZj2E14ijvvcRHkWFWid?=
 =?us-ascii?Q?nnHOtTi+IBiEg4gPp1UYB1BPTZ+lYV359EYqi9+zOJjWydQYlKcCEngO5Kxo?=
 =?us-ascii?Q?8OCUdbB1wxNGl9XYtv+95A9dQ+pcgCY=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 532dea5d-e072-48d1-f380-08da2ec78dc2
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4542.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 18:46:24.5734
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MiGRHdP5gyC6Rgxa5hwXbPpgbSh+DLJ7qwYQLBomSsi42bTUUGmtwhWB93GtDCcWgBYsETiShEDKGCVdx4NimaKFeuQZNGcSP0Yes912Td0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1875
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-05-05_08:2022-05-05,2022-05-05 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 malwarescore=0
 spamscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2205050126
X-Proofpoint-GUID: 8nRBuK2b6PULsxLCOPzNKAw8Zj2bsRiT
X-Proofpoint-ORIG-GUID: 8nRBuK2b6PULsxLCOPzNKAw8Zj2bsRiT
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When the kdump service is loaded, if a CPU or memory is hot
un/plugged, the crash elfcorehdr (for x86), which describes the CPUs
and memory in the system, must also be updated, else the resulting
vmcore is inaccurate (eg. missing either CPU context or memory
regions).

The current solution utilizes udev to initiate an unload-then-reload
of the kdump image (e. kernel, initrd, boot_params, puratory and
elfcorehdr) by the userspace kexec utility. In previous posts I have
outlined the significant performance problems related to offloading
this activity to userspace.

This patchset introduces a generic crash hot un/plug handler that
registers with the CPU and memory notifiers. Upon CPU or memory
changes, this generic handler is invoked and performs important
housekeeping, for example obtaining the appropriate lock, and then
invokes an architecture specific handler to do the appropriate
updates.

In the case of x86_64, the arch specific handler generates a new
elfcorehdr, and overwrites the old one in memory. No involvement
with userspace needed.

To realize the benefits/test this patchset, one must make a couple
of minor changes to userspace:

 - Disable the udev rule for updating kdump on hot un/plug changes.
   Add the following as the first two lines to the udev rule file
   /usr/lib/udev/rules.d/98-kexec.rules:

# For x86_64, the kernel handles updates to crash elfcorehdr
CONST{arch}=="x86-64", GOTO="kdump_reload_end"

   These two lines will cause cpu and memory hot un/plug events
   to be skipped within this rule file, for x86_64.

 - Change to the kexec_file_load for loading the kdump kernel:
   Eg. on RHEL: in /usr/bin/kdumpctl, change to:
    standard_kexec_args="-p -d -s"
   which adds the -s to select kexec_file_load syscall.

This patchset supports kexec_load with a modified kexec userspace
utility, and a working changeset to the kexec userspace utility
is provided here (and to use, the above change to standard_kexec_args
would be, for example, to append --hotplug-size=131072 instead of -s).

 diff --git a/kexec/arch/i386/crashdump-x86.c b/kexec/arch/i386/crashdump-x86.c
 index 9826f6d..06adb7e 100644
 --- a/kexec/arch/i386/crashdump-x86.c
 +++ b/kexec/arch/i386/crashdump-x86.c
 @@ -48,6 +48,7 @@
  #include <x86/x86-linux.h>
  
  extern struct arch_options_t arch_options;
 +extern unsigned long long hotplug_size;
  
  static int get_kernel_page_offset(struct kexec_info *UNUSED(info),
  				  struct crash_elf_info *elf_info)
 @@ -975,6 +976,13 @@ int load_crashdump_segments(struct kexec_info *info, char* mod_cmdline,
  	} else {
  		memsz = bufsz;
  	}
 +
 +    /* If hotplug support enabled, use that size */
 +    if (hotplug_size) {
 +        memsz = hotplug_size;
 +    }
 +
 +    info->elfcorehdr =
  	elfcorehdr = add_buffer(info, tmp, bufsz, memsz, align, min_base,
  							max_addr, -1);
  	dbgprintf("Created elf header segment at 0x%lx\n", elfcorehdr);
 diff --git a/kexec/kexec.c b/kexec/kexec.c
 index f63b36b..9569d9a 100644
 --- a/kexec/kexec.c
 +++ b/kexec/kexec.c
 @@ -58,6 +58,7 @@
  
  unsigned long long mem_min = 0;
  unsigned long long mem_max = ULONG_MAX;
 +unsigned long long hotplug_size = 0;
  static unsigned long kexec_flags = 0;
  /* Flags for kexec file (fd) based syscall */
  static unsigned long kexec_file_flags = 0;
 @@ -672,6 +673,12 @@ static void update_purgatory(struct kexec_info *info)
  		if (info->segment[i].mem == (void *)info->rhdr.rel_addr) {
  			continue;
  		}
 +        /* Don't include elfcorehdr in the checksum, if hotplug
 +         * support enabled.
 +         */
 +        if (hotplug_size && (info->segment[i].mem == (void *)info->elfcorehdr)) {
 +			continue;
 +		}
  		sha256_update(&ctx, info->segment[i].buf,
  			      info->segment[i].bufsz);
  		nullsz = info->segment[i].memsz - info->segment[i].bufsz;
 @@ -1504,6 +1511,17 @@ int main(int argc, char *argv[])
  		case OPT_PRINT_CKR_SIZE:
  			print_crashkernel_region_size();
  			return 0;
 +		case OPT_HOTPLUG_SIZE:
 +            /* Reserved the specified size for hotplug growth */
 +			hotplug_size = strtoul(optarg, &endptr, 0);
 +			if (*endptr) {
 +				fprintf(stderr,
 +					"Bad option value in --hotplug-size=%s\n",
 +					optarg);
 +				usage();
 +				return 1;
 +			}
 +			break;
  		default:
  			break;
  		}
 diff --git a/kexec/kexec.h b/kexec/kexec.h
 index 595dd68..b30dda4 100644
 --- a/kexec/kexec.h
 +++ b/kexec/kexec.h
 @@ -169,6 +169,7 @@ struct kexec_info {
  	int command_line_len;
  
  	int skip_checks;
 +    unsigned long elfcorehdr;
   };
  
  struct arch_map_entry {
 @@ -231,7 +232,8 @@ extern int file_types;
  #define OPT_PRINT_CKR_SIZE	262
  #define OPT_LOAD_LIVE_UPDATE	263
  #define OPT_EXEC_LIVE_UPDATE	264
 -#define OPT_MAX			265
 +#define OPT_HOTPLUG_SIZE	265
 +#define OPT_MAX			266
  #define KEXEC_OPTIONS \
  	{ "help",		0, 0, OPT_HELP }, \
  	{ "version",		0, 0, OPT_VERSION }, \
 @@ -258,6 +260,7 @@ extern int file_types;
  	{ "debug",		0, 0, OPT_DEBUG }, \
  	{ "status",		0, 0, OPT_STATUS }, \
  	{ "print-ckr-size",     0, 0, OPT_PRINT_CKR_SIZE }, \
 +	{ "hotplug-size",     2, 0, OPT_HOTPLUG_SIZE }, \
  
  #define KEXEC_OPT_STR "h?vdfixyluet:pscaS"
 

Regards,
eric
---
v8: 5may2022
 - Per Borislav Petkov, eliminated CONFIG_CRASH_HOTPLUG in favor
   of CONFIG_HOTPLUG_CPU || CONFIG_MEMORY_HOTPLUG, ie a new define
   is not needed. Also use of IS_ENABLED() rather than #ifdef's.
   Renamed crash_hotplug_handler() to handle_hotplug_event().
   And other corrections.
 - Per Baoquan, minimized the parameters to the arch_crash_
   handle_hotplug_event() to hp_action and cpu.
 - Introduce KEXEC_CRASH_HP_INVALID_CPU definition, per Baoquan.
 - Per Sourabh Jain, renamed and repurposed CRASH_HOTPLUG_ELFCOREHDR_SZ
   to CONFIG_CRASH_MAX_MEMORY_RANGES, mirroring kexec-tools change
   by David Hildebrand. Folded this patch into the x86
   kexec_file_load support patch.

v7: 13apr2022
 https://lkml.org/lkml/2022/4/13/850
 - Resolved parameter usage to crash_hotplug_handler(), per Baoquan.

v6: 1apr2022
 https://lkml.org/lkml/2022/4/1/1203
 - Reword commit messages and some comment cleanup per Baoquan.
 - Changed elf_index to elfcorehdr_index for clarity.
 - Minor code changes per Baoquan.

v5: 3mar2022
 https://lkml.org/lkml/2022/3/3/674
 - Reworded description of CRASH_HOTPLUG_ELFCOREHDR_SZ, per
   David Hildenbrand.
 - Refactored slightly a few patches per Baoquan recommendation.

v4: 9feb2022
 https://lkml.org/lkml/2022/2/9/1406
 - Refactored patches per Baoquan suggestsions.
 - A few corrections, per Baoquan.

v3: 10jan2022
 https://lkml.org/lkml/2022/1/10/1212
 - Rebasing per Baoquan He request.
 - Changed memory notifier per David Hildenbrand.
 - Providing example kexec userspace change in cover letter.

RFC v2: 7dec2021
 https://lkml.org/lkml/2021/12/7/1088
 - Acting upon Baoquan He suggestion of removing elfcorehdr from
   the purgatory list of segments, removed purgatory code from
   patchset, and it is signficiantly simpler now.

RFC v1: 18nov2021
 https://lkml.org/lkml/2021/11/18/845
 - working patchset demonstrating kernel handling of hotplug
   updates to x86 elfcorehdr for kexec_file_load

RFC: 14dec2020
 https://lkml.org/lkml/2020/12/14/532
 - proposed concept of allowing kernel to handle hotplug update
   of elfcorehdr
---


Eric DeVolder (7):
  x86/crash: fix minor typo/bug in debug message
  crash: prototype change for crash_prepare_elf64_headers
  crash: add generic infrastructure for crash hotplug support
  kexec: exclude elfcorehdr from the segment digest
  kexec: exclude hot remove cpu from elfcorehdr notes
  x86/crash: Add x86 crash hotplug support for kexec_file_load
  x86/crash: Add x86 crash hotplug support for kexec_load

 arch/arm64/kernel/machine_kexec_file.c |   6 +-
 arch/powerpc/kexec/file_load_64.c      |   2 +-
 arch/x86/Kconfig                       |  11 ++
 arch/x86/kernel/crash.c                | 146 ++++++++++++++++++++++++-
 include/linux/crash_core.h             |  10 ++
 include/linux/kexec.h                  |  10 +-
 kernel/crash_core.c                    | 102 +++++++++++++++++
 kernel/kexec_file.c                    |  15 ++-
 8 files changed, 292 insertions(+), 10 deletions(-)

-- 
2.27.0