Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <05e94e6a-86d3-5d60-081a-6adb3bcafb35@nvidia.com>
Date:   Wed, 4 May 2022 20:17:50 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: linux-next: build failure after merge of the hte tree
Content-Language: en-US
To:     Thierry Reding <thierry.reding@gmail.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
References: <20220504165956.531c4b53@canb.auug.org.au>
 <YnIlh++OJDRrK9sz@orome>
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <YnIlh++OJDRrK9sz@orome>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1RoaXBGSXZMQnZ1M1VlbEtXMHJjY0hJUlhNQUlqL2piSjR3Y0hic0x6UU5h?=
 =?utf-8?B?Tmo0ZExJVWVWdy9iandOT0pGNk5jck9ydUZpWW5wRGVnZmZGaTdEcEh4OXMy?=
 =?utf-8?B?aFRGRDAwUS96dStMSDlpVTRmQmJBMVBMdTVTNnlXczduMUVKYzdESjh2RldC?=
 =?utf-8?B?TWtseEFQL1RBakc5Q0hYaGttRld1cU43SERET0llaGpDOTJtMXB4ZCsyMWR6?=
 =?utf-8?B?NnhWejc1UlFuRk5MRHl1WTZyc0dYaFZQcXN5MG13elB6cmwvYkpQSnExT3da?=
 =?utf-8?B?VFc0ODUzaWZ4UWdDcUw5MGJUQTB2OVFkMUtWSitDaFB3ZVc1SnMrQU1KTDlI?=
 =?utf-8?B?S2pJN0tISnQxNzAxT3JiNmpQQVd2cittNUZWclJiRGZNcVZiUXl0NVV4WXlx?=
 =?utf-8?B?Y3o0ZDVIRGl4QjYrenF4am41Ny9YV1A4Mm9IbWp5alNaOE5oYUIvNWc5bFkr?=
 =?utf-8?B?U0hjOHhVemxjMVZhc0E1d25GV3dXUE40SUVHM3RTVmNON0pYL1hHaWQyUXV1?=
 =?utf-8?B?R0VVY3NkNEtwald2VW1VVmZDVHErV1B5bkxmZ2h4akxVZVhDaGVyVEhCUFJN?=
 =?utf-8?B?WnhKSTRjb3h6ME50SU1PeVNFcW9jK0lMNVZlY0pJMGxmSWttNHVHMVVTaHpy?=
 =?utf-8?B?OXlmcVFYSDdHQTQwMERqT2YyK3o0V2JVa21JUE5LMkV6UERsWlVQTTlYUU5C?=
 =?utf-8?B?dnAyNE1pNWt6RGpnWk9yNkRKbFlwOEFwYWN0amFtbk5GbXlJYzM2V1NEcjg2?=
 =?utf-8?B?QndRWW43L29FaVRiNXlvSVBxTHZjUU5pd3ZCTnp5K0xoaHdyVnVFOGtrWEhh?=
 =?utf-8?B?TjZiaDFuR0phdFBYVExubDV6ZVRacTlVcHcvS0J4NjIxN201ZUpyMDBnSmk1?=
 =?utf-8?B?NjRiNTBWaXh6bjBuaVcwRURlZE9YRlZRaWltRWZ2alZGTU1kMlhKOEFVVm8x?=
 =?utf-8?B?UWVucDg1dW5KTDRjMFdNOHJXZ0lDditISldmNGhJa0RtT2g1eUtwZktqTFhR?=
 =?utf-8?B?ZWVvaWFRSmZHOGkyQ2NKVDdYNWpNU05SNC8rL3lERFgzNnI4K0pBUmowNDFL?=
 =?utf-8?B?ZmkvQk1QcnlXUXNpamhVVmRTcUJSZ2EvcHRkYUdoeHA2UGdDREJ4dDdlaHg2?=
 =?utf-8?B?dHM1dVZaeHd2YVFqTTBBRi9tZ2VRWE5weDNwdEd6bEZra1BoRkMybnFNdFIr?=
 =?utf-8?B?bEV0Wnh3VzdTd3ZWQ3VKN3p6TUN6ZWlnbGxxcnlDU1Z5LzlRSm10KzdhZEt2?=
 =?utf-8?B?Z0dvN210bzh5ZGNuMm9xUElHVGN3Y3ZsZk1LQ20wUWFaRkFrOU0zeWVPNVVy?=
 =?utf-8?B?amtQVjBqTjJlN1lHMjVURFRaejhMT0hNajZZN3kxNzVxRmJmQWluQTk4NGs3?=
 =?utf-8?B?VXU3bnFNcjNhN2Znbno4V3U5clZQMXFUWHdQSlpIVG1QbllwMzIvSHV2a1pr?=
 =?utf-8?B?dmdrdUFnMDkxeDhQelJKTmJlU1pDZWNVOTE1VXJnMk9PaUpwMGVSRHlnUzdQ?=
 =?utf-8?B?UUNtRlQzZG1aSk5vNGNUaUJJbkMrd2k4UC9yVDdQajI1blJYa0haZnlVcVBt?=
 =?utf-8?B?Kzg2bDBiek0zWlBvbnBjOU5tQ3hnRkV3T1dtYWx5QzRra1RMdTdrZlQxVlp6?=
 =?utf-8?B?MWEvcVFDeVBLM2JheFF5cHJlU1VzVHlGdWpROXhhV1ZoZEs2eDhmT0psVzRi?=
 =?utf-8?B?QTR4d25hM1hYUW9MZmNBcW5iQlF4NGRFZnlRTE81TER5NUNud21KL0ZmN0Rk?=
 =?utf-8?B?MWx5VVlSWlVzRjFmajE5MS9QUnRxNFJoWGZ4djFWY1doRTNJeVdtRWlia1Nx?=
 =?utf-8?B?a0k2VUgvaHA0SGxpTWFTMk5ITnVIcWc0enRCeGpJVUhuUkRST1ZTYStrTmp1?=
 =?utf-8?B?V3VIWTlGbXFVdXp0YmpiaUFubCtUNFRTQU40cUYxUnJoNDR2VEZXcmh0Z2pJ?=
 =?utf-8?B?T0VlOTI0L3B5NnZ5WkE4cmhSWE8zRXloNTdpNEpsUUo4dXVJRkgzVThVcUZ1?=
 =?utf-8?B?cHlPbEo0MDlWaEZ6NFY3T0xqUVlOOUQwQTROZFFKdHJrdy9QQXRhTHZ5enJD?=
 =?utf-8?B?V0VtTUR4b3Jvcy8yZW9WUkhVYThtZ2M3WHNQbU1kcVlpVFB0UE5PL3JLRmpV?=
 =?utf-8?B?NTAzRTVJdU1ISWRXOWhsTVV1dGpNSFdpNDRsakt5QkdBR2lVVnNYR0hOVWZE?=
 =?utf-8?B?Q1Y0Yzh2SWxUZnNuUGt4ZlhNYjRNZVpxbWE4c3NkNldsVnQ3cDdMQllSZmUr?=
 =?utf-8?B?STdxUm9EdEswdk1pVk02aGFkc0NEVXNOV2lVY1A4ZmdxSlhiMko2NGE3clRq?=
 =?utf-8?B?RHVScjhOOEpwVWJ1dmU3b0F2bWNqNS9kSzF2bUMveFJWRjdrZTNHdz09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a72baa8f-b8d9-45a6-5cb7-08da2e45d67a
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4116.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 03:17:51.3092
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: em5i4QoUjiFi2KNwYTNi/7sZREXG6XmS5LTIPH/TWd2xnHIFQtMvwRDwwsmGtbt+CG3QOgq+89yt13O2WwWgIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2646
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Stephen, Thierry,

Before sending patches I compiled and tested with or without HTE config successfully, I used gcc arm64 cross compiler. The initial problem kernel boat reported (reproduce step snippet below) used clang as compiler and that gives typedef issue which is what hte_return_t is. Do you know if we have to treat it differently with clang vs gcc or did I miss something?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-tegra.git hte/for-next
head:   cedbe14082d169f4c1136c70c5170a76bd9a076a
commit: 98935236600d4e179b664ffcfcd54e0ec3a1b4e3 [7/10] gpiolib: cdev: Add hardware timestamp clock type
config: arm-ep93xx_defconfig (https://download.01.org/0day-ci/archive/20220504/202205040454.CGWxoTt3-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 363b3a645a1e30011cc8da624f13dac5fd915628)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-tegra.git/commit/?id=98935236600d4e179b664ffcfcd54e0ec3a1b4e3
        git remote add arm-tegra https://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-tegra.git
        git fetch --no-tags arm-tegra hte/for-next
        git checkout 98935236600d4e179b664ffcfcd54e0ec3a1b4e3
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash


However below failure seems like (correct me if I am wrong) Thierry might have changed typedef to int in one place and possibly not all other places.

On 5/4/22 12:04 AM, Thierry Reding wrote:
> On Wed, May 04, 2022 at 04:59:56PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the hte tree, today's linux-next build (arm
>> multi_v7_defconfig) failed like this:
>>
>> drivers/gpio/gpiolib-cdev.c:572:8: error: unknown type name 'hte_return_t'
>>   572 | static hte_return_t process_hw_ts_thread(void *p)
>>       |        ^~~~~~~~~~~~
>> drivers/gpio/gpiolib-cdev.c:623:8: error: unknown type name 'hte_return_t'
>>   623 | static hte_return_t process_hw_ts(struct hte_ts_data *ts, void *p)
>>       |        ^~~~~~~~~~~~
>> drivers/gpio/gpiolib-cdev.c: In function 'hte_edge_setup':
>> drivers/gpio/gpiolib-cdev.c:851:41: error: passing argument 2 of 'hte_request_ts_ns' from incompatible pointer type [-Werror=incompatible-pointer-types]
>>   851 |         return hte_request_ts_ns(hdesc, process_hw_ts,
>>       |                                         ^~~~~~~~~~~~~
>>       |                                         |
>>       |                                         int (*)(struct hte_ts_data *, void *)
>> In file included from drivers/gpio/gpiolib-cdev.c:27:
>> include/linux/hte.h:234:75: note: expected 'hte_ts_cb_t' {aka 'enum hte_return (*)(struct hte_ts_data *, void *)'} but argument is of type 'int (*)(struct hte_ts_data *, void *)'
>>   234 | static inline int hte_request_ts_ns(struct hte_ts_desc *desc, hte_ts_cb_t cb,
>>       |                                                               ~~~~~~~~~~~~^~
>> drivers/gpio/gpiolib-cdev.c:852:34: error: passing argument 3 of 'hte_request_ts_ns' from incompatible pointer type [-Werror=incompatible-pointer-types]
>>   852 |                                  process_hw_ts_thread, line);
>>       |                                  ^~~~~~~~~~~~~~~~~~~~
>>       |                                  |
>>       |                                  int (*)(void *)
>> In file included from drivers/gpio/gpiolib-cdev.c:27:
>> include/linux/hte.h:235:53: note: expected 'hte_ts_sec_cb_t' {aka 'enum hte_return (*)(void *)'} but argument is of type 'int (*)(void *)'
>>   235 |                                     hte_ts_sec_cb_t tcb, void *data)
>>       |                                     ~~~~~~~~~~~~~~~~^~~
>> cc1: some warnings being treated as errors
>>
>> Something has been missed in the contruction of the git tree :-(
>>
>> I have dropped the hte tree for today.
> Yeah, oddly I didn't catch that when I was doing the test build. Let me
> recheck what went wrong there.
>
> Sorry for the mess,
> Thierry