Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 4 May 2022 21:48:40 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Dmitry Rokosov <DDRokosov@sberdevices.ru>
Cc:     Rob Herring <robh@kernel.org>,
        "stano.jakubek@gmail.com" <stano.jakubek@gmail.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "lars@metafoo.de" <lars@metafoo.de>,
        "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
        "stephan@gerhold.net" <stephan@gerhold.net>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        kernel <kernel@sberdevices.ru>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 3/3] dt-bindings: iio: accel: add dt-binding schema
 for msa311 accel driver
Message-ID: <20220504214840.1ad32bff@jic23-huawei>
In-Reply-To: <20220504183716.shhpi5adcxz4ufvj@CAB-WSD-L081021.sigma.sbrf.ru>
References: <20220419154555.24191-1-ddrokosov@sberdevices.ru>
        <20220419154555.24191-4-ddrokosov@sberdevices.ru>
        <YmhWic3rG8ERtCYY@robh.at.kernel.org>
        <20220504183716.shhpi5adcxz4ufvj@CAB-WSD-L081021.sigma.sbrf.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 4 May 2022 18:36:33 +0000
Dmitry Rokosov <DDRokosov@sberdevices.ru> wrote:

> Hello Rob,
> 
> I've missed one note below, please check if possible.
> 
> On Tue, Apr 26, 2022 at 03:31:05PM -0500, Rob Herring wrote:
> > On Tue, Apr 19, 2022 at 03:45:58PM +0000, Rokosov Dmitry Dmitrievich wrote:  
> > > +  "#address-cells":
> > > +    const: 1
> > > +
> > > +  "#size-cells":
> > > +    const: 0  
> > 
> > These apply to 'reg' in a child node, but you don't have child nodes so 
> > drop them.
> >   
> 
> I'm afraid, I made a mistake in the previous reply. Here I applied
> address-cells and size-cells to show which type accelerometer's reg
> property has, like this one:
> 
>     i2c {
>         #address-cells = <1>;
>         #size-cells = <0>;
>     
>         accelerometer@62 {
>             compatible = "memsensing,msa311";
>             reg = <0x62>;
> 
> Above accelerometer@62 is child node for i2c bus node, so address and
> size cells mean accelerometer reg format. Am I missing something?

They are characteristics of the i2c master and hence
are listed in those binding docs, not the one for the accelerometer.

Thanks,

Jonathan
>