Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   "R, Monish Kumar" <monish.kumar.r@intel.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "olebowle@gmx.com" <olebowle@gmx.com>,
        "oneukum@suse.com" <oneukum@suse.com>,
        "vpalatin@chromium.org" <vpalatin@chromium.org>,
        "wangjm221@gmail.com" <wangjm221@gmail.com>,
        "chris.chiu@canonical.com" <chris.chiu@canonical.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Rao, Abhijeet" <abhijeet.rao@intel.com>
Subject: RE: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for
 Dell usb gen 2 device to not fail during enumeration.
Thread-Topic: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for
 Dell usb gen 2 device to not fail during enumeration.
Thread-Index: AQHYYGiY+IIOJ+L3hkCnjjBIIxNTcq0QM0SAgAEeO3A=
Date:   Fri, 6 May 2022 05:28:36 +0000
Message-ID: <SA2PR11MB51157FBE0367288DEBC4396BC3C59@SA2PR11MB5115.namprd11.prod.outlook.com>
References: <20220505101459.7804-1-monish.kumar.r@intel.com>
 <YnPARed/HKdnwPKV@kroah.com>
In-Reply-To: <YnPARed/HKdnwPKV@kroah.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.401.20
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3As5SN310rYbOuxpcgjbfSeLLryMdGdoLEQBWuhTy8LTk4NJABlpt3Xe/ERM?=
 =?us-ascii?Q?K6efK6c4PiAatDNJXCopBAurYe3tJcX5unBOQoIqruiaGgrAkOczR2Z8WkCs?=
 =?us-ascii?Q?RHCUiByOv5fmdBndqKA+wXxX/o59UN4SWxPnUbXKhsNzND8DK5FZJVcauayj?=
 =?us-ascii?Q?dPheNv73I79Cs6sMCFf9ZdNTr8okCd4r7F9Qb3YfNFDKd6TpYT8ZvG+a0dfW?=
 =?us-ascii?Q?SFaEGyx8LDg1iUGi0xNuvwvJ0WENCJvGMs4y4jHvmiBScHgkXuC0FQWdnV2j?=
 =?us-ascii?Q?mYWXjSwqrgQkqP/KutoD/kigRUT0aKOH98BsAHnfVEvQLjdHFUcuQebK7owF?=
 =?us-ascii?Q?SDR6d5yjidHb4d9YA1WE0bjrwQKYgKHflutzDUKdXTPXL4IQ8Q6oZlO84oyq?=
 =?us-ascii?Q?2ODAuHI+3If1r4VML1QGFD6cWlkT2qjMmY1Xa77yKmnsR5bBA0MYvqitlFYc?=
 =?us-ascii?Q?NKpa3/sbMg6xHDhtCkR40OBbSLp4q2dc9gWso+aXW/fOeuPGDIUBKCnx++hx?=
 =?us-ascii?Q?lqoQBX7+ngTGY/+NwpfU+xWc6TeC6naGxYwNAMrnfvkhQ/GdmuxALQV9YswD?=
 =?us-ascii?Q?LG3bFCFZgD6haLt/TWmKk2Q7BVK66O0AlX0QoWUabaahSD33dIWRYYzKrMXb?=
 =?us-ascii?Q?7aslgv7VmiLaRqwRg3nKk9D/4k1BxDd4SD8ZMQsZdxtcwM06b7ena025VbMZ?=
 =?us-ascii?Q?1lhMzB5oyGKHq2E8we4MN0+lkP+8wg7/Wcr4ttyMhkA237nlWsZ54R9B2hPC?=
 =?us-ascii?Q?4Y+3RDRrimxc+g0xBmED4mtBMrL/jUm10GKb3fsioo6ZXjmJ9JCNPug+z/on?=
 =?us-ascii?Q?/d6/6tdaA+XT+ZSjjfoDHuySYXDQw/SxnH888WQrqN5+DWfdW51C6LTf/hMc?=
 =?us-ascii?Q?5B9ihOH8uGRVJKYJfWiBDxMxpHsH9FnwquHjwIkBwsep/Ym47ACiS38hjFLs?=
 =?us-ascii?Q?AWpsQS5weK+FLAVOuKbzB9DjHzka05zJ6MaGwsUokheWBd1/n4/YhSeaTHO+?=
 =?us-ascii?Q?jjIxNZbouxrXRO0HEBhizE35KpA0qhTZCNU1nKFExtwkatZ3ao2V73QYFsEq?=
 =?us-ascii?Q?Qxz4ou6bcLwd+3xQuIplbKqFVFztu2Y7bHIaKauV/4l0AdZ4BQfhtV1o082n?=
 =?us-ascii?Q?skSLlJtqGUlVQf1XDyOgewIs3j8QOxAh2/FvDAU8T1aRRg0Xj5h/araLhCmJ?=
 =?us-ascii?Q?CxSmbUy16pn6Oip9xNIVlaPUYSan5O+a2EqGTBOfaUsQOlogi8juD/4kPO1A?=
 =?us-ascii?Q?DH1Yxh5WmSlU3IADHftZpDdcLhNnEhKc3hpouAKwmc49UHz/YnK/5wxW/7tg?=
 =?us-ascii?Q?EYa056BcsgzJERTOIKCSMrxDhxpeFY7gL7CMzqbW7GaTruAb/hWOoBSJw6hl?=
 =?us-ascii?Q?6MHawqbUBdSkYl0ck2BOz04bLcuyOdkdKpiKWOxq4RQNA2PtlWr024dmAh7Y?=
 =?us-ascii?Q?uClFhMy/7H49Vr/+s0scAiV3KN/CUZc3EC1m+m6m9m6Djv9UYNZhMYr1Xiys?=
 =?us-ascii?Q?I0xhskoQZuv8kk5644I4Fcmo74h1Hk2evSx4848Jo9ybJs4Oh39wlAc1hxJW?=
 =?us-ascii?Q?FWHNZjium+pdjOXfCgdSXquxoSjoqCEFoNWYWfHYOrHthr0wKxNjiRCEiJPK?=
 =?us-ascii?Q?EsSYAW73QRmNw25huaaNmyzqrR+T0MPdQvvhI80hS/AbfkASpAxzN5he1cJO?=
 =?us-ascii?Q?o57c3lhROFhZCIMRTKjyAzVkpHNwF3XjPB8e+L8ynKm+XaGULvwNymEw6MmZ?=
 =?us-ascii?Q?O7E92dFMlg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB5115.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24952c9f-84fb-4afa-8ee4-08da2f2144dd
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2022 05:28:36.1674
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zeiKUFgHKxJSz6qek+q6/IF45Ba2EiADNHmUrOfu/F5R1r+ZxpOCIflniPMMEVYC/gXkx0UqeYCbz4blOJ4wZn8tZwzad+jfsqm1vsotk4Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5118
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi greg,

Are you sure you need both?  How was this tested that both are actually set=
?

>>  Yes, both NO_LPM and RESET_RESUME quirks were needed.
As the Dell usb gen2 device U1/U2 link states were failing when connected t=
o type-C ports.
Disabling LPM helps to resolve U1/U2 link state failures. However, it leads=
 to resetting the device multiple times. So, added with NO_LPM and RESET_RE=
SUME usb quirks.

Tested multiple hotplug of Dell usb gen 2 device, it passed for all the cas=
es.

Regards,
Monish Kumar R

-----Original Message-----
From: Greg KH <gregkh@linuxfoundation.org>=20
Sent: 05 May 2022 17:47
To: R, Monish Kumar <monish.kumar.r@intel.com>
Cc: olebowle@gmx.com; oneukum@suse.com; vpalatin@chromium.org; wangjm221@gm=
ail.com; chris.chiu@canonical.com; linux-usb@vger.kernel.org; linux-kernel@=
vger.kernel.org; Rao, Abhijeet <abhijeet.rao@intel.com>
Subject: Re: [PATCH] Add USB_QUIRK_NO_LPM USB_QUIRK_RESET_RESUME quirks for=
 Dell usb gen 2 device to not fail during enumeration.

On Thu, May 05, 2022 at 03:44:59PM +0530, monish.kumar.r@intel.com wrote:
> From: Monish Kumar R <monish.kumar.r@intel.com>
>=20
> Signed-off-by: Monish Kumar R <monish.kumar.r@intel.com>
> ---
>  drivers/usb/core/quirks.c | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c=20
> index 97b44a68668a..257ac37464e8 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -515,6 +515,10 @@ static const struct usb_device_id=20
> usb_quirk_list[] =3D {
> =20
>  	/* INTEL VALUE SSD */
>  	{ USB_DEVICE(0x8086, 0xf1a5), .driver_info =3D USB_QUIRK_RESET_RESUME=20
> },
>        =20
> +	/*DELL USB GEN2 */
> +	{ USB_DEVICE(0x413c, 0xb062), .driver_info =3D USB_QUIRK_NO_LPM },
> +	{ USB_DEVICE(0x413c, 0xb062), .driver_info =3D USB_QUIRK_RESET_RESUME=20
> +},

Are you sure you need both?  How was this tested that both are actually set=
?

thanks,

greg k-h