Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Bjorn Andersson <bjorn.andersson@linaro.org>
To:     agross@kernel.org, Tom Rix <trix@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: (subset) [PATCH] soc: qcom: pdr: use static for servreg_* variables
Date:   Fri,  6 May 2022 10:03:09 -0500
Message-Id: <165184936433.73465.7411487617454793164.b4-ty@linaro.org>
In-Reply-To: <20220422173806.21982-1-trix@redhat.com>
References: <20220422173806.21982-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Fri, 22 Apr 2022 13:38:06 -0400, Tom Rix wrote:
> Sparse reports this repesentative issue
> pdr_internal.h:31:22: warning: symbol 'servreg_location_entry_ei' was not declared. Should it be static?
> Similar for other servreg_*
> 
> Global variables should not be defined in header files.
> This only works because pdr_internal.h is only included
> by pdr_interface.c.  Single file use variables should be
> static so add static to their storage-class specifiers.
> 
> [...]

Applied, thanks!

[1/1] soc: qcom: pdr: use static for servreg_* variables
      commit: 28e3dc8f8cd37eedc14e97e80a7a2e33359491df

Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>