Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4830391iob; Mon, 9 May 2022 02:38:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwIoRNnSKz0Fky9qdnGgTmI2mJcb3TIIK+5ZufFOVHBSyvgfdi1t39/gJqc2L7mVvgdBQQ+ X-Received: by 2002:a05:6a00:10d3:b0:4fe:5d:75c8 with SMTP id d19-20020a056a0010d300b004fe005d75c8mr15289492pfu.6.1652089079762; Mon, 09 May 2022 02:37:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652089079; cv=none; d=google.com; s=arc-20160816; b=JDtGbYwQQv5DXM9I3WY2VvJh6CXbUL7/XGuugWSaBHPhIRoQUFOvweCookMNkKu1uY PKYopcAghbtcZXDTo8u8Hd0b2aEgwX2e5vO1oF9M56uFM29asMIY1JZrnc6VLEfa6x0a l92RZKus32k78sWSNOXG/lIYw5luV/kzcmlluJtpd5zndH6sCoK9CyMNNjw1VgWVOGWU Ar/oGgo8LmAikawPESsu4ZVek8CwPACCPTvWpEAcVmgvCV+h7UZYzIEefqPVlNb7/ML3 pozu6oBQQqyYkJ6QpS+ZBRbRKx48EGZMDVc2BEw59X92iV1evjsGLO/e1qmIdu/t4sjJ Knww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date; bh=ZdDQ6LtWl2DEAg7sCz9m0FnWeZVidJ4i+vpog7FIPbc=; b=x6z9DtBosm0TOR2vx++OTc/FDR1uxyn3OSsIGKbg5sz18GJOVdeb/C2kqj5FS29aUl PkG3BAh8vM2f6MckHWtL/EZIszB1So3xN5+/NghHwizNIxM3cdY6PRXTsAeN3XHbCRYM 232E6SOmcNHJzvEMiAKkLDXiFwsdjG6prYhMQSyG1wI9njU9Tbl2kizMm/SfY/Yv9EvU eVcckLZcOXt241DviziWO15O8RUN0zSmn4n5AlTiUcm7ebO0LrltIKcKQyADCCyMvxyV g3IL46BPWgRh8rkdiAokcjqk619U8nilusDTL7oCTUHMHCpcj1lyYNh6Ihsd3r9tCBq+ GLtg== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id w63-20020a638242000000b003a2e4a3b2d3si13696359pgd.163.2022.05.09.02.37.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 02:37:59 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2D87D1F1CA5; Mon, 9 May 2022 02:23:43 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234322AbiEHOyb (ORCPT + 99 others); Sun, 8 May 2022 10:54:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234311AbiEHOy3 (ORCPT ); Sun, 8 May 2022 10:54:29 -0400 Received: from relay06.th.seeweb.it (relay06.th.seeweb.it [IPv6:2001:4b7a:2000:18::167]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F805BC05; Sun, 8 May 2022 07:50:36 -0700 (PDT) Received: from SoMainline.org (94-209-165-62.cable.dynamic.v4.ziggo.nl [94.209.165.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 610833F371; Sun, 8 May 2022 16:50:34 +0200 (CEST) Date: Sun, 8 May 2022 16:50:32 +0200 From: Marijn Suijten To: phone-devel@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom: sm6350: Replace literal rpmpd indices with constants Message-ID: <20220508145032.dc5xatea5btjpruu@SoMainline.org> Mail-Followup-To: Marijn Suijten , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220507224645.2238421-1-marijn.suijten@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220507224645.2238421-1-marijn.suijten@somainline.org> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Note that the title should have been rpmHpd, apologies for that typo. On 2022-05-08 00:46:45, Marijn Suijten wrote: > It seems the SM6350_CX definition was temporarily replaced with its > literal value 0 in 1797e1c9a95c ("arm64: dts: qcom: sm6350: Add SDHCI1/2 > nodes") to prevent a dependency on the qcom-rpmpd.h header patch being > available prior to this DT patch being applied, similar to c23f1b77358c > ("arm64: dts: qcom: sm6125: Avoid using missing SM6125_VDDCX"). > However, unlike the revert of that in the sm6125 tree the next merge > window around in a90b8adfa2dd ("Revert "arm64: dts: qcom: sm6125: Avoid > using missing SM6125_VDDCX""), this has not yet happened for sm6350: > replace them back now that the definitions are definitely available. > > Signed-off-by: Marijn Suijten > --- > arch/arm64/boot/dts/qcom/sm6350.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi > index fb1a0f662575..b3160720edcb 100644 > --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi > @@ -489,7 +489,7 @@ sdhc_1: sdhci@7c4000 { > clock-names = "iface", "core", "xo"; > qcom,dll-config = <0x000f642c>; > qcom,ddr-config = <0x80040868>; > - power-domains = <&rpmhpd 0>; > + power-domains = <&rpmhpd SM6350_CX>; > operating-points-v2 = <&sdhc1_opp_table>; > bus-width = <8>; > non-removable; > @@ -935,7 +935,7 @@ sdhc_2: sdhci@8804000 { > clock-names = "iface", "core", "xo"; > qcom,dll-config = <0x0007642c>; > qcom,ddr-config = <0x80040868>; > - power-domains = <&rpmhpd 0>; > + power-domains = <&rpmhpd SM6350_CX>; > operating-points-v2 = <&sdhc2_opp_table>; > bus-width = <4>; > > -- > 2.36.0 >