Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Yihao Han <hanyihao@vivo.com>
To:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com, Yihao Han <hanyihao@vivo.com>
Subject: [PATCH] gpiolib: cdev: fix stream_open.cocci warnings
Date:   Thu,  5 May 2022 04:50:11 -0700
Message-Id: <20220505115011.3435-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MQaahhITe2A+yKbisDKl0aiSPftnMxMGsz8sNIk6/SBR7rWUkpbJMnxq1iao?=
 =?us-ascii?Q?bOIWATijX7mcQaHcNaoVAn2dzF+Kv32YiqYUYZixX6HhT4cRjBy9uCm+JxvM?=
 =?us-ascii?Q?2Rhm3BXN2FWfdgfxq5kd/N/kocESo82TDmLjwZmoNqANdjFPZz1Blarl2FuZ?=
 =?us-ascii?Q?tm7+DpH6xj5XIav/PVfQkovwxDAees+UBH99rsurFFD17LLSt9S9J/YG4RbM?=
 =?us-ascii?Q?6Jq5hBmk15cJfK2A80ommt7wZr7m1HXkKecSDPuDDJI1bmgk6GxDhMWFZIqy?=
 =?us-ascii?Q?xq5oeTd7eRL4MZWFh+qWAaoNsuljW/7LapzALZ1P98LvxUlDdoza15uQcdgA?=
 =?us-ascii?Q?cHtr5lYh2iDrlUZhp9VdWUEA14T/R2mmhc+zYHKVBlaeuON1g7mESTBNtnwN?=
 =?us-ascii?Q?SlG7dE3jr3nsHJH4Wt2Y+AE7HryvmTpzqfV+MIaVYC+Kj39O3cAs1eHUpKhe?=
 =?us-ascii?Q?2jly+YcbPTEeNkndUPLo4pHoZ1TGR8rxUvqdyFUF9ekSElZh8PGvReZCX7Z6?=
 =?us-ascii?Q?C2fJ7NX1lz/jrE8plUNDMQQ4GtO8zYx8Gt6dJN+QuFNkISWQ04Vxa90sftNW?=
 =?us-ascii?Q?7qjNO7IKUqvXIZ2G0UvsG06L708YstpQYb/4mCxjo/qSh48m2qHGJzJPOyhT?=
 =?us-ascii?Q?qevQAcuilW4F06vtE2CRMEWtOpWntPEVtxONvSYHUDuFR6QmNuG4U9AQU+Xj?=
 =?us-ascii?Q?iBd3AQY9MveLODLsdUn61UZyBeXpkicaTe2EAf5TwF99BL4EPwBfTV+yvsoq?=
 =?us-ascii?Q?Hk2ZEYwq9Lgy7SzFqvFCYIEE91UmXmmtHoSP9FAlA6qFQKffNGpAX2/MZFnJ?=
 =?us-ascii?Q?QFExmwkWEv+F1hLBKgPbSD7cUDLWaNBmxkYAtk6pXINKldHtlXHMbv3ApAUo?=
 =?us-ascii?Q?w/xhlsj0p4EUSbH/MiEx26uY8iyxm9skPYkn5mtZGeDdlqQmEHbxsSvOKb7B?=
 =?us-ascii?Q?LVm1wbg1rpMb2mXeo1rBqxoz2XMdUG2LrZp0FyHDLDP8ucBJ33NHhErTg7Uy?=
 =?us-ascii?Q?zML5ZeWJYjPLMGuE5p7G5HlwVWTAG0wE98AnoJo1X3x2zFJzcer6jEXgj8Js?=
 =?us-ascii?Q?UOlJqaAPJG4xOye/I54aVWUL+8opVgLlbqSwTgSHfqcFR9QRj9dhDNYJfKWd?=
 =?us-ascii?Q?fBQdQGvZIk1l0iAcj2TatXL3nB9UmVNj4BAkvtsGy3Nsoa3Es7kU6L5yt8DI?=
 =?us-ascii?Q?LopRJaWTnoD6GixGQzG/sAAyVkJ108hZOdpYO5Qyg9ZdezT+cX7rCQfVyIOF?=
 =?us-ascii?Q?cjB7Ui2iduYvBX0X0uzaC+f6vMMyNxmeZCDH0OLJ+4CwGsAtt3cYNLIaESHB?=
 =?us-ascii?Q?wTRMXbuOcSaOSv0wbr+9ypFHknZOdRQfp+LLoHttwaR3V3ihOJpFpb2rYPgD?=
 =?us-ascii?Q?1xwDWswo0HuqhEVQ7CglvnZOF1DslgRhg0XVcVaMxks42K3Ta8vmx8jjCQlH?=
 =?us-ascii?Q?NTVTDqKXO7oqb4S2YKlW8BeXG8CSirrp3nHvYcZX2Cp/vod7u3ftCC7SYPWq?=
 =?us-ascii?Q?GXpvKWEhS18P66RIRmBEU8Kn1wJfio+jP6Tv24Oa1IChQDLJTHcXyh610WxQ?=
 =?us-ascii?Q?/Mk2Xdat4QQ/wW2vToCQM19Mf2QPRB4OMPHokvF4xh7vz4LNwm99xqSCr9Pd?=
 =?us-ascii?Q?ZrgvBh2s62PjMVgO3CfkSfwtq4IB83av2gHydbAqHXQvFbDwl+eMXAzgHGD1?=
 =?us-ascii?Q?OqTyJzZQeK9VF4GbS3Svdv8mrPFd5hp8LBRm2ieknA+ehi3cHK8vqhi4qPLG?=
 =?us-ascii?Q?HDkwLVZltQ=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ada459f-5f10-4a9b-7f3d-08da2e8d81d0
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 11:50:53.0943
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Txr2GUQKh78A8ZtTwkmjWRoM3Bj9VyxLrjgalv2gQQeW+uUr2xkK6OhxMdGaWXUcVZIAjl3cChIsjK1xU4+rHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB2635
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

./drivers/gpio/gpiolib-cdev.c:2498:7-23: WARNING:
gpio_fileops: .read() has stream semantic;
safe to change nonseekable_open -> stream_open.

Generated by: scripts/coccinelle/api/stream_open.cocci

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/gpio/gpiolib-cdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
index f5aa5f93342a..d03c8e012c8c 100644
--- a/drivers/gpio/gpiolib-cdev.c
+++ b/drivers/gpio/gpiolib-cdev.c
@@ -2495,7 +2495,7 @@ static int gpio_chrdev_open(struct inode *inode, struct file *file)
 	get_device(&gdev->dev);
 	file->private_data = cdev;
 
-	ret = nonseekable_open(inode, file);
+	ret = stream_open(inode, file);
 	if (ret)
 		goto out_unregister_notifier;
 
-- 
2.17.1