Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4836893iob; Mon, 9 May 2022 02:49:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOgTOsaWbPi/KxL0JqIyIeYCMKcVZAyUUfT5/9oL/EFQxANdF6hXm63W4GAAbYLe1T10MH X-Received: by 2002:a17:90b:4b51:b0:1dc:9172:f344 with SMTP id mi17-20020a17090b4b5100b001dc9172f344mr17558765pjb.130.1652089775759; Mon, 09 May 2022 02:49:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652089775; cv=none; d=google.com; s=arc-20160816; b=jTfPc5PsDQmhEFnxxzRZ1DCBAwYpqG0/MlGDobLbFHzHq607lOnEQPKMlobrkFQrac zBMmiNm7AHXwn/3NoEyJnkS9bLhbYGXjOPlosuwOBUuTqhbAVR8zt2SwkXTrk9idrdxZ EgdIIf5gula6M9ybHjRVs/86pOu9C5A/qIVzJaMuJ8zClwXk3buaKifmGLHmlka/7Cqc y4RxgZtmxSAL02DlRj2Pv48rH9gUhFKFhCPEzkJ4+q9/z4LzEd5+2i5FhitdC160yJxc za909/KPjF3y0Q9tuh9mpo4Jrgb85Ql7z8UJFqGR3PfVOAneBZ98z8zg+rHtTIgo0M5/ l1wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:to:from:cc:in-reply-to:subject:date:dkim-signature; bh=7u3OwSkyFfQPtUMBSXJ+m0o3AIK+1qwz0/mjtmfCQB0=; b=sE99G9tGeP/3Ss3X2CKNaWROvkT1JTOGdJo/1Nz970Y/cTBi20IB4citnkHPmBvn5K wcgf+612c8etxh+rGN1G+zEDhXT/VGnOmrF9JXUX2+0hP7RwKmclYoOCsQBkNdpghuf4 HKXy6NqHJmjKABlk1V6xJxxc4bzAGV2dF4t9mZW8M/VpfKG7VvrKazEf0oKuZhEV1WHl PAAGAnpz3R4vgjPEL2LRe3Sl+Fkg36rAzZ2DtEX9AAoiwct3kjhnJzyy22U6UVFwcbR+ gTOW1hBESKuE5gSZWxbvAgAi2C7j+nIfJDEm11YXJAOMYFO1wwpqJVwh1Dmb+lV93nlB /Mtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b=FdeTUfLP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id j2-20020a637a42000000b003c157112368si15560353pgn.609.2022.05.09.02.49.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 02:49:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b=FdeTUfLP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5A3512297E6; Mon, 9 May 2022 02:34:51 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1389106AbiEFOi0 (ORCPT + 99 others); Fri, 6 May 2022 10:38:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1385428AbiEFOiY (ORCPT ); Fri, 6 May 2022 10:38:24 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D040C69291 for ; Fri, 6 May 2022 07:34:41 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id x52so6404204pfu.11 for ; Fri, 06 May 2022 07:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=7u3OwSkyFfQPtUMBSXJ+m0o3AIK+1qwz0/mjtmfCQB0=; b=FdeTUfLPDw9k8X6pTEaLv52yUet9VfSQ7bi4HQ1t2xxaDysAJZFgQ7VRrYNlmPjTaj 2tZL8ukYEo7mNc766P4NQqVT9VU4xcQVvoq18pPjJEP+0zEMAny+6Y6R1wOkE1tgO1wN uO8kog1rHC8+u41oS0ocTQzuT0i21hJ3Uz5f+CifLuIMIngaK02mJcE8pu1U5afhbLJI DQvD2wdX+c/IHeRxzEhPxhM8zCujiWsHkyNF2bZlVm+qDJtsTHgLYuDntTJYuurXEomy 6N6H/Q1iuEHCKEfOxPpaFPLiJqifIcesYahJuQ4SUdI1fRp5qzJFzMshG8VThV3XD+0t zf6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=7u3OwSkyFfQPtUMBSXJ+m0o3AIK+1qwz0/mjtmfCQB0=; b=FhLRW7VZJNbGBjumf4CpFmUDXvHPoQdp3njd6cnh9YfasPm4+QcpwhVfUfmXKBt5GJ K8NhdJ5995hLQErNCFJ09Y526duevEa0Xai7z0MTNJ/8fVggUstDXPseR8nASPXFe9HR sPCyB06Mn0FhW1ppv/znXEUalMIR2a+4XuAGwj3GoxGT6T53wFq9Qo19FtRyWwG7rn8V miD/ygw+CMwRz3mChtegUS6ME15M39ng2OEhm2+a/43FNCDjOZyK8rjFXGW1KUcXQF0u m/oBAZiq3t3FTSOM1odEtWShdpyKRSCNd3tk416m9XF5HxPGP519nuNj0jvKi2Jr65K/ eOyA== X-Gm-Message-State: AOAM531NGVhuAFfPhXPJfWYHYCcW7HWiuKiv/7kHdA1J6flL/75HhovA cY3dNK5lwhkdlqEsGawShFGn9A== X-Received: by 2002:a63:d00b:0:b0:3c1:6c87:2135 with SMTP id z11-20020a63d00b000000b003c16c872135mr2936313pgf.93.1651847681336; Fri, 06 May 2022 07:34:41 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id a21-20020a170902ee9500b0015e8d4eb241sm1820885pld.139.2022.05.06.07.34.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 May 2022 07:34:41 -0700 (PDT) Date: Fri, 06 May 2022 07:34:41 -0700 (PDT) X-Google-Original-Date: Fri, 06 May 2022 07:34:18 PDT (-0700) Subject: Re: [PATCH v4 0/7] Generic Ticket Spinlocks In-Reply-To: CC: Arnd Bergmann , guoren@kernel.org, peterz@infradead.org, mingo@redhat.com, Will Deacon , longman@redhat.com, boqun.feng@gmail.com, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, Paul Walmsley , aou@eecs.berkeley.edu, Greg KH , sudipm.mukherjee@gmail.com, macro@orcam.me.uk, jszhang@kernel.org, linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org, openrisc@lists.librecores.org, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org From: Palmer Dabbelt To: Arnd Bergmann Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 05 May 2022 04:09:46 PDT (-0700), Arnd Bergmann wrote: > On Sat, Apr 30, 2022 at 5:36 PM Palmer Dabbelt wrote: >> >> Comments on the v3 looked pretty straight-forward, essentially just that >> RCsc issue I'd missed from the v2 and some cleanups. A part of the >> discussion some additional possible cleanups came up related to the >> qrwlock headers, but I hadn't looked at those yet and I had already >> handled everything else. This went on the back burner, but given that >> LoongArch appears to want to use it for their new port I think it's best >> to just run with this and defer the other cleanups until later. >> >> I've placed the whole patch set at palmer/tspinlock-v4, and also tagged >> the asm-generic bits as generic-ticket-spinlocks-v4. Ideally I'd like >> to take that, along with the RISC-V patches, into my tree as there's >> some RISC-V specific testing before things land in linux-next. This >> passes all my testing, but I'll hold off until merging things anywhere >> else to make sure everyone has time to look. There's no rush on my end >> for this one, but I don't want to block LoongArch so I'll try to stay a >> bit more on top of this one. > > I took another look as well and everything seems fine. I had expected > that I would merge it into the asm-generic tree first and did not bother > sending a separate Reviewed-by tag, but I agree that it's best if you > create the branch. > > Can you add 'Reviewed-by: Arnd Bergmann ' > to each patch and send me a pull request for a v5 tag so we can > merge that into both the riscv and the asm-generic trees? Yep. There were some other minor comments, I'll clean those up as well and send something soon.