Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760433AbXEKBRw (ORCPT ); Thu, 10 May 2007 21:17:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757012AbXEKBRp (ORCPT ); Thu, 10 May 2007 21:17:45 -0400 Received: from ozlabs.org ([203.10.76.45]:38750 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756783AbXEKBRp (ORCPT ); Thu, 10 May 2007 21:17:45 -0400 Subject: [PATCH 0/5] lguest feedback tidyups From: Rusty Russell To: Andrew Morton Cc: lkml - Kernel Mailing List , virtualization , Sam Ravnborg , Jeff Garzik , Christoph Hellwig , Pekka J Enberg Content-Type: text/plain Date: Fri, 11 May 2007 11:17:26 +1000 Message-Id: <1178846246.23513.21.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1152 Lines: 33 Hi all, Gratefully-received recent feedback from CC'd was applied to excellent effect (and the advice from Matt Mackall about my personal appearance is best unrequited). The patch is split in 5 parts to correspond with the 9 parts Andrew sent out before, but here's the summary: 1) Sparse (thanks Christoph Hellwig): - lguest_const can be static now - lguest.c should include "lguest_bus.h" for lguest_devices declaration. - page_tables.c unnecessary initialization - But the cost was high: lots of __force casts 8( 2) Jeff Garzik - Use netdev_priv instead of dev->priv. - Check for ioremap failure - iounmap on failure. - Wrap SEND_DMA and BIND_DMA calls - Don't set NETIF_F_SG unless we set NETIF_F_NO_CSUM - Use SET_NETDEV_DEV() - Don't set dev->irq, mem_start & mem_end (deprecated) 3) Sam Ravnborg - lg-objs is deprecated, use lg-y. Cheers, Rusty. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/