Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 6 May 2022 18:09:01 +0200
From:   Pavel Machek <pavel@ucw.cz>
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>,
        Lee Jones <lee.jones@linaro.org>, Luca Weiss <luca@z3ntu.xyz>,
        Doug Anderson <dianders@chromium.org>,
        Rob Herring <robh+dt@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>, linux-leds@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-pwm@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v14 2/2] leds: Add driver for Qualcomm LPG
Message-ID: <20220506160901.GA1199@bug>
References: <20220303214300.59468-1-bjorn.andersson@linaro.org>
 <20220303214300.59468-2-bjorn.andersson@linaro.org>
 <20220504073009.GC8204@duo.ucw.cz>
 <YnKTAvQc6eDxTl14@ripper>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: 8BIT
In-Reply-To: <YnKTAvQc6eDxTl14@ripper>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk

Hi!

> > > +    "255 500 0 500"
> > > +
> > > +        ^
> > > +        |
> > > +    255 +----+    +----+
> > > +        |    |    |    |      ...
> > > +      0 |    +----+    +----
> > > +        +---------------------->
> > > +        0    5   10   15     time (100ms)
> > > +
> > > +The LPG supports specifying a longer hold-time for the first and last element
> > > +in the pattern, the so called "low pause" and "high pause".
> > 
> > Please see
> > Documentation/devicetree/bindings/leds/leds-trigger-pattern.txt . This
> > should really be compatible.
> 
> Unfortunately the LPG hardware only supports fixed duration (except for
> the ability to hold/extend the first and last duration in the pattern)
> and it also does not support gradual transition between the brightness
> levels.

Ok.

> As such the pattern sequence provided to hw_pattern looks to be the
> smae, but I don't see that it can be made compatible.
> 
> > Can I get either patch to disable pattern infrastructure for now or to
> > get it compatible?
> > 
> 
> I'd be happy to get this updated to your liking, but this was one of the
> drivers we discussed when we introduced the pattern trigger and led to
> the conclusion that we need the ability to do hw-specific patterns.
> 
> As such this document provides the hardware specific documentation, as
> we describe under "hw_pattern" in
> Documentation/ABI/testing/sysfs-class-led-trigger-pattern.
> 
> Please advice on what you would like me to do.

I'd like you to use same format leds-trigger-pattern describes.

If someone passes "255 500 0 500", that's requesting gradual transitions and
your hw can not do that. You return -EINVAL.

If someone wants that kind of blinking, they need to pass "255 0 255 500 0 0 0 500".

Best regards,
									Pavel


-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html