Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 9 May 2022 09:06:55 +0530
From:   Viresh Kumar <viresh.kumar@linaro.org>
To:     Schspa Shi <schspa@gmail.com>
Cc:     rafael@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: fix typo when cpufreq device remove
Message-ID: <20220509033655.f2fsbis72hrjft6q@vireshk-i7>
References: <20220506170832.33386-1-schspa@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220506170832.33386-1-schspa@gmail.com>
User-Agent: NeoMutt/20180716-391-311a52
Precedence: bulk

On 07-05-22, 01:08, Schspa Shi wrote:
> This should check cpufreq_driver->exit pointer before call this function
> 
> Fixes: 91a12e91dc39 ("cpufreq: Allow light-weight tear down and bring up of
> CPUs")
> 
> Signed-off-by: Schspa Shi <schspa@gmail.com>
> ---
>  drivers/cpufreq/cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 43dfaa8124e2..0f59c8ec2b39 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1661,7 +1661,7 @@ static void cpufreq_remove_dev(struct device *dev, struct subsys_interface *sif)
>  
>  	if (cpumask_empty(policy->real_cpus)) {
>  		/* We did light-weight exit earlier, do full tear down now */
> -		if (cpufreq_driver->offline)
> +		if (cpufreq_driver->exit)
>  			cpufreq_driver->exit(policy);
>  
>  		cpufreq_policy_free(policy);

NAK.

The code is doing fine and there is a comment above it on why it is
doing it this way.

-- 
viresh