Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761447AbXEKBzx (ORCPT ); Thu, 10 May 2007 21:55:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755017AbXEKBzo (ORCPT ); Thu, 10 May 2007 21:55:44 -0400 Received: from nommos.sslcatacombnetworking.com ([67.18.224.114]:18682 "EHLO nommos.sslcatacombnetworking.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751580AbXEKBzn (ORCPT ); Thu, 10 May 2007 21:55:43 -0400 In-Reply-To: <20070511012529.GC10715@verge.net.au> References: <200705080004.14570.ismail@pardus.org.tr> <20070508143127.38fafa3c.kim.phillips@freescale.com> <4640D988.1040504@freescale.com> <20070510051042.GA16812@verge.net.au> <46434ED0.6030808@freescale.com> <20070511012529.GC10715@verge.net.au> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <996E281D-DE15-451A-955D-FB9C0C23DA54@kernel.crashing.org> Cc: Timur Tabi , Kim Phillips , Linux Kernel list , netdev , Roman Zippel , Johannes Berg , Sam Ravnborg Content-Transfer-Encoding: 7bit From: Kumar Gala Subject: Re: Kconfig warnings on latest GIT Date: Thu, 10 May 2007 20:41:53 -0500 To: Simon Horman X-Mailer: Apple Mail (2.752.2) X-PopBeforeSMTPSenders: kumar-chaos@kgala.com,kumar-statements@kgala.com,kumar@kgala.com X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - nommos.sslcatacombnetworking.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - kernel.crashing.org X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1715 Lines: 49 On May 10, 2007, at 8:25 PM, Simon Horman wrote: > On Thu, May 10, 2007 at 11:56:48AM -0500, Timur Tabi wrote: >> Simon Horman wrote: >> >>>> So my question is: in which Kconfig do I define "UCC_FAST_TEMP" and >>>> "UCC_SLOW_TEMP"? At first I thought, just put it in drivers/ >>>> Kconfig, but >>>> that Kconfig does nothing but including other Kconfigs. I >>>> believe that if I >>>> submit a patch that adds "UCC_FAST_TEMP" and "UCC_SLOW_TEMP" to >>>> drivers/Kconfig, it will be rejected. Either that, or I'll >>>> spend six weeks >>>> trying to persuade everyone that it's a good idea. >>>> >>>> Does anyone have any suggestions on how I can fix this? >>> That does seem like a reasonable suggestion, and one that >>> would probably work well with the other similar problems >>> that have been introduced sice 2.6.21. >> >> Looks like the fix is simpler than I thought. Instead of having >> >> UCC_GETH >> select UCC_FAST >> >> I need to do >> >> UCC_FAST >> default y if UCC_GETH > > I pondered something like that, but I couldn't get it quite right :( > >> I'll have a patch that fixes this out later today. >> >> I chose the first method because I wanted each individual UCC device >> driver to select UCC_FAST or UCC_SLOW as appropriate, so that I >> wouldn't have to update arch/powerpc/sysdev/qe_lib/Kconfig every time >> we add a new UCC driver. Oh well. It really seems like the kconfig shouldn't complain if the depends isnt satisfied. - k - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/