Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220509020222.1219813-1-starzhangzsd@gmail.com>
In-Reply-To: <20220509020222.1219813-1-starzhangzsd@gmail.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Mon, 9 May 2022 09:21:45 +0200
Message-ID: <CAK8P3a14LLfOs1YFnGj=1Qt_-kLQzg9_P1XgPRLZAC7OeWpCpA@mail.gmail.com>
Subject: Re: [PATCH v2] pcmcia: add MIPS_DB1XXX dependence
To:     Stephen Zhang <starzhangzsd@gmail.com>
Cc:     Dominik Brodowski <linux@dominikbrodowski.net>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Mark Brown <broonie@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Daniel Mack <daniel@zonque.org>, zhangshida@kylinos.cn,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, May 9, 2022 at 4:02 AM Stephen Zhang <starzhangzsd@gmail.com> wrote:
>
> From: Shida Zhang <zhangshida@kylinos.cn>
>
> drivers/pcmcia/db1xxx_ss.c uses the bcsr_xxxx() from
> arch/mips/alchemy/devboards/bcsr.c, which causes a link
> error:
>
> drivers/pcmcia/db1xxx_ss.c:(.text+0x2b4): undefined reference to `bcsr_read'
> mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x2fc): undefined reference to `bcsr_read'
> drivers/pcmcia/db1xxx_ss.c:(.text+0x374): undefined reference to `bcsr_read'
> mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x380): undefined reference to `bcsr_read'
> drivers/pcmcia/db1xxx_ss.c:(.text+0x534): undefined reference to `bcsr_read'
> drivers/pcmcia/db1xxx_ss.c:(.text+0xcc8): undefined reference to `bcsr_mod'
>
>
> So add MIPS_DB1XXX dependence.
>
> Signed-off-by: Shida Zhang <zhangshida@kylinos.cn>
> ---

Looks good to me,

Acked-by: Arnd Bergmann <arnd@arndb.de>