Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <6689f8e3-b61b-9bb1-0334-a3e5f52df450@gnuweeb.org>
Date:   Mon, 9 May 2022 14:34:28 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] tracing: Fix possible crash in ftrace_free_ftrace_ops()
Content-Language: en-US
To:     Jeff Xie <xiehuan09@gmail.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Tom Zanussi <zanussi@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20220508161827.1014186-1-xiehuan09@gmail.com>
 <CAEr6+EC+Kg4AJ=BFxrOSQV+KHj5WSm=1FtYCAPrn1gFnZUk-fg@mail.gmail.com>
From:   Ammar Faizi <ammarfaizi2@gnuweeb.org>
In-Reply-To: <CAEr6+EC+Kg4AJ=BFxrOSQV+KHj5WSm=1FtYCAPrn1gFnZUk-fg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/9/22 8:33 AM, Jeff Xie wrote:
> I am so sorry to bother you, this may be an invalid patch, kfree can
> return directly from null. ;-)

Yeah, kfree(NULL) is a valid call. There's no potential crash here.

-- 
Ammar Faizi