Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 9 May 2022 12:03:35 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc:     ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] fs/ntfs3: Don't clear upper bits accidentally in log_replay()
Message-ID: <YnjY58EpRzaZP+YC@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wMyAFU1jTqD/cO+2uvNHBuHlCHATgdP5LOCGTh1ep6kBYwrojHoj0wJKeE3A?=
 =?us-ascii?Q?7NVvfuYBKzay4l4e3JnYM10WmcxblfQgqkFzS0slGA49GinOxbseLdztkWbR?=
 =?us-ascii?Q?D6rh92rPwS6sBItnxz9IJD47r7LLFpmDAA69tjW2UYdKxOTnbM79rJEqbs6w?=
 =?us-ascii?Q?YW5Z4LWEE21vOWDHsTaCa+IKlHQsyfYMLeTad/5a583jvl9sLoCeUa4gTyb6?=
 =?us-ascii?Q?LQKM6R9UlPOcprTDdxCmnxq9OlLDh0T0MmxqCLqk8ln7D7kW8cjDIdrWn953?=
 =?us-ascii?Q?KbzCJ51R0MKAPItIy1+Jd+0MFK8WBAsm7gB1/w077UqCUkZPV3El7aNvLZv9?=
 =?us-ascii?Q?YvUQaPOtxUoYdWcd6+7S2iSFDsNN3LsGzAq5Ny4v44QUBTYWgy188DwFBH9S?=
 =?us-ascii?Q?+/hh2bJ4KX+dKkXqOwHsutIOptdHXfsFcAtub3QBWEfu7BlN8YErTMnq1CiV?=
 =?us-ascii?Q?xnTIczq4a2sqQU+RWJ/skU62HhL333Yqz1twL1O88ENv8AYBhkFQnWghIxFO?=
 =?us-ascii?Q?lMT7ZHxWIx5U1dGgF4yvA+Nmvs6+n1wRyrcaK9zvtGQkVvQNzRZpGgbHB5kF?=
 =?us-ascii?Q?sUP8N5G1nyJ2V0xICPWUeav4bYUPWAT7Kv8OBr+ttZMCimJK3s82q+RALzix?=
 =?us-ascii?Q?79KEf0sgPK6Y/yJjDwhHNBcD8hn9pSDhiWawk7ho+uYFbtVHwwD+PXHBWnuf?=
 =?us-ascii?Q?0eyq3nEmZzC//O+1Ex5Pi8C6b9wdwKGQrU5X+3qUukWe4e+L4B7R6xDogD+S?=
 =?us-ascii?Q?LJhwhfagnIfcE27Vcvlzu2slR/HjucqP3sVqE+AEkafMkha4XxxXXxcUoX8F?=
 =?us-ascii?Q?m7Zjd6ff4vIjIBx/nFVXiwKLU/1Y810X6tylN+8Gutz/+kbGzgZsSAPK1kHI?=
 =?us-ascii?Q?PNbuQjOkgsOKybY8RPc1GvRpHIU9cZHJntt7VD0wy3zCNrA7NqmljDBLtRA9?=
 =?us-ascii?Q?mAV60yNAZ93TAa3ZcXalq95TRTfaTvzRwaANgeGQikF1hDovZcZcfzpf5tBf?=
 =?us-ascii?Q?b4jb7bIR0Qfa+2XRrvkUNxgMzWGPtNOuISJX1E1xhft7+Cr1i9Ws91nLq63r?=
 =?us-ascii?Q?4ZRxL1ouVoV6YbGpwQrOmDwUNlFUY3qiO7qKAdwe9QHYSrG+aMartiUfxFx+?=
 =?us-ascii?Q?sEcMX2BrXcaOGtH3t17h+H00+lv0CvK5oKW7uyb3Y5icyJEvclB7q+NDVf4m?=
 =?us-ascii?Q?6CNU+Cb9fXUb8NWosUJSLVq72QnjKhhT5xCfJ7NnWE/JfGwY+E5pHM/bgxiq?=
 =?us-ascii?Q?5VMVSz6he82Uo/AuS33Hq3RS9GVneMbT0LvoQecWZpKasEri27X+jvKpAbgl?=
 =?us-ascii?Q?VWe/tDfkbR2NOGQJ0u5S7kUA+aLzsV97JcYl1GK9kbCRhmGVFwtHZvuuxruL?=
 =?us-ascii?Q?io3doY+3Kt4Eh6uRYmfFqPBvrQuTaxf2zveCP616euk4ZLQkKJfR6BUiNvLo?=
 =?us-ascii?Q?43qPSfkIdVX3nVvUd8kt3QNe/lof9TwFd2+n/jCbkXMW2HgCTfQt0u4Q6eGM?=
 =?us-ascii?Q?Jzd4rQ0hRZOqCDSymG0K+kK/8NaLVy8iQvIlM6bWoxchrcbup+IEqopxk4hn?=
 =?us-ascii?Q?kAkxeT4doVBzA3mhjuDYNm9iaNZylrGFmRoeYJy2u/Q0vYxXLToLJF97NLao?=
 =?us-ascii?Q?9Ph8h//J8egy1nKWcW9wj2xWNDgnXHcBNu8HQlV7Cjlx5mwEbOsXIqX70es8?=
 =?us-ascii?Q?ulOJ9jDLn5/SF/2MqrXw5xk/sWUJ9zVrUh03KT0woXVGSvISJYwk2Ojv5bMn?=
 =?us-ascii?Q?drCxzAa4pIEXQvXi9tdYsPhItMTbmXw=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aadff312-bb46-465a-27eb-08da319ad26a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 09:03:45.3899
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: neyKhC/CJnWv/Kwk70yueQsI9/gywRa03MXdFagFDh8svysM2lVgPWXPQmIg6WRyN5h9W1nu7Yj6gcZwO3LJO5p/+o8kfh8e3CrisVDCef8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4542
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-05-09_02:2022-05-09,2022-05-09 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 suspectscore=0 phishscore=0 spamscore=0 bulkscore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2205090051
X-Proofpoint-ORIG-GUID: IlReYy-NMdxDB1E6KTGJVh48mjVlGbZI
X-Proofpoint-GUID: IlReYy-NMdxDB1E6KTGJVh48mjVlGbZI
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The "vcn" variable is a 64 bit.  The "log->clst_per_page" variable is a
u32.  This means that the mask accidentally clears out the high 32 bits
when it was only supposed to clear some low bits.  Fix this by adding a
cast to u64.

Fixes: b46acd6a6a62 ("fs/ntfs3: Add NTFS journal")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Why am I getting new Smatch warnings in old ntfs3 code?  It is a mystery.

 fs/ntfs3/fslog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c
index 915f42cf07bc..0da339fda2f4 100644
--- a/fs/ntfs3/fslog.c
+++ b/fs/ntfs3/fslog.c
@@ -5057,7 +5057,7 @@ int log_replay(struct ntfs_inode *ni, bool *initialized)
 		goto add_allocated_vcns;
 
 	vcn = le64_to_cpu(lrh->target_vcn);
-	vcn &= ~(log->clst_per_page - 1);
+	vcn &= ~(u64)(log->clst_per_page - 1);
 
 add_allocated_vcns:
 	for (i = 0, vcn = le64_to_cpu(lrh->target_vcn),
-- 
2.35.1