Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220505134731.5295-1-jing.xia@unisoc.com> <Yni42sWLMFITtfmz@infradead.org>
In-Reply-To: <Yni42sWLMFITtfmz@infradead.org>
From:   jing xia <jing.xia.mail@gmail.com>
Date:   Mon, 9 May 2022 17:41:20 +0800
Message-ID: <CAN=25QM6Q1gQWzS27pBEpYokTpKXDamOVTrku40yy=YYGt=tTA@mail.gmail.com>
Subject: Re: [PATCH] writeback: Avoid skipping inode writeback
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Jing Xia <jing.xia@unisoc.com>, viro@zeniv.linux.org.uk,
        Jan Kara <jack@suse.cz>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, May 9, 2022 at 2:46 PM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Thu, May 05, 2022 at 09:47:31PM +0800, Jing Xia wrote:
> >       if (!(inode->i_state & I_DIRTY_ALL))
> >               inode_cgwb_move_to_attached(inode, wb);
> > +     else if (!(inode->i_state & I_SYNC_QUEUED) && (inode->i_state & I_DIRTY))
>
> Please turn this into
>
>         else if ((inode->i_state & I_DIRTY) &&
>                  !(inode->i_state & I_SYNC_QUEUED))
>
> to keep it a little more readable.
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Ok. And thanks for the review.