Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <0b9dced9-a080-1b00-3315-5ba22537558f@amd.com>
Date:   Mon, 9 May 2022 15:28:07 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v4 5/7] perf/x86/amd/core: Add PerfMonV2 counter control
Content-Language: en-US
To:     Like Xu <like.xu.linux@gmail.com>, peterz@infradead.org
Cc:     bp@alien8.de, dave.hansen@linux.intel.com, acme@kernel.org,
        mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
        namhyung@kernel.org, jolsa@kernel.org, tglx@linutronix.de,
        mingo@redhat.com, pbonzini@redhat.com, jmattson@google.com,
        eranian@google.com, puwen@hygon.cn, ananth.narayan@amd.com,
        ravi.bangoria@amd.com, santosh.shukla@amd.com,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-perf-users@vger.kernel.org, x86@kernel.org
References: <cover.1651058600.git.sandipan.das@amd.com>
 <5c30d99af03fff90e2fc3165755d18d14bdb229f.1651058600.git.sandipan.das@amd.com>
 <c313e9c9-97eb-8273-5bb7-553692e8e2f5@gmail.com>
From:   Sandipan Das <sandipan.das@amd.com>
In-Reply-To: <c313e9c9-97eb-8273-5bb7-553692e8e2f5@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3lPamdlRnN1azBlVTYxOThUaDc4dU1BeEJYVE5OM2grQXhpOTVNRjAzTFVz?=
 =?utf-8?B?ZmFBSzM5RjVoZUpzVUJBZU9wVFgxd0dDTUlFWTVYRlNxU2wxYVBLSmN5b25W?=
 =?utf-8?B?S1RaOHpuQU5kSTRVWEZqaTNscTdrcUN2WGNwWVk0NThBS2t6Q1BjZkdJenJV?=
 =?utf-8?B?N2c4eExFNDFKMmFXUm5SM0Z2NkpZdlptYnJEYjZCOTV0OHRhNFpLaVpmNjBQ?=
 =?utf-8?B?LzBwL1ByTTl4VVFUdXR1RnAzM2dOeFEva0gxUi9SVDJmZm12b21hWWVFU0pn?=
 =?utf-8?B?YVF6OVZ4MXhGcEFQU21SVEJoYkhFdUhIUzhicVZZcjFXQXFsZVdNQVlZRlp5?=
 =?utf-8?B?MVdNWWF2RkVJQ0J2ZmZzc2pkUzhqMTY0c0NFOVVRVHZ2eXJUdFBqV2c2SHJX?=
 =?utf-8?B?UGxOR2ZZZE5Icy9tK3BpNGZob0VEajlLdzlGd2hyQktYY1dVeTc1TFNxQW1Z?=
 =?utf-8?B?a0J2cUpjMGhuTThPU3lqSm5yMVJUK1RJSDVrNUdsa0JBeWVlUEFQNVcrSENF?=
 =?utf-8?B?TjdUOVZmOGdJTWtpQm9JN2hIaUYwamFJU2tKdDdqbzVaODZ0bVV6VHVqc3p0?=
 =?utf-8?B?eXRCV1V5T0hrUTJDL2h1TGNnRU94bjlKeURualY3bm55UVBranlDVERzL1Vk?=
 =?utf-8?B?TjlYSUozdVFHK2JXUGlBUU9ET3pzTUdNMml4THU3eXplU2pjU3NSa1VCdDVW?=
 =?utf-8?B?TUVlVmE2VGFyU1I1N1VWN2VDT2RUdWJkMjV0bDU0VzBsWEVRYnNaWnNiMjFO?=
 =?utf-8?B?WEtycmJvcVBnd0paU2w2OVgzYW0vaVRQWFFDQ3dzd1pkczEyOEdFNWJVaEpT?=
 =?utf-8?B?anNuWHRsL0JpS1FEY0RidWVwS2FsQ0wrdTV3M2lNSDhlNmlEUGNjZVZHb0lz?=
 =?utf-8?B?TzRWMmVUOFhUTjlCcEE2dzRWZlVQYk5sYnJzWGs3U2ZNSjVQQ21mcDY4bEl0?=
 =?utf-8?B?SjBRVWNMWUlNeldHTytWTmhhMjljQllOZEpHa1FNZ3RrK0lLZDk1Zm9sSTFm?=
 =?utf-8?B?R0NVOXNvSG41TGtLdit2MlhXWXJMT3hYK3VLc0lEMnZrM0ZLZ1gzZGdnSThF?=
 =?utf-8?B?TlhCMFBtd0pkVGdZQ2RoMGV6MEp2QUtDYzROYysyanlTWjdObDY4bzVIdGR0?=
 =?utf-8?B?S1ZMdDVXaGRoWWFqY0hPeXZTRU9VZ0JPRXpyRVViZkNQOUtqcDNXQXhjUUFw?=
 =?utf-8?B?Z3lOUm5CNGR5T09pb0c4bTFMY0JMbFRDQU5iRVYrUGFiSkFwU00zSUxkSTMv?=
 =?utf-8?B?TXhSZ2NFZUc3VVJmb1psSHV0QTZad2wvV1lQNXZjUjZsRnhEb0xpWGk3N3B6?=
 =?utf-8?B?WmlSWHFGU1RGd1ZmVmo1aW1kL212bW5LMmpLSTZ1UUJKaCtXZTZQN3VoN3U1?=
 =?utf-8?B?RzV1RFFjTlMzbHpYY2lQREU4M3djZEZmMjZldGZvdzhVQU1oNW42UnM5Smc4?=
 =?utf-8?B?RmJKSXprUVl3aE5JNGV0OUc3Y3ZOWi9KUXMwZHhpeXhoTnlrY055VmtWcHR3?=
 =?utf-8?B?c2gyK1RMSFQ1M3l5eStZcDIxRU9KRXAwb3hYZU1udDE5Zldxc3M1d3NXdHZV?=
 =?utf-8?B?MEd4cjdiTGdQK2kzeExHU0FtcnEwc1A5UVB1TW9sYk9RMGY4SS9mUEhTbW0y?=
 =?utf-8?B?dEpZRTR5cjROWm9BVnArdFZzT0FadE5hMkJ2K1VzTG9ZM1BrSXp6QTJRN0th?=
 =?utf-8?B?NGpCNHlRTSs0T2FkNVlrRHR2YUFHTXd0MEVBUkFSOTJWRU04MHNZcER3UTRH?=
 =?utf-8?B?bGxMNFZHMkpJUFgrblRPaS9pZ0E1YVhQNW0wMHdWUXpPQUY2Q01XNGRNbTJW?=
 =?utf-8?B?MnJFUFVIU1FicE5KV1VpTFdTMkJHWUNDQzJzQ05EdzIxRUR4RWNTWGVCVWlp?=
 =?utf-8?B?WmJhYmxuWTFIR21pKy96SW8wbWc2YXpWekZFNG83Vi9KbUpiUU51NXJRSHhQ?=
 =?utf-8?B?ZmVXNHFSczZ5Z3ZDYm91MnBmdWI3eEE0ZllZeldQaEdkN0E5Qi9pTHBMdXJ4?=
 =?utf-8?B?TFllend1QjIzY2pqVjV4ZEZVRVZCWGJNMklLTG9sL3l1TWprKzBtR1JXVDNy?=
 =?utf-8?B?YTVEb09yVFk0Q2hLaWJXZ1dwQmVLeWlBLzlhdEN2bXRhT3NURG5obWdFTFo0?=
 =?utf-8?B?MVBvR1drdEw3T1Z4ekxpWTF4QXp5RHhyNk5GOGlvbm9udCsvSzBxQ3g5cGJR?=
 =?utf-8?B?VFg2bVMvb0ZsbDQzc2toSEFxQlRNL2NTTGFSR3ZlZGZvRWQ4UUt2di83eXVi?=
 =?utf-8?B?eGl5cWlPVG5hVlpxZnRiNU9CMmdpYkx2Y0NiUSt4Vm5YVlNPeE5YeDNJNFNu?=
 =?utf-8?B?eHJpZDc1SUFZOFRVQU1ETmZ3dCtxMkd3WlB1anlMK21aZFFqSGdKUT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9940dcb-15d2-40cb-619b-08da31a274a5
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5712.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 09:58:24.3597
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6X+oNA4XwNLo79dXspr6U/RYmI5dB71wW4RXH3ioNi4WYgHeUoQ6UkjCsja0yT9ZCONAB7uprcRJn+Tz1VP3HA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5370
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/9/2022 12:35 PM, Like Xu wrote:
> On 27/4/2022 7:31 pm, Sandipan Das wrote:
> 
>>   static void amd_pmu_add_event(struct perf_event *event)
>>   {
>>       if (needs_branch_stack(event))
>> @@ -1216,6 +1251,11 @@ static int __init amd_core_pmu_init(void)
>>           x86_pmu.num_counters = ebx.split.num_core_pmc;
>>             amd_pmu_global_cntr_mask = (1ULL << x86_pmu.num_counters) - 1;
>> +
>> +        /* Update PMC handling functions */
>> +        x86_pmu.enable_all = amd_pmu_v2_enable_all;
>> +        x86_pmu.disable_all = amd_pmu_v2_disable_all;
>> +        x86_pmu.enable = amd_pmu_v2_enable_event;
>>       }
> 
> Considering the below part of code also run on the PerfMonV2 host
> 
> whatever the guest PMU version, how about updating these two use cases as well in this patch ?
> 
> diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
> index 262e39a85031..2f7c62e46314 100644
> --- a/arch/x86/events/amd/core.c
> +++ b/arch/x86/events/amd/core.c
> @@ -1469,8 +1469,8 @@ void amd_pmu_enable_virt(void)
>         cpuc->perf_ctr_virt_mask = 0;
> 
>         /* Reload all events */
> -       amd_pmu_disable_all();
> -       x86_pmu_enable_all(0);
> +       amd_pmu.disable_all();
> +       amd_pmu.enable_all(0);
>  }
>  EXPORT_SYMBOL_GPL(amd_pmu_enable_virt);
> 
> @@ -1487,7 +1487,7 @@ void amd_pmu_disable_virt(void)
>         cpuc->perf_ctr_virt_mask = AMD64_EVENTSEL_HOSTONLY;
> 
>         /* Reload all events */
> -       amd_pmu_disable_all();
> -       x86_pmu_enable_all(0);
> +       amd_pmu.disable_all();
> +       amd_pmu.enable_all(0);
>  }
>  EXPORT_SYMBOL_GPL(amd_pmu_disable_virt);
> 

Good point. I had made these changes as a part of the guest PerfMonV2
enablement.


Peter,

Since these patches are now in perf/core, should I send out a separate
fix for this?


- Sandipan