Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <aecc866c-685b-8def-a197-d1246070aa54@wolfvision.net>
Date:   Mon, 9 May 2022 11:49:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2] arm64: dts: rockchip: enable otg/drd operation of
 usb_host0_xhci in rk3568
Content-Language: en-US
To:     Peter Geis <pgwipeout@gmail.com>
Cc:     devicetree <devicetree@vger.kernel.org>,
        arm-mail-list <linux-arm-kernel@lists.infradead.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Heiko Stuebner <heiko@sntech.de>,
        Liang Chen <cl@rock-chips.com>,
        Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
        Frank Wunderlich <frank-w@public-files.de>
References: <20220502064551.202613-1-michael.riesch@wolfvision.net>
 <CAMdYzYrChKVwuGj=VEc=T4Gez-Bs647GxaeMsdbgvU_6p3FeEg@mail.gmail.com>
From:   Michael Riesch <michael.riesch@wolfvision.net>
In-Reply-To: <CAMdYzYrChKVwuGj=VEc=T4Gez-Bs647GxaeMsdbgvU_6p3FeEg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2lhRnM5UFdRZnVxZVhvRGs4TWF4NTB0ZkdOU2o0RFl1cUpieDNhaDNHbVRw?=
 =?utf-8?B?YWZZaUtGbUQ1c2NWRklwb0NKeExHd2kvK0hCdytJS29hbk9udWdkVEFnL3RQ?=
 =?utf-8?B?aUhJbHNYQWZzbVE5SHNPVEZCd1YrVDdQT203MUprY1NScWd6TllUU2hVcS9l?=
 =?utf-8?B?TzlWQXBXRnM2MExHei9nTElsbVVjS2JjMkpSV1IxbFN6WExuU0RTekd0aUNU?=
 =?utf-8?B?SmF4ZTBVWDB5TjRuRTJOWmhXdWZ0WlNPUTBaem9pRklNd0E2V0N5cU43b3Fs?=
 =?utf-8?B?UEdEVGQ4OTFsaGVyQkVPS0QxcU9TTEkyODBWWUpOYVdvaU1OK3dBUTFWanI0?=
 =?utf-8?B?dGtkeDlsdEdtT25xK0NLbVFUYU1FZzZ1SjhYY2JZWFRHcVZwYXhHbDliQTBK?=
 =?utf-8?B?dkd3YTIxSXA3ZWFYZ1lQWkhwZjIzdkdpa2hkOTdPUTRGTC9wWHlFb0VVZmY4?=
 =?utf-8?B?ZHJhZVp4QXpUM1FBcFJCbWJkMmpHeG1lWFk5M3FqaUxpbVRwdisxQnB5SUtX?=
 =?utf-8?B?azJ6RXh0MkNvYlhTWSt1TlpUSTNjbVBESHdnejhQMnVtMnB5QlQ1eHpoZmo0?=
 =?utf-8?B?UFFaNk1xL2FFZkRmNUN2MFFTSXBHcjhCU0F5ek11TmVicFVBWTJPVWZiU1JB?=
 =?utf-8?B?bVBIY1Q4NEtGb092YTNpVXJnVktQT3creFJ2bE51VjJMYjBLZmQ2TDVudkFP?=
 =?utf-8?B?SkZxSUlmeW51RkZqYm9SeXViMUtyYWcydzFabTJVS09NLzEwUlRVZlNwNkhq?=
 =?utf-8?B?cEJCVmNUMWtzSWk2akU2QWwxQlF3c3czTGZHcDM0ZTVDbHIrbHJFOHY0WGJq?=
 =?utf-8?B?c1FJQW9HMzFXNllyOFNSSElXQnB3WFMzVW5xME8vMHg2dXljUnRySUV0V2xP?=
 =?utf-8?B?OUFxYVFVRThQNGxXU0h2L0tiZGZFdWN2ZXQzYjE5NVJnTldKZTdLVUoxK1hR?=
 =?utf-8?B?U3hBWEZ2ZlVqeG1hVk9pOTlIQnNwYzBWZm1CTnpuU0l0SVJzRTYzMEFpdkRs?=
 =?utf-8?B?bHprV0pCdkN2cHk1Z3diNURjb3V2RGtjZHRTZTZ3ejU2YVh5eVI2L3pnMysv?=
 =?utf-8?B?UmFhOVJkQWQwaGp6WFVqMUtRZ09hZFlXbXY5dHFJUG1Ta09RczRlcDlGaUNl?=
 =?utf-8?B?QlBwOHpVSW5hS1R6NjBiNnhxYlNXV0dGdXo0OTdScENjbmE0ZnBBSEFGK0hx?=
 =?utf-8?B?VjVXY1M0Y3lxZFVwRFBCUEsxL0xqbUpKbEdrdEgrdHB0d1ZMTU5wTkVMeHMx?=
 =?utf-8?B?Qmp2Y3B2K1JaRkhZdWxVMFpGa3VIeVRtOXBTd3lxeUZxb2c4WlR2YkRqejFp?=
 =?utf-8?B?MTB5KytEUjZrb1g4VEtJZjhDdWRRSGxQbEh0Y0FSTXNOOCtZQ3M3SWpaeU9E?=
 =?utf-8?B?UFpYb1RCTjdiUk5LZnV6am1iSXQ0YzJuK0owK0pQVkYwWnZlL2RRWDZMMGt0?=
 =?utf-8?B?OU5sTFdLeEdPYTZEbEZnWXRiQjVKVXhlNWswTjhHZW9TNkFETkJpbmUxVFl3?=
 =?utf-8?B?VUZrRXk2Z1cxOGkxbzRWcW5vZnpzTFlyQVFneGM3UGFRaVhlbnpTWlExZG5n?=
 =?utf-8?B?RElYc3JTTlZuZUJTMkNaN0dSSk5jSVNVcHBBMWdkRXgwZTZTZnF6QjdXR2x3?=
 =?utf-8?B?T05xY1Y2eFlrRmdqa2FyQWdiZXAvekVyQWdZcFBlbTVMdFJ1V0xPWnRmNmky?=
 =?utf-8?B?VUVjQVQ3M09aTEk0bHgxTkVKaVlxVmx0d3ZONGVWaVdPeFVEU1VUb3FIVjB3?=
 =?utf-8?B?c0I4RVNrZUVSR01aVk5yQk8zV1lwbEYvSWdERDVrcy9zNzhUV3N1YWdEUEtE?=
 =?utf-8?B?VU4zWXNkTGRITkNxcTFicEFVWXI2QkJ3alhGaTRMMkVWbVZMcnRkR3dnWStm?=
 =?utf-8?B?R2MrOFMrMTVLVXZMMm1vOWFnY1RhNytIeDJUNjhwVG5uajlXd2lJYThkUCt0?=
 =?utf-8?B?NDhJaGdZbEhqV3JpZGplU1IzRVBySGoxaTFtNHl0NmJhMjJWWVpRRlpTZ3F5?=
 =?utf-8?B?ZnMrN1F0Q1pTYUhqanAvSUZ6dHJYNjFQaXA2QlNqV1k1RC85NmR4L04rVm1h?=
 =?utf-8?B?alM2V2I3QUxYL2I5OUhRK2FYRFJkcXNzQ3JsTlJtYktnTzA2cU9sN1Z3UEJQ?=
 =?utf-8?B?RUR1MWlKRnNaUzZiT0ZxTkFBTzVQWHRFNS9MNkZuNk1hZzllVGZ2SWU3emI5?=
 =?utf-8?B?NTdLSGpxcit5OFFpelZaZTJPSTVPcmVmMmQvWHhQSjZRRGxTVHdsZWFBNnpK?=
 =?utf-8?B?QlZQVDhGbFE3MVZjYUJadWNORG5uUnBWeitDc0hLSGJEL1EzYU1NbHBUbG5m?=
 =?utf-8?B?RllONFplemxsWHRRL0dvZitZbUNLU01tU1hjZitUMkt1M21PdkFOaHlOS2U4?=
 =?utf-8?Q?MA+1vgO0ay2g0bxRGPRTdLo9TtZh+ZL4lxMnjgjEdGszb?=
X-MS-Exchange-AntiSpam-MessageData-1: i7jmXHfOwptdShIRVb09G/+icEZlmHAazizBQ4fbXyqFbQx6MQqjnZdf
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d3285f8-b303-44a4-9c61-08da31a12aa9
X-MS-Exchange-CrossTenant-AuthSource: DBBPR08MB4348.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 09:49:10.3631
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dq3ggTC7gaTvTv8U4N4/VEFxt33Tyk3qq4K8USbv8AAl8v8J6f1z8RhUIsyEEOgDxpDXPEqeWTN2Hv2k6WSsFg57bRmVV00DTuZMEcXzOhQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3423
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Peter,

On 5/2/22 11:54, Peter Geis wrote:
> On Mon, May 2, 2022 at 2:46 AM Michael Riesch
> <michael.riesch@wolfvision.net> wrote:
>>
>> This USB 3.0 controller of the Rockchip RK3568 is capable of OTG/DRD
>> operation. Enable it in the device tree.
> 
> I think I missed a conversation here, the xhci0 controller is the otg
> port for both rk3566 and rk3568. The only difference is on rk3566 it
> is a usb2 only controller, where on rk3568 it is also a usb3
> controller. It was set to host only because my original phy patches
> didn't support otg mode. Since then Samuel's series fixed that.
> 
> Your original patch was correct.

I have already replied to v1, but at this point I would like to
 - thank you for pointing this out
 - and send a friendly reminder to Heiko: please apply v1 of this
   patch :-)

Thanks and best regards,
Michael

> 
> Always,
> Peter
> 
>>
>> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
>> ---
>> v2:
>>  - As pointed out by Nicolas, this is RK3568 specific. Moved change to
>>    rk3568.dtsi.
>>
>>  arch/arm64/boot/dts/rockchip/rk3568.dtsi | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
>> index 5eafddf62edc..bbfe8f3d68b7 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
>> @@ -134,6 +134,7 @@ power-domain@RK3568_PD_PIPE {
>>  };
>>
>>  &usb_host0_xhci {
>> +       dr_mode = "otg";
>>         phys = <&usb2phy0_otg>, <&combphy0 PHY_TYPE_USB3>;
>>         phy-names = "usb2-phy", "usb3-phy";
>>  };
>> --
>> 2.30.2