Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4879413iob; Mon, 9 May 2022 03:56:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9Y0RUw7OxKuUBwgyRMtuCN+KVzZfg1wnkyAK7vTW1wSErDsTmAE95m7b664m+LrzarwQA X-Received: by 2002:aa7:8142:0:b0:50a:b78f:bee9 with SMTP id d2-20020aa78142000000b0050ab78fbee9mr15626027pfn.68.1652093784299; Mon, 09 May 2022 03:56:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652093784; cv=none; d=google.com; s=arc-20160816; b=tfYmvtGdsshOkwVE4Awv40nYH2xx/Um1vmA08KhNctjrnlHVIZ0ueXyk4qlvetiUaO PGqFDX1BzoxI1I6RFoXcFCVzrUEQlNljHOL3xCeitKogDW5KEMTGtWtfe3dvZnNRAef9 vUN8rUXHaheMR3JjLELL8s/1tQpIioKObHeM9227KJ+Y3Rg2MB6tImQGpgT4rCW/NNtY 0sYigJ0b6JtCz2SHUymrFxElReFotNWpEar5ERgAYyPXXlSzRcOTvqXCNsYERLOWWmGt rDkEVe9QYhOTeyfM8eBcFC1e3g0dUekEF5r1Qp2pM/yqTm1/mlmSnBF1F0lN7i9+f5PN TC/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=adl/aVshHw/nrnPfoOISDZzueA7l2QJvw8SZ03J5eNg=; b=wG0HXqlbDc/zw7Jk0O8a+LqJ5RSbjzBtPx7aEOfPFQpP9I2ZVpY8v/Fb28l7rtnIn+ VMAqWFuqoEbjItFnX+6wNYtrIHieBADqshwPyC4ld7EctOFLGcw6yQMy0+5Zl1Du6EX1 hxXWNX+VOjtpiebzd3SKfWn6b6UEznCcw+NW4qtBVsTAwBVFvHA83xUE4E8xGGsLDoEB Wdlu3An7AAvoJclB2Ei2BnIMNZvVW8y/Fef7tyaa8XdSRHE8YRhjkB0UWIYEwG57rhRL g6msJjrAJdHmXKnqm5mEDcXIAAMpxCpqacyPj9FXcVHW5lFF6vmmNwP2VdbbZh4MHVIY LOUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=end9uHtj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id h1-20020a17090aa88100b001dc54892bcbsi13575960pjq.147.2022.05.09.03.56.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 03:56:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=end9uHtj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B3CB31666B1; Mon, 9 May 2022 03:12:52 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234268AbiEIKMv (ORCPT + 99 others); Mon, 9 May 2022 06:12:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233003AbiEIKMh (ORCPT ); Mon, 9 May 2022 06:12:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C190233A7D; Mon, 9 May 2022 03:08:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4D74460AB0; Mon, 9 May 2022 10:06:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 426A8C385AF; Mon, 9 May 2022 10:06:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652090770; bh=PCf4krPgNa/IY5fUBgJeLAYCiLEpbimXw3qnMtZQu1c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=end9uHtjBKgnQjOzr66HnJAxoQH7YXKeGFoMz2wzMasIPSaR1FDipiGbJ91A/nlX+ /9YWfA12nv+WVYFRMAJrbiB9saz0xMr50vPtC28y3dql+66du+SMpWpk5tIOjb9leM 3CHXjZE6UJJipB7bVsPViTJa1XuEtedP8uFfbAm1TSLtQ6Bbn4Vo1gFY2ifZcaHu+l kYE1gtXlTZfIk58uEuEfpBWKXAfA77yXefIQhz5bFw5O6YjF/ABiGqEBnldzCaGd5k o6aqp1yMKHHSemu4TzjLwMGsPzd4+fCGNITHDxT77pEYmPkmaiN25Hlrht1/GVahBK 3C6Oq+Vh9NP4A== Date: Mon, 9 May 2022 12:06:04 +0200 From: Christian Brauner To: Carlos Llamas Cc: Greg Kroah-Hartman , Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , Todd Kjos , Martijn Coenen , Suren Baghdasaryan , Joel Fernandes , Hridya Valsaraju , kernel-team@android.com, linux-kernel@vger.kernel.org, Shuah Khan , Arnd Bergmann , Li Li , Masahiro Yamada , linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 1/5] binder: add failed transaction logging info Message-ID: <20220509100604.wswe2xvju2cpwvbn@wittgenstein> References: <20220429235644.697372-1-cmllamas@google.com> <20220429235644.697372-2-cmllamas@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220429235644.697372-2-cmllamas@google.com> X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 29, 2022 at 11:56:40PM +0000, Carlos Llamas wrote: > Make sure we log relevant information about failed transactions such as > the target proc/thread, call type and transaction id. These details are > particularly important when debugging userspace issues. > > Signed-off-by: Carlos Llamas > --- Looks good to me, Acked-by: Christian Brauner (Microsoft)