Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp4892059iob; Mon, 9 May 2022 04:14:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw6TpvPbTzOfeoRDtZz82AAGLG7cGY9DofLP8SIgN2xOOZ6JhcamdjBvzf0lr0HmwySmgFj X-Received: by 2002:a65:6b8e:0:b0:39d:6760:1cd5 with SMTP id d14-20020a656b8e000000b0039d67601cd5mr12930974pgw.379.1652094849533; Mon, 09 May 2022 04:14:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652094849; cv=none; d=google.com; s=arc-20160816; b=0NNKb8BRZTv8je5t+79TBW2xWnymddbFmrQ5cJztkA/5JDSy2cUTsWQmJOCEIlo3PX Atm9nBUJEo7nD7Df3xkFnE52PXOV+eJcEt+etdPnsu462Wu4ShF1V9nal17BPbFigPZ1 OMMGI3pfc2izFel8gvUcGw0c8+k2AhsQp+uDwZ79KZ/SWwrUQqLTkTmcFrUyPFlS7+Jb cwbeJJz29uMqe9FAbXe6G99pRTAhGFx6uDxcnh+T/VBe47MYQAM0cZpoeEWgYz84qdQQ Vl8KJvFnrC67OUGyzinuOVYX8+WvZSQzv9Crc//Vv0O61Fsw0KSV0DJ9KvK/z5zGYn6+ u/Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Ty1AgeIKh2EYFgs2k2ZbylGJHiYAUJfCHKZ+rmSmMaQ=; b=Te/hCbbo3zb7aSd7FAjBAp6FTb+8GR3NmB0vqtAYzUhRtJKX0XJKxww4VD/mIJxupp 77RLEQB+xXtFHRXVg+7pQPHyoLTuu0Te7gOjAlwRFFXjBZ8ttwGOe9H5JhsjzKD0rmgp r3YjQYQGzUCNbsVNdmjxMW19hq2CN4CPl+dXyMqihS2U5iML+LejPdS15yEaQCY3Iu5F E4xlSYP/eQji0jSrRlBnry+VatcXmamnPJzGsXs+06haCNsEh6mGYx/36KPTJiNthGHZ 5CBBx6pJsyNplQQCwoPYzcUdFEpXJJYhN64k2gKkK1dwqPt6tiLnklHstgfyHMdrbpb7 f1nA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=RoAnqLNl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id f3-20020a056a00238300b0050a49c21b85si15786741pfc.50.2022.05.09.04.14.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 04:14:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=RoAnqLNl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6504928ED33; Mon, 9 May 2022 03:25:29 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236116AbiEIH0A (ORCPT + 99 others); Mon, 9 May 2022 03:26:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233583AbiEIHXj (ORCPT ); Mon, 9 May 2022 03:23:39 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F14C12FEC3 for ; Mon, 9 May 2022 00:19:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Ty1AgeIKh2EYFgs2k2ZbylGJHiYAUJfCHKZ+rmSmMaQ=; b=RoAnqLNllKj1hmkegOm01Xrm+D Cz0Tx3zj9aXC2bt73QRpqQYKllmFeswOUAvhK1nxKrs+IgAKwTfx+2dUKy1M0VPPsLfFeClcMayiZ C1ZNRWpY/BpppfQ93+0f9aQ4oSMXHAH8GQZzYcvXko90t8A9EI9jKAIhzXqhfXYI5AkuO4vLo9nhv SmSnnmoEF6Llw8DtgVnwb8sJjhFM54P9/lfGkqF1qfQDcKXSfOE95/VxDY3xrUeKNcFroU2fjVOQb xCtJv8/ws76Ez9CtCEirvWoSjtwUmjT8oIs6a3GxmL14Z2SGfXy8DN9qa71hMYS7/SRTsmwFt1lBg ohsuZp1A==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnxfx-003E3h-2F; Mon, 09 May 2022 07:19:25 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 391D9980E93; Mon, 9 May 2022 09:19:24 +0200 (CEST) Date: Mon, 9 May 2022 09:19:24 +0200 From: Peter Zijlstra To: Li kunyu Cc: dave.hansen@linux.intel.com, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: Functions may simplify the use of return values Message-ID: <20220509071924.GF76023@worktop.programming.kicks-ass.net> References: <20220507150630.90399-1-kunyu@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220507150630.90399-1-kunyu@nfschina.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 07, 2022 at 11:06:30PM +0800, Li kunyu wrote: > p4d_clear_huge may be optimized for void return type and function usage. > vunmap_p4d_range function saves a few steps here. This makes it different from all the other p??_clear_huge() functions, which seems like an exceedingly bad idea.