Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 09 May 2022 10:43:07 +0200
Message-ID: <s5hh75zm6zo.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Colin Ian King <colin.i.king@gmail.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hdsp: remove redundant assignment to pointer kctl
In-Reply-To: <20220508212819.59188-1-colin.i.king@gmail.com>
References: <20220508212819.59188-1-colin.i.king@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sun, 08 May 2022 23:28:19 +0200,
Colin Ian King wrote:
> 
> Pointer kctl is being assigned a value that is not being read, buf
> is being re-assigned later. The assignment is redundant and can be
> removed.
> 
> Cleans up clang scan build warning:
> sound/pci/rme9652/hdsp.c:3317:28: warning: Although the value stored
> to 'kctl' is used in the enclosing expression, the value is never
> actually read from 'kctl' [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Thanks, applied.


Takashi