Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220508130944.17860-1-vdronoff@gmail.com> <3f16033ef08063ef9fcb707010e78bd0@linux.ibm.com>
In-Reply-To: <3f16033ef08063ef9fcb707010e78bd0@linux.ibm.com>
From:   Vlad Dronov <vdronov@redhat.com>
Date:   Mon, 9 May 2022 12:17:04 +0200
Message-ID: <CAMusb+Q11JMyOXV0iy4VLJ8yST7L0QrmDUJWOpnvsBxfBzjrdA@mail.gmail.com>
Subject: Re: [PATCH] s390/crypto: add crypto library interface for ChaCha20
To:     freude@linux.ibm.com
Cc:     Patrick Steuer <patrick.steuer@de.ibm.com>,
        Harald Freudenberger <freude@de.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        linux-crypto@vger.kernel.org, linux-s390@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi, Harald,

Thank you for your response, review and an ACK. Let me ask Herbert if
he would agree
to add your Reviewed-by and submit (so I do not send v2 just for this).

Best regards,
Vladis


On Mon, May 9, 2022 at 12:10 PM Harald Freudenberger
<freude@linux.ibm.com> wrote:
>
> On 2022-05-08 15:09, Vladis Dronov wrote:
> > From: Vladis Dronov <vdronov@redhat.com>
> >
> > Implement a crypto library interface for the s390-native ChaCha20
> > cipher
> > algorithm. This allows us to stop to select CRYPTO_CHACHA20 and instead
> > select CRYPTO_ARCH_HAVE_LIB_CHACHA. This allows BIG_KEYS=y not to build
> > a whole ChaCha20 crypto infrastructure as a built-in, but build a
> > smaller
> > CRYPTO_LIB_CHACHA instead.
> >
> > Make CRYPTO_CHACHA_S390 config entry to look like similar ones on other
> > architectures. Remove CRYPTO_ALGAPI select as anyway it is selected by
> > CRYPTO_SKCIPHER.
> >
> > Add a new test module and a test script for ChaCha20 cipher and its
> > interfaces. Here are test results on an idle z15 machine:
> >
> > ...skip...
>
> Hello Vladis
> Thanks for your work. Please add my
> Reviewed-by: Harald Freudenberger <freude@linux.ibm.com>
>
> however, always the question who will pick and forward this patch ?
> To me this looks like most parts are common so I would suggest that
> Herbert Xu  will pick this patch.
>