Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <b42bc4d1-cc9d-d115-c981-aaa053bdc59f@kernel.org>
Date:   Mon, 9 May 2022 13:13:19 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH 2/3] tty: n_gsm: fix mux activation issues in gsm_config()
Content-Language: en-US
To:     "Starke, Daniel" <daniel.starke@siemens.com>,
        "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <DB9PR10MB588149B7E9A31D3476762776E0C69@DB9PR10MB5881.EURPRD10.PROD.OUTLOOK.COM>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <DB9PR10MB588149B7E9A31D3476762776E0C69@DB9PR10MB5881.EURPRD10.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 09. 05. 22, 13:03, Starke, Daniel wrote:
>>>    static int gsm_config(struct gsm_mux *gsm, struct gsm_config *c)
>>>    {
>>> +	int ret = 0;
>>
>> Why is the initialization needed? You can as well declare the variable only inside the if below.
> 
> You are right, this was unneeded. But this patch was already included in
> the tty-linus branch. Shall I resubmit it nevertheless?

In that case, you can only send a fixup patch...

thanks,
-- 
js
suse labs