Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 9 May 2022 15:11:49 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Sandipan Das <sandipan.das@amd.com>
Cc:     Like Xu <like.xu.linux@gmail.com>, bp@alien8.de,
        dave.hansen@linux.intel.com, acme@kernel.org, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, namhyung@kernel.org,
        jolsa@kernel.org, tglx@linutronix.de, mingo@redhat.com,
        pbonzini@redhat.com, jmattson@google.com, eranian@google.com,
        puwen@hygon.cn, ananth.narayan@amd.com, ravi.bangoria@amd.com,
        santosh.shukla@amd.com,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-perf-users@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v4 3/7] perf/x86/amd/core: Detect PerfMonV2 support
Message-ID: <YnkTFRNpCykEndsk@hirez.programming.kicks-ass.net>
References: <cover.1651058600.git.sandipan.das@amd.com>
 <8d3e23760726cf6647a98999e1fcd12a37f36a42.1651058600.git.sandipan.das@amd.com>
 <78e001bd-42bd-5481-5a19-1a0bcca9a63c@gmail.com>
 <96e41431-eb80-f61d-9ab9-c76cd9b6086a@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <96e41431-eb80-f61d-9ab9-c76cd9b6086a@amd.com>
Precedence: bulk

On Mon, May 09, 2022 at 06:38:19PM +0530, Sandipan Das wrote:
> 
> On 5/9/2022 6:31 PM, Like Xu wrote:
> > On 27/4/2022 7:31 pm, Sandipan Das wrote:
> > 
> >> ????? x86_pmu.num_counters??? = AMD64_NUM_COUNTERS_CORE;
> > 
> > Thus boot_cpu_has(X86_FEATURE_PERFCTR_CORE) is true.
> > 
> >> +
> >> +??? /* Check for Performance Monitoring v2 support */
> >> +??? if (boot_cpu_has(X86_FEATURE_PERFMON_V2)) {
> >> +??????? /* Update PMU version for later usage */
> >> +??????? x86_pmu.version = 2;
> > 
> > Is it safe to assume that once AMD CPU has the PERFMON_V2 (or further) bit,
> > 
> > it must also have the PERFCTR_CORE bit set ?
> > 
> 
> Yes, always. There won't be a case where PERFCTR_CORE is absent
> but PERFMON_V2 is present.

Let me introduce you to this dodgy virt stuff :-) Best put a sanity
check on it.