Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 9 May 2022 15:22:05 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Guo Zhengkui <guozhengkui@vivo.com>
Cc:     Conor Culhane <conor.culhane@silvaco.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
        zhengkui_guo@outlook.com
Subject: Re: [PATCH] i3c: master: svc: fix returnvar.cocci warning
Message-ID: <20220509152205.5e6432e1@xps13>
In-Reply-To: <20220504164901.9622-1-guozhengkui@vivo.com>
References: <20220504164901.9622-1-guozhengkui@vivo.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

guozhengkui@vivo.com wrote on Thu,  5 May 2022 00:49:01 +0800:

> Fix the following coccicheck warning:
>=20
> drivers/i3c/master/svc-i3c-master.c:1600:5-8:
> Unneeded variable: "ret". Return "0" on line 1605.
>=20
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
> ---
>  drivers/i3c/master/svc-i3c-master.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc=
-i3c-master.c
> index 7550dad64ecf..d6e9ed74cdcf 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -1597,12 +1597,11 @@ static int __maybe_unused svc_i3c_runtime_suspend=
(struct device *dev)
>  static int __maybe_unused svc_i3c_runtime_resume(struct device *dev)
>  {
>  	struct svc_i3c_master *master =3D dev_get_drvdata(dev);
> -	int ret =3D 0;
> =20
>  	pinctrl_pm_select_default_state(dev);
>  	svc_i3c_master_prepare_clks(master);
> =20
> -	return ret;
> +	return 0;
>  }
> =20
>  static const struct dev_pm_ops svc_i3c_pm_ops =3D {

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miqu=C3=A8l