Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <e7f692a5-a88b-9094-12da-0cf29b880527@amd.com>
Date:   Mon, 9 May 2022 15:40:00 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v4 11/15] KVM: SVM: Do not throw warning when calling
 avic_vcpu_load on a running vcpu
Content-Language: en-US
To:     Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc:     pbonzini@redhat.com, mlevitsk@redhat.com, seanjc@google.com,
        joro@8bytes.org, jon.grimm@amd.com, wei.huang2@amd.com,
        terry.bowman@amd.com
References: <20220508023930.12881-1-suravee.suthikulpanit@amd.com>
 <20220508023930.12881-12-suravee.suthikulpanit@amd.com>
From:   "Gupta, Pankaj" <pankaj.gupta@amd.com>
In-Reply-To: <20220508023930.12881-12-suravee.suthikulpanit@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFRTcll0Ynpia0dHOHVvazZhQnJLakc2QkpVYVo2ajRWYStJakNEbGdMMWZL?=
 =?utf-8?B?U0xycE9ZNExiZHRralQ3VHpxVmZRL0hCVGVNTituMjl2eVNQSnpucjlPL2N2?=
 =?utf-8?B?QUZHdXBLUXBBajc4eDdML3dQWUNLOWdoanpLYU9KZENpT1Z0OU8rcWZzMmhy?=
 =?utf-8?B?K0U1VDJIR1dFM1NXSVdYL2tyZUgzdXo3TTMzQmpuY2JVSkZWWC9tVk1XMU5j?=
 =?utf-8?B?dHllZ0plbDhYK3VBY3VldUpxdy9iZXJvY2tQOWk5eDBnVWptd3BiTm0xUFNq?=
 =?utf-8?B?UVFQWm1pV0tPYjcxbnhJZlE4ZmFZZXE4aHNZQ0lEQWUyRDRlS2dRVlZvWC9L?=
 =?utf-8?B?YU5zclFxRHcyc0ZMUjAxbWlyME53aGRhcXErMW85WWU3ejR2Ry9MVXJuZGRt?=
 =?utf-8?B?VHJxN2JnTnhDcnJFcnRobm9QN0FKY0hITk4rNU1PdUNNTXVTWW1tSkJMVGlB?=
 =?utf-8?B?bHJyK3RvUDNLdUhzNUc4T0kydTRWZ3lGWVdmeElVMVVQbmRhUS9rSjFMMDBB?=
 =?utf-8?B?M05WTzl5N0xhYXNSVTFPaGpKbDhiRUdGck5FZFc4Ly91R3R5UnNSekRqTFdm?=
 =?utf-8?B?eXk0QW1SYUtXdVpXSjVXdWpvZXZMQ0IvbDJJYlZxRFNmVFlrVy9FRHJxNjRH?=
 =?utf-8?B?aTZEN1JxK3QrdXdOWS9zRW1nV2o3TjFud0F0NUtwRU5SY3JhQk90c3JKT1FR?=
 =?utf-8?B?bGhMZU5Cd3ZyUDB4ZmF1anU5aDJOZ2tVTjRKUlFtTU5USjl4OUF5QVJYV1Ja?=
 =?utf-8?B?SEZ4YXBja3NWZFlTd0lKd1ZXeGkvL0k2WVdzTUhza1JYNjhPdjNObzB1VGg0?=
 =?utf-8?B?dEw0SkdtK2NwUXQ0d1NnYmlHZDU2MENVdDE3a05tWEVkYzA1VjRIMmFFU3pU?=
 =?utf-8?B?WjRhSGNHN1FLUTYvaGQwWWs3cWJkaEs1YWJPdDB6VDE2NFJFNGFqZnF3MGlO?=
 =?utf-8?B?SThRNUpzci85MzRFOUpHb0wvZnZHM3dTMDAyNnh4eFNwK2E5d2ZJSHQrTUVv?=
 =?utf-8?B?dlZFZ3VGZnlSQkJqWXdaTmV0TFJXUVBIejBTR05xdU1DNHdWUzJlbXNSRXpW?=
 =?utf-8?B?d25COERURTYvQjNjU3FWMXJSdk5xM3ZIYTZlQ3Q0VTJ5ZE9zb0lYaU1Yc05L?=
 =?utf-8?B?SjhkVlJqN0o1S0RoWnUvR0NaTTNyTGR6ZFFSL2ZsNTVLTDZXeU1aVmdwdTlw?=
 =?utf-8?B?UUk3VTdpeVE0VmphRVEwOXpCS2JXZysyZVJXY2hBWE53dmhHRHdwM0Z0a3Q0?=
 =?utf-8?B?bTZwS3VlbldIWGYxWTdLVmJMYnRYOVVTenUxejJIS3YrZWNZY0tONGdTaXdT?=
 =?utf-8?B?NjN2dkVQdCtZeXF5aExwR3MzZ3hWeHRQN0licTc2WUZCcEV1bnIrOVFSTHRD?=
 =?utf-8?B?OWRpSVJzOVhzMjYyT0lxS3pUUmdXekkxQ3lBamhMVjYyT0pKWjRtbVJBUUEr?=
 =?utf-8?B?cVpQMU9haFVUZzhxTDRLaHBNa2tBc3hiTlNSQjQ4MllvME1JUDlQWFJTN00y?=
 =?utf-8?B?RDdORVNsSzdQbEZQVWFsU2JzNHNMOEh6djFPTTJUWElicURvcmhYMUlPaWlL?=
 =?utf-8?B?UFVsZ3JRYncreHZ4VFZCQ0VQL0cvWDI4THJLelhqYlJRZjVsSVM4aXQrSXZE?=
 =?utf-8?B?Z1RtM3lrMW9jTmFwdnk3SE0zZndtWVZ6eUxZS0E5eVZ4Zk9QcEJEQnRzWnZY?=
 =?utf-8?B?NGpPYmNlbmZUNVplZDNLTklmeWQ0VFNTeE01Z0hFMG95WkY4Vm1JOXVoL2Iv?=
 =?utf-8?B?RlRQYUpKaExqN3l4VTFjeGZUdkVoeHJST0VlTmVvOGYxaWNHQXNtWGFHU0hh?=
 =?utf-8?B?VU9iQ2xzUW9vSE9ialNVdUc1Z21tQnFJYkd3c3BEbS9IVXROWnloanBlckkr?=
 =?utf-8?B?enNwODF4WWpGR2FxTGExbitKelN0RjJoTmVGMzBPRk5xZ0FaekkzM1pQNEVz?=
 =?utf-8?B?KzJ3ZEVuZWp4aExTL1Bnb2ZpQStzWGZuKzJQWWxOSFBqTkNtOTNMeXAxZEdT?=
 =?utf-8?B?K052MkVsbnZES3Y0clhQczlTNU96aW03c2IzYUY4dmJUUzNXeExWSFBVc2w3?=
 =?utf-8?B?NWVXVnlmMmNYOGpIRFlMSFRzQ3cxQ1A0MXQ1dkdyY3JqTnNnVWhSVXlPMDJa?=
 =?utf-8?B?c1pXTTB2YkxnenFvUDZUVFRSSGpSTkZaK1JpeWtNTzJ1Y0ljbmFZOWRSblUz?=
 =?utf-8?B?czJuMmg2UE4xcTFqdUJGbnBwTWpobStWRS9GTnBXMjNBUkMrbU5SMmhGYjF6?=
 =?utf-8?B?d05YWUNFb2dIWnJjS1B6R1A3cklxb3VlTHhxdDJrMVVQbUZ2WDVZYmFUUk9v?=
 =?utf-8?B?Q2VDNWt3ci9hN3ZlbS9tYk9nZVNpdTllUzE2eTUvRlRYYjFwd1UrZz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6e8314f-d0b9-46ed-d780-08da31c16ebe
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1201MB0181.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 13:40:08.5139
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9UwR3SphWapWQfg12i77HQZA6wemPhS2+Ki4QBNoBhmkFYRA3Um04wzBuCLlwCG7jbe0mrNd7ITFSJZmYtaiwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6320
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/8/2022 4:39 AM, Suravee Suthikulpanit wrote:
> Originalliy, this WARN_ON is designed to detect when calling
> avic_vcpu_load() on an already running vcpu in AVIC mode (i.e. the AVIC
> is_running bit is set).
> 
> However, for x2AVIC, the vCPU can switch from xAPIC to x2APIC mode while in
> running state, in which the avic_vcpu_load() will be called from
> svm_refresh_apicv_exec_ctrl().
> 
> Therefore, remove this warning since it is no longer appropriate.
> 
> Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> ---
>   arch/x86/kvm/svm/avic.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c
> index ad2ef6c00559..8e90c659de2d 100644
> --- a/arch/x86/kvm/svm/avic.c
> +++ b/arch/x86/kvm/svm/avic.c
> @@ -1059,7 +1059,6 @@ void __avic_vcpu_load(struct kvm_vcpu *vcpu, int cpu)
>   		return;
>   
>   	entry = READ_ONCE(*(svm->avic_physical_id_cache));
> -	WARN_ON(entry & AVIC_PHYSICAL_ID_ENTRY_IS_RUNNING_MASK);
>   
>   	entry &= ~AVIC_PHYSICAL_ID_ENTRY_HOST_PHYSICAL_ID_MASK;
>   	entry |= (h_physical_id & AVIC_PHYSICAL_ID_ENTRY_HOST_PHYSICAL_ID_MASK);

Looks good to me.

Reviewed-by: Pankaj Gupta <pankaj.gupta@amd.com>