Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Mon, 9 May 2022 16:19:03 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Samuel Thibault <samuel.thibault@ens-lyon.org>,
        linux-kernel@vger.kernel.org, speakup@linux-speakup.org
Subject: Re: [PATCHv2] speakup: Generate speakupmap.h automatically
Message-ID: <Ynki154mxF+2L8WH@kroah.com>
References: <20220430003934.fkua7vwoz6heigrp@begin>
 <20220430073321.6b4lvrrt7buzh7dp@begin>
 <YnkfeyobcOOgDGkH@kroah.com>
 <20220509140705.n3eei4r5ko6bbex4@begin>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220509140705.n3eei4r5ko6bbex4@begin>
Precedence: bulk

On Mon, May 09, 2022 at 04:07:05PM +0200, Samuel Thibault wrote:
> Hello,
> 
> Greg KH, le lun. 09 mai 2022 16:04:43 +0200, a ecrit:
> > Any reason you can't add the code in utils.c into genmap.c and then
> > merge into makemapdata.c to make this a single .c file that does both
> > things?
> 
> Yes: genmap is a tool that end-users can use without needing the Linux
> source code, while makemapdata needs it.

But who will run genmap?

Also you could just put the 90 lines of code into the .h file as inline
functions to get rid of the utils.c to make it a bit simpler.

thanks,

greg k-h