Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Pavel Pisa <pisa@cmp.felk.cvut.cz>
To:     Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH] can: ctucanfd: Let users select instead of depend on CAN_CTUCANFD
Date:   Mon, 9 May 2022 16:34:05 +0200
User-Agent: KMail/1.9.10
Cc:     Ondrej Ille <ondrej.ille@gmail.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        "Marc Kleine-Budde" <mkl@pengutronix.de>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <887b7440446b6244a20a503cc6e8dc9258846706.1652104941.git.geert+renesas@glider.be>
In-Reply-To: <887b7440446b6244a20a503cc6e8dc9258846706.1652104941.git.geert+renesas@glider.be>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <202205091634.05147.pisa@cmp.felk.cvut.cz>
Precedence: bulk

Hello Geert,

On Monday 09 of May 2022 16:02:59 Geert Uytterhoeven wrote:
> The CTU CAN-FD IP core is only useful when used with one of the
> corresponding PCI/PCIe or platform (FPGA, SoC) drivers, which depend on
> PCI resp. OF.
>
> Hence make the users select the core driver code, instead of letting
> then depend on it.  Keep the core code config option visible when
> compile-testing, to maintain compile-coverage.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>

Thanks for suggestion, I have no strong opinion/experience there
but I agree that proposed behavior seems more friendly to users. 

>  drivers/net/can/ctucanfd/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/can/ctucanfd/Kconfig
> b/drivers/net/can/ctucanfd/Kconfig index 48963efc7f19955f..3c383612eb1764e2
> 100644
> --- a/drivers/net/can/ctucanfd/Kconfig
> +++ b/drivers/net/can/ctucanfd/Kconfig
> @@ -1,5 +1,5 @@
>  config CAN_CTUCANFD
> -	tristate "CTU CAN-FD IP core"
> +	tristate "CTU CAN-FD IP core" if COMPILE_TEST
>  	help
>  	  This driver adds support for the CTU CAN FD open-source IP core.
>  	  More documentation and core sources at project page
> @@ -13,8 +13,8 @@ config CAN_CTUCANFD
>
>  config CAN_CTUCANFD_PCI
>  	tristate "CTU CAN-FD IP core PCI/PCIe driver"
> -	depends on CAN_CTUCANFD
>  	depends on PCI
> +	select CAN_CTUCANFD
>  	help
>  	  This driver adds PCI/PCIe support for CTU CAN-FD IP core.
>  	  The project providing FPGA design for Intel EP4CGX15 based DB4CGX15
> @@ -23,8 +23,8 @@ config CAN_CTUCANFD_PCI
>
>  config CAN_CTUCANFD_PLATFORM
>  	tristate "CTU CAN-FD IP core platform (FPGA, SoC) driver"
> -	depends on CAN_CTUCANFD
>  	depends on OF || COMPILE_TEST
> +	select CAN_CTUCANFD
>  	help
>  	  The core has been tested together with OpenCores SJA1000
>  	  modified to be CAN FD frames tolerant on MicroZed Zynq based