Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <56f89895-601e-44c9-bda4-5fae6782e27e@amd.com>
Date:   Mon, 9 May 2022 11:06:22 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] x86/mm/cpa: set PAGE_KERNEL in __set_pages_p()
Content-Language: en-US
To:     Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        Rick Edgecombe <rick.p.edgecombe@intel.com>
Cc:     Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Brijesh Singh <brijesh.singh@amd.com>,
        Tianyu Lan <Tianyu.Lan@microsoft.com>,
        "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
        linux-kernel@vger.kernel.org
References: <20220506051940.156952-1-42.hyeyoo@gmail.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20220506051940.156952-1-42.hyeyoo@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHp4TTdrK3ovVnBXTTNta1puaVNSTFZYSC9TcGVTN3lobnliNDV1Rk9QQTFt?=
 =?utf-8?B?UXlwY3BQcDN0eGxiK2locVZHREthbkJWVGNtZUtyaUVNOEJMMXFQQkRDbzN5?=
 =?utf-8?B?ZkcvYlFncUwrcElaQUd1N092OHhqV0trVko4ZVMwYjJrdEVSR0VDdlNROVJ3?=
 =?utf-8?B?VzRhUGduVnc1ZXpqZEY0RGhETGNYajhZTlp0SjZscUpBYnZ5U2pJUEVWRk1Y?=
 =?utf-8?B?ckNxdStzL2xhMjJHc0pxM0NBWG1FVDMrTG15M2dhdEI4MXFXaERXQXJrY0lL?=
 =?utf-8?B?U2g3UlZNZ0k0cnBDYTRTNDhDODhPUWlwR25zelNUTlYxRitjNUhOdTM2SkVt?=
 =?utf-8?B?L1VMOUpmcjIvOXFsdU45b2FqK0o3TkhzaFRzVGVsaTNWWU1UbGVZOXJGa05U?=
 =?utf-8?B?UFpZdm9uU09SVmxxK2JyNmRqdnZLSEJoYUZKRjlPWjU1MTAwN1lkVG1rckhH?=
 =?utf-8?B?THM4UU9HRVJNbGxCT3hnZXFocGRnbW0zMXlXTTBXUEVnYitkUTI3RHJvejZC?=
 =?utf-8?B?L09GSnZWVTZsdGVrQVlCcGRWVUxTNmJjODBwM3YrcllKWlVUUGlVbUpBU1Vp?=
 =?utf-8?B?YUU5RkZMQUJ2MkYvLzdiLzNKQXFuVTJ3eVNVdGZmY0xieVpPeldSSDJRK2RN?=
 =?utf-8?B?NGRKUjJwQVpJMGc3anFzeGRLRnlNYktIQzMzWkVoeW02OTlPOWdLUGloWVN1?=
 =?utf-8?B?K2dxTEdpbDF5TmxKV21XWkROQ1dsR2VQb2ZueGRpWU00WWNBMzlRdE10eDdi?=
 =?utf-8?B?QXVDUjJYUHUvWDVINVBGSlNFYjhEc0VJdUV6YXFuVlE2ZUR2WkJEbFRSbGM5?=
 =?utf-8?B?UjU2eEZVRHlWamU5L1NvdDQySmJ3emdOUW5zNVhTOUgzbWJWemY4a1dLbHAv?=
 =?utf-8?B?YW9tOVlWS2tSNjBsRzFqb2w4WTVKczZFQmoydnQwWkEvSElRZGh1K1N5cEtX?=
 =?utf-8?B?Ykl5U0NwQ2RCb3dwQWl0YW1zZldBZFcrNFM3Ukl1eHBlN2FDV2hDMFVpaVpz?=
 =?utf-8?B?blRPNjR3dVY0MURLa1VlR25nNTh5dzFGM3dvR2tXclp6VngxMHhGdVRCZU9O?=
 =?utf-8?B?V09CblozZjhtUU5zdWZILzFDWHh3WmJibHFsQU1SNy9ZUVIvZUwxaDZzUFVS?=
 =?utf-8?B?SkxlT2pIdHNuY2lVdkxPRkV0eFg2cGJSdTRwRXVHRnZpZ0VrR0MvWVl2YmNm?=
 =?utf-8?B?dmx0S04rOHJCYzNRMno0SzZIZENXS3BhajJQZVErN0dnMXBzOHQ3bnZsNkhW?=
 =?utf-8?B?WWNKTi9TUis0STVYdkZoM2gzTHp6MFVQaWpJWE1tMkl5MHJQYnpjVlVpN2xy?=
 =?utf-8?B?cUV0b2l5MStMc0VmcEVQcmRiUmdHNm9VR2hZSmJpRG9jS3RmblU3UEtNVXNo?=
 =?utf-8?B?Mll0Y3FQMHF0Y3Y5WmZVSXFBWWF3RlR6MVkzVFN2eC9iNTUyOXhWZko1aVRr?=
 =?utf-8?B?N05BckNBa0Q5UFZ0c3V1OExWNXBYZ2I1VHFsYjBWVU8zVlNwV055RzdpcjhW?=
 =?utf-8?B?RElrTkplb21RMzIzQk13M01sOGJKM0dwL21ieFUzTmx6WktSc3kyMUNzYnll?=
 =?utf-8?B?Q3JZRUZESUk0TEF3S1YyQzhOTDh0NFhzZHdBeDNrYlQzckdoN1p6TzhQaGdC?=
 =?utf-8?B?aVBja0JnYUQ4R1crcmNlYlhxZlB6blJIaFJlM2oxbzFKZ2JXek9VeFA2M1JJ?=
 =?utf-8?B?MkZaVFNxS0p6YjJNWHFhUWVnSXBoVzE3VGM2TEROVDNLd1BBZ2p2WThqWCtw?=
 =?utf-8?B?ZmoyVnA4Wms3ZktHcFlJWitFR2hNbEVvYzVjZWFiR0R3RXpuT1Joc2xtMHBm?=
 =?utf-8?B?SzhqWWYzU3dIaXpSUTlocnIrbjIySGhzektYd3Y5em5hQWZiODlZblhnZE5R?=
 =?utf-8?B?UVU1ZEFFNWtQYVd0RS9DSS91eElxWHRwN0ZmaHlZYmhiWDFteGcxV3hnallm?=
 =?utf-8?B?Y3dkKzVMaGgxWXNVdkRsR2lrSk9XSHg1emVUeGwyUDVEajBWa1dVVktFaUts?=
 =?utf-8?B?WGxUZjBNcnQvWTBFQ0E3d2Z5T1RnZDNVZXBjajkveDQ1emFkV0h1bHNDMFpG?=
 =?utf-8?B?ZWd5SzJGcHduMHhMME9WdGYwNUtCNUNkbWxPYUtBdFJ6b01mb3dla0JpcHdI?=
 =?utf-8?B?NFRTZkNxWEtMZkVzUTRVaWNhU3NJdHJPbkt2NEk4WDl3d3RCS2VmN2hZNC9G?=
 =?utf-8?B?R3dWY2VXWkFCSzdoY21uUHNNZURuMnlRaWlsVFc4L3BwbUdJano2b1ZHMEhm?=
 =?utf-8?B?eDc1ZnVpS082ZjJRb3Z6OVZDQlZ0eGFqYjJPWk9TL1hRTytpNmFnc3NxaWFu?=
 =?utf-8?B?ZFNCbXJaQzFkTkhScVhCaXgrcXpmZ2IveW9xYmp0cTFkOXBaOUdCZz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 209eb63b-5105-4eb6-c16f-08da31d5ddd7
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2022 16:06:24.7608
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3i4tgmUwwu9sUkaiQiQOhBi1KtQ/9cxldUq9CLOrUfnagKj4CRYhM/BPk1sEbVOZt0PmjmA4f9bKSZWQziqiAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3475
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/6/22 00:19, Hyeonggon Yoo wrote:
> __set_pages_np() not only clears _PAGE_PRESENT and _PAGE_RW, but also
> clears _PAGE_GLOBAL to avoid confusing _PAGE_GLOBAL as _PAGE_PROTNONE
> when the PTE is not present.
> 
> Common usage for __set_pages_p() is to call it after __set_pages_np().
> Therefore calling __set_pages_p() after __set_pages_np() clears
> _PAGE_GLOBAL, making it unable to globally shared in TLB.
> 
> As they are called by set_direct_map_{invalid,default}_noflush(),
> pages in direct map cannot be globally shared in TLB after being used by
> vmalloc, secretmem, and hibernation.
> 
> So set PAGE_KERNEL isntead of __pgprot(_PAGE_PRESENT | _PAGE_RW) in
> __set_pages_p().
> 
> Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
> ---
>   arch/x86/mm/pat/set_memory.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c
> index abf5ed76e4b7..fcb6147c4cd4 100644
> --- a/arch/x86/mm/pat/set_memory.c
> +++ b/arch/x86/mm/pat/set_memory.c
> @@ -2177,7 +2177,7 @@ static int __set_pages_p(struct page *page, int numpages)
>   	struct cpa_data cpa = { .vaddr = &tempaddr,
>   				.pgd = NULL,
>   				.numpages = numpages,
> -				.mask_set = __pgprot(_PAGE_PRESENT | _PAGE_RW),
> +				.mask_set = PAGE_KERNEL,

With SME/SEV, this will also (unintentionally) set the encryption bit, so 
I don't think this is correct.

Thanks,
Tom

>   				.mask_clr = __pgprot(0),
>   				.flags = 0};
>