Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 9 May 2022 18:28:54 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Samuel Thibault <samuel.thibault@ens-lyon.org>,
        linux-kernel@vger.kernel.org, speakup@linux-speakup.org
Subject: Re: [PATCHv2] speakup: Generate speakupmap.h automatically
Message-ID: <YnlBRt1rAMPKWeYJ@kroah.com>
References: <20220430003934.fkua7vwoz6heigrp@begin>
 <20220430073321.6b4lvrrt7buzh7dp@begin>
 <YnkfeyobcOOgDGkH@kroah.com>
 <20220509140705.n3eei4r5ko6bbex4@begin>
 <Ynki154mxF+2L8WH@kroah.com>
 <20220509142642.gsi5cppgadc2gojy@begin>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220509142642.gsi5cppgadc2gojy@begin>
Precedence: bulk

On Mon, May 09, 2022 at 04:26:42PM +0200, Samuel Thibault wrote:
> Greg KH, le lun. 09 mai 2022 16:19:03 +0200, a ecrit:
> > On Mon, May 09, 2022 at 04:07:05PM +0200, Samuel Thibault wrote:
> > > Greg KH, le lun. 09 mai 2022 16:04:43 +0200, a ecrit:
> > > > Any reason you can't add the code in utils.c into genmap.c and then
> > > > merge into makemapdata.c to make this a single .c file that does both
> > > > things?
> > > 
> > > Yes: genmap is a tool that end-users can use without needing the Linux
> > > source code, while makemapdata needs it.
> > 
> > But who will run genmap?
> 
> I guess you meant makemapdata?
> 
> Long-term-wise this patchset will need a bit of work to properly install
> the genmap tool so the user can call it.  I'm here mostly making sure
> to put into the Linux kernel how speakupmap.h is generated (rather
> than the currently very magic file), while at the same time keeping
> the separation between makemapdata and genmap that will make sense
> longterm-wise.

Ok, then it's ok to leave it as is.  But the build stuff still needs to
get resolved :)