Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Gabriel Krisman Bertazi <krisman@collabora.com>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        io-uring@vger.kernel.org,
        ZiyangZhang <ZiyangZhang@linux.alibaba.com>,
        Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>
Subject: Re: [RFC PATCH] ubd: add io_uring based userspace block driver
Organization: Collabora
References: <20220509092312.254354-1-ming.lei@redhat.com>
        <8e3ecd00-1c73-7481-fec2-158528b2798f@infradead.org>
Date:   Mon, 09 May 2022 14:11:19 -0400
In-Reply-To: <8e3ecd00-1c73-7481-fec2-158528b2798f@infradead.org> (Randy
        Dunlap's message of "Mon, 9 May 2022 09:00:37 -0700")
Message-ID: <87bkw6lgoo.fsf@collabora.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Randy Dunlap <rdunlap@infradead.org> writes:

> On 5/9/22 02:23, Ming Lei wrote:
>> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
>> index fdb81f2794cd..3893ccd82e8a 100644
>> --- a/drivers/block/Kconfig
>> +++ b/drivers/block/Kconfig
>> @@ -408,6 +408,13 @@ config BLK_DEV_RBD
>>  
>>  	  If unsure, say N.
>>  
>> +config BLK_DEV_USER_BLK_DRV
>> +	bool "Userspace block driver"
>> +	select IO_URING
>> +	default y
>
> Any "default y" driver is highly questionable and needs to be justified.
>
> Also: why is it bool instead of tristate?

I think it's only bool because it depends on task_work_add, which is not exported to
modules.  It is something to be fixed for sure, can that function just be exported?

-- 
Gabriel Krisman Bertazi