Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 9 May 2022 15:03:48 -0700
From:   Kees Cook <keescook@chromium.org>
To:     ira.weiny@intel.com
Cc:     Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Rick Edgecombe <rick.p.edgecombe@intel.com>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V10 08/44] Documentation/pkeys: Add initial PKS
 documentation
Message-ID: <202205091501.132944B2C7@keescook>
References: <20220419170649.1022246-1-ira.weiny@intel.com>
 <20220419170649.1022246-9-ira.weiny@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220419170649.1022246-9-ira.weiny@intel.com>
Precedence: bulk

On Tue, Apr 19, 2022 at 10:06:13AM -0700, ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> Add initial overview and configuration information about PKS.
> 
> Cc: "Moger, Babu" <Babu.Moger@amd.com>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> 
> ---
> Changes for V9
> 	Feedback from Dave Hansen
> 		Remove overview and move relevant text to the main pkey
> 		overview which covers both user ans kernel keys.
> 		Add an example of using Kconfig
> 		Move MSR details to later patches
> ---
>  Documentation/core-api/protection-keys.rst | 43 ++++++++++++++++++++--
>  1 file changed, 39 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/core-api/protection-keys.rst b/Documentation/core-api/protection-keys.rst
> index bf28ac0401f3..13eedb0119e1 100644
> --- a/Documentation/core-api/protection-keys.rst
> +++ b/Documentation/core-api/protection-keys.rst
> @@ -13,6 +13,11 @@ Pkeys Userspace (PKU) is a feature which can be found on:
>          * Intel client CPUs, Tiger Lake (11th Gen Core) and later
>          * Future AMD CPUs
>  
> +Protection Keys Supervisor (PKS) is a feature which can be found on:
> +        * Sapphire Rapids (and later) "Scalable Processor" Server CPUs
> +        * Future non-server Intel parts.
> +        * qemu: https://www.qemu.org/2021/04/30/qemu-6-0-0/

It looks like QEMU has pass-through support, but not emulation? It'd be
really nice to have this feature emulated so it would be possible to
test the code. (Or I need to find a machine that supports this...)

-- 
Kees Cook