Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp5430741iob; Mon, 9 May 2022 16:35:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyG326g/Y6i2Lyi13yCOhLV7Y5IzseixRR+T1w4IP0ausa5WEjsd8kc29CCjb75h3r7cHi2 X-Received: by 2002:a37:68d7:0:b0:69f:fd74:7cbf with SMTP id d206-20020a3768d7000000b0069ffd747cbfmr13244061qkc.91.1652139344401; Mon, 09 May 2022 16:35:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652139344; cv=none; d=google.com; s=arc-20160816; b=FrC7MUV+cb0jJT9A7eGYUeykCkQ/RoCB3OzRjRjaEP2eeSBFSwVbNeOsN3a6Cfr+4v ziy847dX9PbrRHbCYBavxQpqEEq9r6B3E43FCbIAc31H+ampfRfoNaNUxEqXnx/P5rWt bYF4UlZHHtcdUP5LDNF+b9DfCoi8Hf4vxS/jLWkl0qYVXN2bO9s9OqhTeGKQN7SlyS0J 1mdzpqqMnfiXxcM4jsWaNo1V4mrRKTqjfHNAuNXFU0vHN8puqH1C2yN5uqW8dyb7FZ+a P3Yw3khE2sgeeaykwDNSE3DnINw9qW1ImIdI5AeCByIxmIwYLYwlSPS1i+/Vpc20LRM4 Bw7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:from:cc:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject :dkim-signature; bh=tZRB3zIhTe4/kb2F6h0EyN2enk/ffsUfIt+uwvi71Kg=; b=uL3OZEwrw0fTEit/+B8DKJIMgWOEV5njDcgopNAQM0hM5swJS1AHeL7rYHbz2azNqV czlsLiKEL8keL3uWdvasOYY0kRiycrMO7r31iQuB081KQI9iA+yDst3ycZd2IO1hyT+m TXQfgYBIVrRdckiJt/dSL3rJwTunUG79T46ePBt5fm1/MxVcU/ZpRY5dPcAa7Pd+VAYq kGtBLV3POHxsdQxxGF6SCAHTxiOTES7YT3DgrI/X6kcXbqgRBPHcmy2TfEdxgh9DXlpQ CQmj/wyzeCLLK639797iwP5mWfIwjN8R6M8mWxgxkFX0DiXzdDo2fv+rsnDLovlxn1P9 9nxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b=J+qsV4sW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w14-20020a05620a424e00b0069c3f35309asi8858004qko.406.2022.05.09.16.35.29; Mon, 09 May 2022 16:35:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b=J+qsV4sW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231831AbiEIWgm (ORCPT + 99 others); Mon, 9 May 2022 18:36:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229665AbiEIWgX (ORCPT ); Mon, 9 May 2022 18:36:23 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DAFB2B94FB for ; Mon, 9 May 2022 15:32:28 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id x23so13411326pff.9 for ; Mon, 09 May 2022 15:32:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding:cc:from:to; bh=tZRB3zIhTe4/kb2F6h0EyN2enk/ffsUfIt+uwvi71Kg=; b=J+qsV4sWyFVIgrDABezJovYhrW4Jzg11JZEk3WHOu3XuH7ze7t8fja6VuYB/Q9+tvp hEGF1icNSsM/0iiwFW281ATk7W6c7j7aGjBVYF99/u2B+jtb1YPKidpHvOTI9Jz4Lxh0 6ez184UbojY7hhrrt0T6FZE8HWD85dHmAjAnZ8oC2Zoi0XQiqEUxOtwdNZdV12X1XPpb eOYtED253uK5GFiuWQ0wMSV73xWdJ5eHnN6WbBvwyOEpmAXVeAgkp/8WXuJtj+PnD01O qpc9n7G8viwouPMU6f6ZYvZjxFGQ2Vre7sEym/xdvKnlQk1eXINRDKWRRUAa4P4IDS/e ukRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:cc:from:to; bh=tZRB3zIhTe4/kb2F6h0EyN2enk/ffsUfIt+uwvi71Kg=; b=232Dj/WJFqkjLbJfn6z0sogU0sWhbKGluU1yVhCTtHfYTEgEFGI1IDFhxZJKhqW/CF mabaYK4e2eEpVCVC5sSDRcJaKs8Nzcd7FDRerpeWqxOlBa2fS8BEqhi49gHUpY1VDGM8 qQC4SS6b+Liqo8uWWdA3xkUs86VhbtzLwH5Mp/EpsOzwqmO4wId6H1u+fatFo3Ry97tW MNCzYZtIdagz9iQ+8CDt9V/TJwMSJizC2lHiD5i0qXj5tLA01A9Uep6lDU2UAZ5b0AON bTs2n3hIf6NwKhTripKUMWoS34nH2WKK0rSMnyjYr0Qv3QhQg7wYc0KXR2OMvOwm902A c9VQ== X-Gm-Message-State: AOAM532eSLFbcsBPWePKzBfoR/und1cDSbchxcDvOe4N3s2LWnzvA4Zg yEyjFdTkR9rNAXvXQQ/tKNyiFA== X-Received: by 2002:a63:8749:0:b0:3c6:aa1d:bd3c with SMTP id i70-20020a638749000000b003c6aa1dbd3cmr7379146pge.403.1652135548093; Mon, 09 May 2022 15:32:28 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id 20-20020a630d54000000b003c14af50627sm9008129pgn.63.2022.05.09.15.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 15:32:27 -0700 (PDT) Subject: [PATCH v5 4/7] openrisc: Move to ticket-spinlock Date: Mon, 9 May 2022 15:29:53 -0700 Message-Id: <20220509222956.2886-5-palmer@rivosinc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220509222956.2886-1-palmer@rivosinc.com> References: <20220509222956.2886-1-palmer@rivosinc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: guoren@kernel.org, peterz@infradead.org, mingo@redhat.com, Will Deacon , longman@redhat.com, boqun.feng@gmail.com, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, Paul Walmsley , Palmer Dabbelt , aou@eecs.berkeley.edu, Arnd Bergmann , macro@orcam.me.uk, Greg KH , sudipm.mukherjee@gmail.com, jszhang@kernel.org, linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org, openrisc@lists.librecores.org, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Palmer Dabbelt From: Palmer Dabbelt To: Arnd Bergmann X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Zijlstra We have no indications that openrisc meets the qspinlock requirements, so move to ticket-spinlock as that is more likey to be correct. Signed-off-by: Peter Zijlstra (Intel) Acked-by: Stafford Horne Reviewed-by: Arnd Bergmann --- arch/openrisc/Kconfig | 1 - arch/openrisc/include/asm/Kbuild | 5 ++-- arch/openrisc/include/asm/spinlock.h | 27 ---------------------- arch/openrisc/include/asm/spinlock_types.h | 7 ------ 4 files changed, 2 insertions(+), 38 deletions(-) delete mode 100644 arch/openrisc/include/asm/spinlock.h delete mode 100644 arch/openrisc/include/asm/spinlock_types.h diff --git a/arch/openrisc/Kconfig b/arch/openrisc/Kconfig index 0d68adf6e02b..99f0e4a4cbbd 100644 --- a/arch/openrisc/Kconfig +++ b/arch/openrisc/Kconfig @@ -30,7 +30,6 @@ config OPENRISC select HAVE_DEBUG_STACKOVERFLOW select OR1K_PIC select CPU_NO_EFFICIENT_FFS if !OPENRISC_HAVE_INST_FF1 - select ARCH_USE_QUEUED_SPINLOCKS select ARCH_USE_QUEUED_RWLOCKS select OMPIC if SMP select ARCH_WANT_FRAME_POINTERS diff --git a/arch/openrisc/include/asm/Kbuild b/arch/openrisc/include/asm/Kbuild index ca5987e11053..3386b9c1c073 100644 --- a/arch/openrisc/include/asm/Kbuild +++ b/arch/openrisc/include/asm/Kbuild @@ -1,9 +1,8 @@ # SPDX-License-Identifier: GPL-2.0 generic-y += extable.h generic-y += kvm_para.h -generic-y += mcs_spinlock.h -generic-y += qspinlock_types.h -generic-y += qspinlock.h +generic-y += spinlock_types.h +generic-y += spinlock.h generic-y += qrwlock_types.h generic-y += qrwlock.h generic-y += user.h diff --git a/arch/openrisc/include/asm/spinlock.h b/arch/openrisc/include/asm/spinlock.h deleted file mode 100644 index 264944a71535..000000000000 --- a/arch/openrisc/include/asm/spinlock.h +++ /dev/null @@ -1,27 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ -/* - * OpenRISC Linux - * - * Linux architectural port borrowing liberally from similar works of - * others. All original copyrights apply as per the original source - * declaration. - * - * OpenRISC implementation: - * Copyright (C) 2003 Matjaz Breskvar - * Copyright (C) 2010-2011 Jonas Bonn - * et al. - */ - -#ifndef __ASM_OPENRISC_SPINLOCK_H -#define __ASM_OPENRISC_SPINLOCK_H - -#include - -#include - -#define arch_spin_relax(lock) cpu_relax() -#define arch_read_relax(lock) cpu_relax() -#define arch_write_relax(lock) cpu_relax() - - -#endif diff --git a/arch/openrisc/include/asm/spinlock_types.h b/arch/openrisc/include/asm/spinlock_types.h deleted file mode 100644 index 7c6fb1208c88..000000000000 --- a/arch/openrisc/include/asm/spinlock_types.h +++ /dev/null @@ -1,7 +0,0 @@ -#ifndef _ASM_OPENRISC_SPINLOCK_TYPES_H -#define _ASM_OPENRISC_SPINLOCK_TYPES_H - -#include -#include - -#endif /* _ASM_OPENRISC_SPINLOCK_TYPES_H */ -- 2.34.1