Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CGME20220509073953epcas1p127f2d36186316642068c92c5d9dee1c4@epcas1p1.samsung.com>
 <20220509074330.4822-1-jaewon31.kim@samsung.com>
In-Reply-To: <20220509074330.4822-1-jaewon31.kim@samsung.com>
From:   Jaewon Kim <jaewon31.kim@gmail.com>
Date:   Tue, 10 May 2022 09:00:12 +0900
Message-ID: <CAJrd-UvRgtox=JD3jMKiUouHO7Jj42_qAfsZv5Rx38TKMdLv1A@mail.gmail.com>
Subject: Re: [RFC PATCH] page_ext: create page extension for all memblock
 memory regions
To:     Jaewon Kim <jaewon31.kim@samsung.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Vlastimil Babka <vbabka@suse.cz>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

let me add Joonsoo Kim

2022=EB=85=84 5=EC=9B=94 9=EC=9D=BC (=EC=9B=94) =EC=98=A4=ED=9B=84 4:39, Ja=
ewon Kim <jaewon31.kim@samsung.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> The page extension can be prepared for each section. But if the first
> page is not valid, the page extension for the section was not
> initialized though there were many other valid pages within the section.
>
> To support the page extension for all sections, refer to memblock memory
> regions. If the page is valid use the nid from pfn_to_nid, otherwise use
> the previous nid.
>
> Also this pagech changed log to include total sections and a section
> size.
>
> i.e.
> allocated 100663296 bytes of page_ext for 64 sections (1 section : 0x8000=
000)
>
> Signed-off-by: Jaewon Kim <jaewon31.kim@samsung.com>
> ---
>  mm/page_ext.c | 42 ++++++++++++++++++++++--------------------
>  1 file changed, 22 insertions(+), 20 deletions(-)
>
> diff --git a/mm/page_ext.c b/mm/page_ext.c
> index 2e66d934d63f..506d58b36a1d 100644
> --- a/mm/page_ext.c
> +++ b/mm/page_ext.c
> @@ -381,41 +381,43 @@ static int __meminit page_ext_callback(struct notif=
ier_block *self,
>  void __init page_ext_init(void)
>  {
>         unsigned long pfn;
> -       int nid;
> +       int nid =3D 0;
> +       struct memblock_region *rgn;
> +       int nr_section =3D 0;
> +       unsigned long next_section_pfn =3D 0;
>
>         if (!invoke_need_callbacks())
>                 return;
>
> -       for_each_node_state(nid, N_MEMORY) {
> +       /*
> +        * iterate each memblock memory region and do not skip a section =
having
> +        * !pfn_valid(pfn)
> +        */
> +       for_each_mem_region(rgn) {
>                 unsigned long start_pfn, end_pfn;
>
> -               start_pfn =3D node_start_pfn(nid);
> -               end_pfn =3D node_end_pfn(nid);
> -               /*
> -                * start_pfn and end_pfn may not be aligned to SECTION an=
d the
> -                * page->flags of out of node pages are not initialized. =
 So we
> -                * scan [start_pfn, the biggest section's pfn < end_pfn) =
here.
> -                */
> +               start_pfn =3D (unsigned long)(rgn->base >> PAGE_SHIFT);
> +               end_pfn =3D start_pfn + (unsigned long)(rgn->size >> PAGE=
_SHIFT);
> +
> +               if (start_pfn < next_section_pfn)
> +                       start_pfn =3D next_section_pfn;
> +
>                 for (pfn =3D start_pfn; pfn < end_pfn;
>                         pfn =3D ALIGN(pfn + 1, PAGES_PER_SECTION)) {
>
> -                       if (!pfn_valid(pfn))
> -                               continue;
> -                       /*
> -                        * Nodes's pfns can be overlapping.
> -                        * We know some arch can have a nodes layout such=
 as
> -                        * -------------pfn-------------->
> -                        * N0 | N1 | N2 | N0 | N1 | N2|....
> -                        */
> -                       if (pfn_to_nid(pfn) !=3D nid)
> -                               continue;
> +                       if (pfn_valid(pfn))
> +                               nid =3D pfn_to_nid(pfn);
> +                       nr_section++;
>                         if (init_section_page_ext(pfn, nid))
>                                 goto oom;
>                         cond_resched();
>                 }
> +               next_section_pfn =3D pfn;
>         }
> +
>         hotplug_memory_notifier(page_ext_callback, 0);
> -       pr_info("allocated %ld bytes of page_ext\n", total_usage);
> +       pr_info("allocated %ld bytes of page_ext for %d sections (1 secti=
on : 0x%x)\n",
> +               total_usage, nr_section, (1 << SECTION_SIZE_BITS));
>         invoke_init_callbacks();
>         return;
>
> --
> 2.17.1
>